| *** Joins: giallu (~giallu@fedora/giallu) | 02:35 | |
| *** Joins: asm89 (~asm89@5ED18FE0.cm-7-2c.dynamic.ziggo.nl) | 02:52 | |
| *** Quits: asm89 (~asm89@5ED18FE0.cm-7-2c.dynamic.ziggo.nl) (Changing host) | 02:52 | |
| *** Joins: asm89 (~asm89@unaffiliated/asm89) | 02:52 | |
| *** Joins: dhx1 (~anonymous@60-242-247-232.static.tpgi.com.au) | 03:40 | |
| *** Quits: Protogenes (~Protogene@cmnz-4db37660.pool.mediaWays.net) (Quit: @TEXT<0x6a5934b6> Error reading 0x00000000) | 04:59 | |
| *** Joins: Protogenes (~Protogene@cmnz-4db37660.pool.mediaWays.net) | 05:00 | |
| *** Joins: FrankZZ (~FrankZZ@unaffiliated/frankzz) | 08:34 | |
| *** Joins: daryn (~daryn@h158.249.190.173.static.ip.windstream.net) | 09:38 | |
| *** Quits: FrankZZ (~FrankZZ@unaffiliated/frankzz) (Ping timeout: 252 seconds) | 11:04 | |
| *** Quits: giallu (~giallu@fedora/giallu) (Ping timeout: 252 seconds) | 11:36 | |
| *** Quits: asm89 (~asm89@unaffiliated/asm89) (Quit: bye!) | 12:01 | |
| *** Quits: daryn (~daryn@h158.249.190.173.static.ip.windstream.net) (Remote host closed the connection) | 13:42 | |
| *** Joins: asm89 (~asm89@unaffiliated/asm89) | 13:48 | |
| *** Joins: Paul_46 (~IceChat09@2001:470:9310:aaaa:6951:3315:3e15:b36f) | 14:02 | |
| *** Joins: Balor (3eebcf9c@gateway/web/freenode/ip.62.235.207.156) | 14:26 | |
| Balor | Hello | 14:26 |
|---|---|---|
| Balor | I have some problem on making the github hook for mantisBT works | 14:27 |
| Balor | I configured the API key, and set the github repo | 14:27 |
| Balor | but when I commit, nothing happen. | 14:28 |
| jreese | Balor: there is a known issue with the Github service hook, although I haven't been able to track it down yet | 14:28 |
| jreese | I assume it has to do with a change to their service hook payload | 14:29 |
| Balor | Okay ... I tried with the old method, with the post-receive and the whitelisted IP | 14:29 |
| Balor | didn't worked either ... | 14:29 |
| jreese | I think the post-receive hook also uses the same payload that breaks it | 14:30 |
| Balor | Then I used the cronjob method ... again didn't worked ... I have the error message saying I did the action twice ... | 14:31 |
| jreese | you're giving the wrong URL to the cronjob | 14:31 |
| jreese | just use page=Source/import for the cron | 14:31 |
| Balor | aaah okay not the : curl http://yoururl.xyz/mantisbt/plugin.php?page=Source/repo_import_latest&id=XX | 14:32 |
| Balor | because on your tutorial you typed that. | 14:32 |
| jreese | yeah, that's out of date :/ | 14:32 |
| jreese | never enough time to reconcile that | 14:32 |
| Balor | (Congrat by the way about Bioware :D (Quite a fan of their studio ^^)) | 14:33 |
| jreese | thanks :) | 14:33 |
| jreese | I've been enjoying my work here | 14:33 |
| jreese | my free time isn't helped now that I get free/cheap games from the campus store... :X | 14:34 |
| Balor | about the new URL, do I have to put the id too ? | 14:34 |
| jreese | yes | 14:34 |
| Balor | OO wow that good :D | 14:34 |
| Paul_46 | moo | 14:34 |
| jreese | hi Paul_46 | 14:35 |
| vBm | Balor, if you don't mind paste the exact stuff you're using in cron :D (i'd like the same to make to work) | 14:35 |
| Paul_46 | lo | 14:35 |
| Balor | Well I'm a computer student (in Belgium) and working for Bioware is quite a dream :D | 14:35 |
| Balor | @vBm : of course just let me edit mine first :) | 14:35 |
| vBm | Balor, thanks man :) | 14:35 |
| Paul_46 | right, and off again | 14:37 |
| Paul_46 | :) | 14:37 |
| *** Quits: Paul_46 (~IceChat09@2001:470:9310:aaaa:6951:3315:3e15:b36f) (Quit: He who laughs last, thinks slowest) | 14:37 | |
| Balor | vBm : curl http://www.example.com/mantisbt/plugin.php?page=Source/import&id=XX | 14:37 |
| *** Joins: Paul_46 (~IceChat09@2001:470:9310:aaaa:6951:3315:3e15:b36f) | 14:37 | |
| vBm | Balor, that's all that needs to be added to cron ? | 14:38 |
| Balor | where id is the id of the repo, yes :) | 14:38 |
| vBm | sweet | 14:38 |
| Balor | dont forget to add your server IP in the whitelist | 14:38 |
| vBm | localhost should be just fine right ? | 14:39 |
| Balor | should be, just check the checkbox | 14:40 |
| Balor | @jreese : thanks for your help :D and continue your great work :) | 14:40 |
| vBm | i get "Invalid remote import address" | 14:40 |
| vBm | hmmz | 14:40 |
| jreese | you're welcome :) | 14:40 |
| Balor | hoo ... jreese : seems that I have the same error as vBm | 14:41 |
| Balor | Invalid remote import address | 14:41 |
| Balor | but localhost is in the list ... do I have to put my server IP too ? | 14:41 |
| jreese | you need to check the "enable remote import", and then depending on what URL you use in your cronjob, you may need to enter the server's IP | 14:42 |
| jreese | ie, if you put the full domain in, you probably need to whitelist the server's external IP | 14:42 |
| Balor | I was thinking of using php to run the cron job ... just don't know how to send get parameter | 14:44 |
| Balor | It's maybe the best solution no ? | 14:44 |
| jreese | I always just use curl, I feel it's simpler | 14:44 |
| Balor | But I still have the Invalid remote import address | 14:48 |
| Balor | I added all the IP that my server have | 14:48 |
| jreese | just to cover the bases, you are putting the IPs in the remote import list, and not remote checkin? | 14:49 |
| jreese | sorry, got to get some lunch, bbiab | 14:49 |
| Balor | yep yep ... but ... forgot the IPv6 | 14:49 |
| Balor | okay no problem | 14:50 |
| jreese | only other suggestion I have is to add some debug loggin in the import.php | 14:50 |
| jreese | cheers | 14:50 |
| Balor | Cheers :) | 14:51 |
| *** Quits: Paul_46 (~IceChat09@2001:470:9310:aaaa:6951:3315:3e15:b36f) (Quit: Depression is merely anger without enthusiasm) | 14:53 | |
| *** Quits: Ragnor (~Ragnor@dslb-092-072-245-244.pools.arcor-ip.net) (Read error: Operation timed out) | 16:22 | |
| *** Joins: Ragnor (~Ragnor@dslb-178-009-173-059.pools.arcor-ip.net) | 16:27 | |
| jreese | Balor: did you get to figure out the problem? | 16:28 |
| *** Quits: vBm (~vBm@unaffiliated/vbm) (Ping timeout: 245 seconds) | 16:45 | |
| *** Quits: dhx1 (~anonymous@60-242-247-232.static.tpgi.com.au) (Quit: Leaving) | 17:00 | |
| *** Joins: vBm (~vBm@pro1258.server4you.de) | 17:00 | |
| *** Quits: vBm (~vBm@pro1258.server4you.de) (Changing host) | 17:00 | |
| *** Joins: vBm (~vBm@unaffiliated/vbm) | 17:00 | |
| Balor | jresse : nope can't figure out. I thought of another way to do the import | 17:12 |
| Balor | since you added an API key | 17:12 |
| Balor | why don't use only that for "filtering" | 17:12 |
| Balor | I mean, no need IP any more, just adding a parameter API to the get, checking if it's the same API, and update the given repo if the key match | 17:13 |
| Balor | letting then in the futur, create API Key per repo. | 17:13 |
| Balor | what do you think jreese ? | 17:13 |
| jreese | yeah, I can think of a lot of ways to make it better, I just don't really have the time or need to improve it | 17:14 |
| jreese | I really don't even use Mantis anymore for anything other than on my own site, and most of my work was done for one of my previous employers | 17:14 |
| vBm | what's bioware using ? :D | 17:15 |
| Balor | Well I can give a rapid look, and implement that | 17:15 |
| Balor | @vBm : I bet JIRA :) or homemade thing :) | 17:16 |
| jreese | my studio doesn't really use anything for that atm, but EA in general uses Jira | 17:16 |
| vBm | i only liked flyspray and somewhat of trac ;x ... but got used to mantis so far xD | 17:17 |
| vBm | don't like JIRA at all ;x | 17:17 |
| Balor | If I do a pull request, will you merge it ? | 17:17 |
| jreese | if we get to the point of needing something, I'll push for MantisBT of course, because I can't stand Jira, but those decisions are generally made top-down | 17:17 |
| jreese | Balor: as long as it seems reasonable, ofc | 17:17 |
| Balor | jreese : I never created plugin for mantis but if I right by reading your code | 17:23 |
| Balor | if ( gpc_get_string( 'api_key' ) == plugin_config_get( 'api_key' ) ) { $t_valid = true; } | 17:23 |
| Balor | should do the trick no ? | 17:23 |
| Balor | and then the url will be : http://bug.example.com/plugin.php?page=Source/import&id=13&api_key=XXXXXXXXXXXXXXXXXXXXX | 17:24 |
| jreese | Balor: if you look at pages/checkin.php, it handles the API key there, so you should be able to follow that | 17:24 |
| Balor | Exactly where that snippet is coming from | 17:25 |
| jreese | ok | 17:25 |
| jreese | then yes :) | 17:25 |
| Balor | okay prepare for a simple pull request :P | 17:25 |
| vBm | jreese, Bioware uses which scm ? :P | 17:25 |
| jreese | depends on what group, but my group uses Git | 17:26 |
| jreese | a lot of the game and art teams use Perforce | 17:26 |
| vBm | nice, i've switched to git recently from svn and love it :) | 17:26 |
| jreese | my team has a few public repos on Github: http://github.com/EA2D | 17:27 |
| jreese | the team was absorbed into BioWare, but most of our stuff is still branded EA2D | 17:27 |
| Balor | Pull request done :) | 17:28 |
| vBm | good to know, well all the best wishes for your new job man ... at least dreams come true for some of us :D | 17:28 |
| jreese | thanks, and yes, I'm still amazed that I've even gotten the opportunity | 17:29 |
| jreese | we're still hiring if you're interested in moving to San Francisco :P | 17:29 |
| Balor | Interresting :D but I have to finish my studies first ^^ | 17:30 |
| jreese | ah, yeah | 17:30 |
| Balor | maybe in 1,5 +- | 17:30 |
| Balor | years | 17:30 |
| vBm | if you're hiring cooks i can come :D | 17:30 |
| Balor | and do some other studies after that ... because I don't think a Belgian graduate will be accepted in US XD | 17:31 |
| jreese | vBm: lol, sadly we outsource that to a local company | 17:31 |
| vBm | still just a noob when it comes to coding :) | 17:31 |
| jreese | Balor: you never know, but EA also has plenty of locations in Europe | 17:31 |
| Balor | yeah but Bioware is quite more interesting then only EA :) I'm not a big fan of EA to be honest ^^ | 17:32 |
| Balor | I was so sad when Bioware accepted the offer of EA ... | 17:33 |
| jreese | I'll agree on it being more interesting to be part of BioWare, but EA has really been doing a lot of work to turn the company around and make up for its past mistakes | 17:33 |
| jreese | and at least once you get into EA, it seems much easier to transfer between EA-owned studios down the road | 17:34 |
| jreese | EA really seems to care about employee happiness and growth | 17:34 |
| jreese | and the benefits are fantastic | 17:34 |
| Balor | wow it seems that they really changed :) ... EA games, why not :D | 17:35 |
| Balor | By the way which language are you mostly using ? | 17:35 |
| jreese | a lot of our server-side applications for games are written in Java or C++, but the stuff I'm working on is written in Python | 17:36 |
| Balor | server-side in java ? oO | 17:37 |
| Balor | okay ... I have a problem with curl ... | 17:38 |
| Balor | because when I use the url in my browser | 17:38 |
| Balor | it's working | 17:39 |
| Balor | but with curl | 17:39 |
| Balor | fail | 17:39 |
| jreese | also note that the studio I work for deals with social games, rather than the AAA titles | 17:39 |
| Balor | the new "gold mine" :) | 17:39 |
| jreese | what's the error you get when you use curl? | 17:40 |
| Balor | APPLICATION ERROR #200 | 17:40 |
| Balor | the whole HTML page with that code | 17:40 |
| jreese | so fish the error message out of that HTML :P | 17:40 |
| Balor | A required parameter to this page (api_key) was not found. | 17:41 |
| Balor | ..... wtf Oo | 17:41 |
| Balor | http://bug.example.com/plugin.php?page=Source/import&id=all&api_key=c50a95a703b4e3e2ea22a741 | 17:41 |
| Balor | I used that url ... | 17:42 |
| jreese | are you properly quoting the url to curl? | 17:42 |
| Balor | the quotes --'' ... | 17:42 |
| Balor | well try again with quotes ... | 17:42 |
| Balor | HOLY GOD ... the QUOTES ... the F*cking quotes ... | 17:44 |
| Balor | Now it's working | 17:44 |
| Balor | thanks jreese :) | 17:45 |
| jreese | you're welcome | 17:45 |
| Balor | ho by the way my username on github is Belphemur | 17:46 |
| jreese | I noticed ;) | 17:46 |
| Balor | (Hs : tomorrow ... Mass effect 3 *-*) (Sorry waited so much for that xD) | 17:48 |
| jreese | yeah, I'm waiting impatiently for my copy :P | 17:49 |
| Balor | But as I read, it will be like Mass Effect 2, too bad for the RPG side ... but so good for the story :D | 17:50 |
| Balor | I'm so impatient the Rachni Queen that said to be on my side when the Reaper attack :D | 17:50 |
| vBm | Balor, paste me that cron line please :D | 17:51 |
| Balor | vBm you have to update the import.php first ^^ | 17:51 |
| vBm | already did | 17:52 |
| Balor | okay :D | 17:52 |
| Balor | then : | 17:52 |
| Balor | curl "http://bug.admincmd.com/plugin.php?page=Source/import&id=all&api_key=c50a95a703b4e3e2ea22a741" | 17:52 |
| Balor | well by replacing adminCmd and my api key by yours --'' | 17:52 |
| vBm | ah, easy :) | 17:53 |
| vBm | thanks man | 17:53 |
| Balor | I put all as id, to update all the repo, saw that in the source :P | 17:54 |
| vBm | being that i have 5 repos in it ... freaking sweet | 17:59 |
| Balor | If I have time I'll look in the github hook | 17:59 |
| jreese | Balor: thanks | 17:59 |
| Balor | to understand how it's working, and how to made it work again | 17:59 |
| jreese | you probably should log the value of payload, so that you can verify what's actually getting sent to the plugin | 18:00 |
| vBm | would be great, thanks indeed | 18:00 |
| Balor | It don't know how was the playload before, but they are using JSON now | 18:04 |
| Balor | as I can see here : http://help.github.com/post-receive-hooks/ | 18:04 |
| jreese | yeah, it's always been JSON, I just have a hunch that something changed about its structure or keys that's breaking things | 18:06 |
| *** Quits: asm89 (~asm89@unaffiliated/asm89) (Quit: bye!) | 18:08 | |
| Balor | TILT | 18:26 |
| Balor | the parameter changed | 18:26 |
| Balor | no more repo_name | 18:26 |
| Balor | data | 18:26 |
| Balor | it's now only one parameter | 18:26 |
| jreese | booo | 18:26 |
| Balor | payload | 18:26 |
| Balor | This is sent as a POST with a single parameter: ‘payload’ | 18:26 |
| Balor | as POST | 18:26 |
| Balor | where can I change which parameters are needed by the page ? | 18:27 |
| Balor | it's automatic when using the gpc_ functions ? | 18:27 |
| jreese | yeah | 18:28 |
| jreese | if you pass a second (default value) param to gpc_get_*(), it won't error out if that value isn't given | 18:28 |
| jreese | well, at least that's how I remember it working :P | 18:28 |
| Balor | okay I give a try :D | 18:29 |
| Balor | Okay I can made it work for a Post-Receive Hook | 18:37 |
| Balor | for mantisBT I can't for now | 18:37 |
| Balor | it seems that github is not sending the api_key ... | 18:37 |
| Balor | not as api_key ... | 18:39 |
| Balor | OKAAAY :D | 18:44 |
| Balor | found the bug | 18:44 |
| Balor | Github | 18:44 |
| Balor | is never EVER sending the API_KEY | 18:44 |
| Balor | neither in post or in get | 18:45 |
| jreese | hmm, that's weird... | 18:45 |
| Balor | I parsed the 2 vars | 18:45 |
| Balor | I'm sure of that ... | 18:45 |
| Balor | if i'm not adding in get the api_key | 18:46 |
| Balor | the page is not loaded | 18:46 |
| Balor | if I add it, the page is loaded, and then I got all the param | 18:46 |
| Balor | no api_key in the $_POST | 18:46 |
| Balor | just the payload | 18:46 |
| jreese | perhaps we need to open a bug report against the github-services repo? | 18:47 |
| Balor | should be a good idea :) | 18:47 |
| Balor | I let you do it ^^ | 18:47 |
| jreese | https://github.com/github/github-services/blob/master/services/mantis_bt.rb | 18:47 |
| jreese | I don't really know Ruby too well, but that looks like it should be doing what we want it to | 18:48 |
| jreese | ie, page and api_key should be sent as query params, and payload should be sent as post | 18:48 |
| Balor | okay I try again | 18:49 |
| Balor | the api_key is sended it's because I used the wrong url --'' | 18:50 |
| Balor | but the repo_name is not sended anymore | 18:50 |
| Balor | I'm trying to get it from the json | 18:50 |
| Balor | Okay I can make it work now :D | 18:53 |
| Balor | but I need to know | 18:53 |
| Balor | jreese : what this line is for ? $t_predata = event_signal( 'EVENT_SOURCE_PRECOMMIT' ); | 18:54 |
| Balor | because it's seems that other plugin are intercepting the informations | 18:55 |
| jreese | that allows source plugins to look at the incoming data before processing it, mainly used so that plugins can help the framework know which type of VCS the incoming data is for | 18:55 |
| jreese | yes, that's the point | 18:55 |
| Balor | okay ... but now they aren't working correctly. | 18:55 |
| Balor | I mean, the checkin receive information from that hook | 18:56 |
| *** Joins: Paul_46 (~IceChat09@2001:470:9310:aaaa:c83a:82dd:1869:de82) | 18:56 | |
| Balor | that aren't good | 18:56 |
| jreese | basically, the framework wouldn't know to route data from Github to the Github plugin, without letting all the plugins look at the incoming data beforehand so one of them can claim "ownership" of that data | 18:56 |
| Balor | Okaay now I understand :) | 18:57 |
| Paul_46 | jreese; so you work for a games studio now? | 18:59 |
| jreese | yep | 18:59 |
| jreese | BioWare San Francisco | 18:59 |
| *** Quits: sdfjkljkdfsljkl (~sdfjkljkd@static.96.23.63.178.clients.your-server.de) (Remote host closed the connection) | 19:00 | |
| *** Joins: sdfjkljkdfsljkl (~sdfjkljkd@static.96.23.63.178.clients.your-server.de) | 19:00 | |
| Balor | jreese : new pull request that "should" resolve the github hook issue :D | 19:07 |
| Balor | and all other hook that don't use repo_name | 19:07 |
| jreese | awesome, I'll look at it in a bit | 19:07 |
| Balor | just changed to not ask for the repo_name | 19:08 |
| Balor | spotted another bug in SourceGithub | 19:15 |
| Balor | $t_branch = $p_data['ref_name']; | 19:15 |
| Balor | ref_name is not used anymore | 19:15 |
| Balor | it's just ref | 19:15 |
| *** Quits: Paul_46 (~IceChat09@2001:470:9310:aaaa:c83a:82dd:1869:de82) (Quit: A day without sunshine is like .... night) | 19:17 | |
| Balor | jreese : I can say it :D github hook REPAIRED :D | 19:25 |
| jreese | congrats | 19:25 |
| Balor | I spotted all the bugs :) well only 2 repo_name that don't exist and ref_name replaced by refs :) | 19:26 |
| Balor | @vBm : you can now use the github hook :) | 19:29 |
| Balor | well good night everybody ;) | 19:29 |
| jreese | thanks for the help Balor | 19:29 |
| Balor | no problem :) between open source dev, that's normal :) | 19:30 |
| *** Quits: Balor (3eebcf9c@gateway/web/freenode/ip.62.235.207.156) (Quit: Page closed) | 19:33 | |
| *** Quits: Protogenes (~Protogene@cmnz-4db37660.pool.mediaWays.net) (Disconnected by services) | 22:09 | |
| *** Joins: Protogenes (~Protogene@cmnz-d9bab4dd.pool.mediaWays.net) | 22:10 | |
Generated by irclog2html.py 2.10.0 by Marius Gedminas - find it at mg.pov.lt!