| *** Joins: dregad (~dregad@155.250.128.35) | 00:12 | |
| *** Joins: dhx1 (~dhx1@60-241-62-124.tpgi.com.au) | 02:38 | |
| *** Quits: giallu (~giallu@fedora/giallu) (Ping timeout: 246 seconds) | 04:08 | |
| *** Quits: kirillka (~Miranda@195.242.142.17) (Quit: kirillka) | 06:10 | |
| *** Joins: kirillka (~Miranda@195.242.142.17) | 06:11 | |
| *** Joins: giallu (~giallu@fedora/giallu) | 06:51 | |
| *** Quits: Protogenes (~Protogene@camo146-127.hrz.tu-chemnitz.de) (Quit: @TEXT<0x6a5934b6> Error reading 0x00000000) | 06:58 | |
| *** Quits: kirillka (~Miranda@195.242.142.17) (Quit: kirillka) | 07:04 | |
| *** Joins: Protogenes (~Protogene@cmnz-4db3627a.pool.mediaWays.net) | 08:18 | |
| *** Quits: asm89 (~asm89@unaffiliated/asm89) (Quit: bye!) | 08:49 | |
| *** Joins: asm89 (~asm89@unaffiliated/asm89) | 11:19 | |
| *** Quits: Protogenes (~Protogene@cmnz-4db3627a.pool.mediaWays.net) (Ping timeout: 264 seconds) | 11:50 | |
| *** Joins: giallu_ (~giallu@fedora/giallu) | 11:55 | |
| *** Quits: giallu (~giallu@fedora/giallu) (Ping timeout: 246 seconds) | 11:56 | |
| *** Joins: Protogenes (~Protogene@cmnz-4db3627a.pool.mediaWays.net) | 12:00 | |
| *** Quits: Smiley (~Smiley@last.fm/resident-dj/Smiley) (Remote host closed the connection) | 12:02 | |
| *** Joins: Smiley (~Smiley@cpc23-cove12-2-0-cust135.3-1.cable.virginmedia.com) | 12:02 | |
| *** Joins: jreese (~jreese@noswap.com) | 12:03 | |
| -hobana.freenode.net- [freenode-info] why register and identify? your IRC nick is how people know you. http://freenode.net/faq.shtml#nicksetup | 12:03 | |
| *** Parts: Smiley (~Smiley@last.fm/resident-dj/Smiley) () | 12:29 | |
| *** Joins: paulr (~IceChat09@cpc1-enfi15-2-0-cust580.hari.cable.virginmedia.com) | 12:37 | |
| *** Quits: Protogenes (~Protogene@cmnz-4db3627a.pool.mediaWays.net) (Ping timeout: 264 seconds) | 12:54 | |
| *** Joins: Guest94956 (cf562722@gateway/web/freenode/ip.207.86.39.34) | 13:13 | |
| Guest94956 | Hi | 13:13 |
|---|---|---|
| Guest94956 | file: core/tag_api.php, function: tag_get_candidates_for_bug( $p_bug_id ). The condition: if ( db_is_mssql() ) {...} else {...}. Should this be if ( !db_is_mssql() ) {...} else {...} ? | 13:13 |
| Guest94956 | Because, this query causes Mantis to report a db error if tags have been created. The only way I can resolve this issue is to copy the query from the else{} block into the "db_is_mssql()" query. | 13:13 |
| Guest94956 | The revised function in working condition: http://pastebin.com/ZeRFmPcm | 13:14 |
| paulr | are you running mssql? | 13:15 |
| Guest94956 | paulr: yes | 13:15 |
| paulr | the mssql support is kinda flakey | 13:15 |
| paulr | imo | 13:15 |
| paulr | at least in the current release unfortunately | 13:16 |
| Guest94956 | It's designed to work with mysql primarily, I'm aware. We use sql server however, everything works fine with the native driver from MS except tags. | 13:17 |
| paulr | we're aiming to replace the adodb db layer with a simpler pdo layer | 13:17 |
| paulr | and i've been testing mssql somewhat against that | 13:17 |
| paulr | the stuff in 1.2 etc is fairly broken | 13:18 |
| paulr | in some cases | 13:18 |
| Guest94956 | I think the condition test for mssql was supposed to be the other way around in this function. | 13:18 |
| paulr | my work setup of mantis uses odbc_mssql | 13:19 |
| paulr | and i've used for 3 years | 13:19 |
| Guest94956 | If it detects mssql it does two separate queries, processing one of them manually? | 13:19 |
| paulr | the other db types for mssql ended up being broken | 13:19 |
| Guest94956 | Understandable | 13:22 |
| Guest94956 | What do you think of my proposal? | 13:22 |
| paulr | well | 13:23 |
| paulr | tbh, not sure I care atm :) | 13:24 |
| paulr | you'll find that mssql and odbc_mssql which we started supporting accept and allow different queries in some cases | 13:24 |
| paulr | someone then added a patch to support mssqlnative - which due to drivers, I concluded originally that there's stuff that MS do not implement in their native driver that mantis uses | 13:25 |
| paulr | and in the end myself/david decided to start looking at pdo | 13:25 |
| paulr | [the mssqlnative support came about a year after we starting looking at moving the mantis backend to pdo] | 13:25 |
| paulr | I suspect you'll find that if you delve into it, the current block is required for ado/odbc/mssql but not mssqlnative or similar | 13:26 |
| paulr | if we put pdo layer into mantis, i'd probably be inclined to say that it's down to end user to upgrade mssql and the db's that haven't worked properly in 1.2 | 13:27 |
| Guest94956 | So if you are using the build in mssql drivers then you need to prefetch the sub-query rows, then inject them manually into the IN clause? | 13:28 |
| paulr | as again, in some cases, the adodb stuff has used the wrong data types at some times for particular fields | 13:28 |
| paulr | i dont think odbc allows subqueries | 13:28 |
| paulr | in fact, http://connect.microsoft.com/SQLServer/feedback/details/521409/odbc-client-mssql-does-not-work-with-bound-parameters-in-subquery looks like a bug report on ms site for similar reasons to as that code exists | 13:29 |
| Guest94956 | I see. With the native driver from MS the dbo system delivers the IN clause contents in the wrong data type. The id field is INT IDENTITY(1,1). The dbo system is delivering the values incorrectly for this field? | 13:30 |
| Guest94956 | *odbc system | 13:30 |
| paulr | anyway, as of 2-3 years ago, odbc_mssql was what i used, tested and would encourage using | 13:32 |
| paulr | as of 18-24 months ago, people didn't like running a customised adodb library for php with fixes for odbc so we started looking at moving to a pdo layer for mantis to fix that issues with adodb we had | 13:32 |
| paulr | and 8 months ago people added a mssqlnative layer to adodb | 13:33 |
| paulr | and my conclusion when we started on the pdo route was that the mssqlnative stuff wasn't gonna work easily | 13:35 |
| paulr | so i'm not really surprised | 13:35 |
| Guest94956 | hmm | 13:35 |
| Guest94956 | They said they fixed it but didn't. That was in 2010 | 13:38 |
| Guest94956 | paulr: without changing the driver, is it suggested to use the else clause for my needs at this time? | 13:40 |
| paulr | i'd probaly say go for it | 13:40 |
| paulr | i've been working on a branch/fork of mantis with a view to updating that for more modern stuff | 13:41 |
| Guest94956 | how sure are you that mantis is switching to prepared? Next major release possibly? | 13:41 |
| paulr | my personal view from doing that is that whilst I love mantis, and enjoy it's code base, there's a lot of 'broken' config options etc in the 1.2 stuff | 13:41 |
| paulr | well, if I look at http://www.ohloh.net/p/mantis/contributors?query=&sort=commits | 13:46 |
| paulr | i've done 3rd most number of commits over all time | 13:46 |
| paulr | very little in last 18 months as we've not really spec'd out plan for post 1.2, and been coding in a seperate branch | 13:47 |
| paulr | of the top 12 commits only about 3 are still around | 13:47 |
| paulr | [in an "active" capacity] | 13:48 |
| paulr | ofc - that's all time stats so people that have been around longer are more likely to be higher in the list | 13:48 |
| Guest94956 | Thanks for the advise paulr | 13:55 |
| *** Quits: wolog (~wolog@wolog.info) (*.net *.split) | 13:59 | |
| *** Quits: rk4n3 (~rk4n3@24-159-210-156.static.roch.mn.charter.com) (*.net *.split) | 13:59 | |
| *** Quits: nutron (~nutron@unaffiliated/nutron) (Ping timeout: 252 seconds) | 14:00 | |
| *** Joins: nutron|w (~nutron@24.67.96.21) | 14:00 | |
| *** Joins: wolog (~wolog@wolog.info) | 14:04 | |
| *** Joins: rk4n3 (~rk4n3@24-159-210-156.static.roch.mn.charter.com) | 14:04 | |
| *** Quits: giallu_ (~giallu@fedora/giallu) (Ping timeout: 240 seconds) | 14:33 | |
| *** Joins: giallu_ (~giallu@fedora/giallu) | 14:34 | |
| *** Quits: Guest94956 (cf562722@gateway/web/freenode/ip.207.86.39.34) (Quit: Page closed) | 14:38 | |
| *** Quits: sdfjkljkdfsljkl (~sdfjkljkd@static.96.23.63.178.clients.your-server.de) (Ping timeout: 246 seconds) | 15:09 | |
| *** Quits: asm89 (~asm89@unaffiliated/asm89) (Ping timeout: 246 seconds) | 15:09 | |
| *** Joins: sdfjkljkdfsljkl (~sdfjkljkd@static.96.23.63.178.clients.your-server.de) | 15:09 | |
| *** Quits: sdfjkljkdfsljkl (~sdfjkljkd@static.96.23.63.178.clients.your-server.de) (*.net *.split) | 15:09 | |
| *** Joins: sdfjkljkdfsljkl (~sdfjkljkd@static.96.23.63.178.clients.your-server.de) | 15:10 | |
| *** Joins: asm89- (~asm89@unaffiliated/asm89) | 15:12 | |
| *** Quits: asm89- (~asm89@unaffiliated/asm89) (Quit: bye!) | 15:26 | |
| *** Quits: dregad (~dregad@155.250.128.35) (Quit: Ex-Chat) | 15:36 | |
| *** Quits: giallu_ (~giallu@fedora/giallu) (Ping timeout: 245 seconds) | 16:04 | |
| *** Quits: dhx1 (~dhx1@60-241-62-124.tpgi.com.au) (Quit: Leaving) | 16:13 | |
| *** Quits: FrankZZ (~FrankZZ@unaffiliated/frankzz) (Ping timeout: 252 seconds) | 16:28 | |
| *** FrankZZ` is now known as FrankZZ | 16:28 | |
| *** Quits: FrankZZ (~FrankZZ@fwdev.nl) (Changing host) | 16:28 | |
| *** Joins: FrankZZ (~FrankZZ@unaffiliated/frankzz) | 16:28 | |
| *** Joins: FrankZZ` (~FrankZZ@srv1.fwdev.nl) | 16:30 | |
| *** Quits: paulr (~IceChat09@cpc1-enfi15-2-0-cust580.hari.cable.virginmedia.com) (Quit: A day without sunshine is like .... night) | 16:33 | |
| *** Quits: sdfjkljkdfsljkl (~sdfjkljkd@static.96.23.63.178.clients.your-server.de) (Remote host closed the connection) | 17:00 | |
| *** Joins: sdfjkljkdfsljkl (~sdfjkljkd@static.96.23.63.178.clients.your-server.de) | 17:00 | |
| *** Joins: kirillka (~Miranda@195.242.142.17) | 23:07 | |
| *** Joins: asm89 (~asm89@unaffiliated/asm89) | 23:22 | |
| *** Joins: giallu_ (~giallu@fedora/giallu) | 23:35 | |
| *** Joins: Protogenes (~Protogene@camo146-127.hrz.tu-chemnitz.de) | 23:50 | |
Generated by irclog2html.py 2.10.0 by Marius Gedminas - find it at mg.pov.lt!