*** Joins: kirillka (~Miranda@195.242.142.17) | 01:14 | |
*** Joins: rac-mb (d5a5bb1e@gateway/web/freenode/ip.213.165.187.30) | 01:59 | |
*** Parts: rac-mb (d5a5bb1e@gateway/web/freenode/ip.213.165.187.30) () | 01:59 | |
*** Joins: giallu (~giallu@fedora/giallu) | 02:36 | |
*** Joins: ak5 (~ak5@1.202.127.195) | 04:09 | |
ak5 | hi for some reason the captcha field doesn't work on my installation of mantisbt | 04:10 |
---|---|---|
*** Joins: dregad (~dregad@155.250.128.35) | 04:15 | |
*** Joins: dhx1 (~anonymous@60-242-247-232.static.tpgi.com.au) | 04:19 | |
dregad | hi dhx1 | 05:42 |
dhx1 | dregad: hey | 05:42 |
dregad | how are things | 05:42 |
dregad | I spent some time trying to fix #13304 - issue with xml parsing errors when displaying error messages in 1.3 | 05:44 |
dregad | was hoping to have your feedback on this | 05:44 |
dregad | https://github.com/dregad/mantisbt/commits/fix-13304-xml-errors | 05:45 |
dregad | if you don't mind having a look and let me know what you think | 05:45 |
dhx1 | fixed in next? :p | 05:45 |
dregad | whenever next / Paul's mantisbt2 become the next master | 05:46 |
dregad | :P~~~ | 05:46 |
dhx1 | you're on the right track | 05:46 |
dhx1 | this bug can only be fixed for instances where we use output buffering | 05:46 |
dhx1 | (which should be all of the time with the current output architecture, file downloads excluded) | 05:47 |
dhx1 | the output buffer needs to be completely flushed and a new error page generated | 05:47 |
dhx1 | the current contents of the output buffer are useless in an error situation | 05:47 |
dhx1 | we don't know what the XHTML markup is and can't close tags/etc | 05:48 |
dhx1 | this is kind of what we do in the 'next' branch with the new Exception handler system | 05:48 |
dregad | so what you're saying is that I shouldn't bother fixing it for 1.3 ? | 05:49 |
dhx1 | you can try... but it will never work perfectly | 05:49 |
dhx1 | that is why I suggest treating every error as fatal | 05:50 |
dhx1 | or ignored | 05:50 |
dhx1 | ! no inline errors ! | 05:50 |
dregad | thought inline had already been removed in 1.3 | 05:50 |
dhx1 | at least with fatal errors the output buffer can be flushed and a new page outputted | 05:50 |
dhx1 | perhaps... | 05:50 |
dregad | in that case, if I understand correctly, you recommend instead of trying to parse the output buffer (in my commit, lines 153-159), to just output html_page_top() again, followed by error output | 05:52 |
dhx1 | not quite | 05:53 |
dhx1 | flush/destroy the output buffer and then output html_page_top... etc | 05:53 |
dregad | yeah that's what I meant | 05:53 |
dhx1 | create a new dedicated error page in other words | 05:53 |
dregad | okay | 05:55 |
dregad | i'll see what I can come up with | 05:55 |
dregad | thanks for your advice | 05:55 |
dhx1 | I'm currently trying to decide whether what I dislike most: pulseaudio or openrc's network configuration format | 05:56 |
dhx1 | let me know how you go | 05:56 |
dhx1 | the aim was to try and get next merged into 'master' as soon as possible | 05:56 |
dhx1 | but that hasn't quite happened yet | 05:56 |
dregad | Well, with you and Paul pulling in different directions does not help | 05:57 |
dhx1 | I will try and cherry pick/merge Paul's changes into 'next' | 05:57 |
dhx1 | as Daryn and myself did earlier with Paul's database work | 05:58 |
dregad | at least now he's pushing his changes to github ;) | 05:58 |
dhx1 | :) | 05:59 |
dregad | some of the stuff he implemented make a lot of sense | 06:00 |
dregad | it just makes me feel bad to see all these individual efforts with a (seeming) lack of common objective | 06:01 |
dhx1 | yeah, open source :) | 06:01 |
dregad | ;) | 06:01 |
dregad | that's why I focus on 1.2 fixes mostly | 06:02 |
dregad | this way I don't have the impression to waste time | 06:02 |
dregad | and only have to live with occasional comments about this or that commit being stupid | 06:04 |
dhx1 | 1.2.x is still important | 06:06 |
dregad | speaking of which, there's something I really want to do which I'm sure will cause some reactions from raised eyebrows to worse | 06:06 |
dhx1 | I'm interested | 06:06 |
* dregad wants to upgrade adodb :) | 06:06 | |
dregad | 5.17 is out now, and includes all the fixes I need to pull oracle support into 1.2 (and 1.3 too) | 06:07 |
dregad | until your new DB model replaces that | 06:07 |
dregad | of course | 06:07 |
dregad | what do you say? | 06:08 |
dhx1 | I'm happy with upgrading ADOdb... I would have done it myself for 1.2.x except... Paul added a bunch of random local patches (MSSQL, etc) a while ago that are hard to split out and merge back in to 5.17 | 06:11 |
dhx1 | I tried to move away from a custom ADOdb installation in 1.3.x | 06:11 |
dhx1 | and from memory I think it is vanilla ADOdb? | 06:11 |
*** Quits: ak5 (~ak5@1.202.127.195) (Ping timeout: 245 seconds) | 06:18 | |
dregad | correct, 1.3 is on vanilla | 06:18 |
dregad | the problem with paul's fixes in 1.2 is that they were committed as one batch, and they are not documented | 06:19 |
dregad | (as we have already discussed on the mailing list) | 06:19 |
dhx1 | yeah | 06:19 |
*** Joins: ak5 (~ak5@1.202.127.195) | 06:20 | |
dregad | i'm tempted to revert 1.2 to vanilla and see if anything breaks | 06:21 |
dhx1 | look at it from the positive side... some things will break, others will be fixed :) | 06:21 |
dregad | rigth | 06:22 |
dregad | anyway if something breaks we can reapply the fix, and then submit patch requests upstream to john lim - he seems to be responsive to documented problems with patches | 06:22 |
dregad | @jreese - if you get a chance can you disable user lintest on mantisbt.org, he's been reporting 6 test issues in the past 10 minutes | 06:23 |
dhx1 | responsiveness wasn't always the case though | 06:29 |
dregad | I know | 06:34 |
dregad | but there's been regular releases (every 2-3 months) since July 2011 - after a silence longer than 1 year | 06:36 |
* dregad is hungry - time for lunch :-) | 06:38 | |
*** Quits: ak5 (~ak5@1.202.127.195) (Ping timeout: 244 seconds) | 07:08 | |
*** Quits: kirillka (~Miranda@195.242.142.17) (Ping timeout: 260 seconds) | 08:12 | |
*** Joins: kirillka (~Miranda@195.242.142.17) | 08:28 | |
*** Quits: giallu (~giallu@fedora/giallu) (Ping timeout: 246 seconds) | 11:50 | |
*** Joins: Paul_46 (~IceChat09@cpc1-enfi15-2-0-cust580.hari.cable.virginmedia.com) | 13:15 | |
GitHub185 | [mantisbt] atrol pushed 1 new commit to master: http://git.io/CkoB0A | 15:44 |
GitHub185 | [mantisbt/master] Fix #14306: Tabbing to file upload field not possible on report page - Roland Becker | 15:44 |
GitHub116 | [mantisbt] atrol pushed 1 new commit to master-1.2.x: http://git.io/5XvToA | 15:44 |
GitHub116 | [mantisbt/master-1.2.x] Fix #14306: Tabbing to file upload field not possible on report page - Roland Becker | 15:44 |
Paul_46 | dregad: moo | 16:12 |
GitHub153 | [mantisbt] dregad pushed 1 new commit to master: http://git.io/mqzC1g | 18:31 |
GitHub153 | [mantisbt/master] Fix Excel export of plug-in columns limited to first 100 rows - Damien Regad | 18:31 |
GitHub90 | [mantisbt] dregad pushed 1 new commit to master-1.2.x: http://git.io/N8-d1A | 18:31 |
GitHub90 | [mantisbt/master-1.2.x] Fix Excel export of plug-in columns limited to first 100 rows - Damien Regad | 18:31 |
Paul_46 | dregad: you good at setting up oracle right? | 18:54 |
GitHub20 | [mantisbt] dregad pushed 2 new commits to master: http://git.io/3hZFpg | 18:58 |
GitHub20 | [mantisbt/master] Fix PostgreSQL errors with boolean fields - Damien Regad | 18:58 |
GitHub20 | [mantisbt/master] Optimize filter_db_get_available_queries() - Damien Regad | 18:58 |
GitHub51 | [mantisbt] dregad pushed 2 new commits to master-1.2.x: http://git.io/FABsVQ | 18:58 |
GitHub51 | [mantisbt/master-1.2.x] Fix PostgreSQL errors with boolean fields - Damien Regad | 18:58 |
GitHub51 | [mantisbt/master-1.2.x] Optimize filter_db_get_available_queries() - Damien Regad | 18:58 |
Paul_46 | dhx1: you there? | 19:08 |
*** Quits: Paul_46 (~IceChat09@cpc1-enfi15-2-0-cust580.hari.cable.virginmedia.com) (Quit: I cna ytpe 300 wrods pre mniuet!!!) | 19:34 | |
*** Quits: dhx1 (~anonymous@60-242-247-232.static.tpgi.com.au) (Quit: Leaving) | 19:41 | |
*** Quits: sdfjkljkdfsljkl (~sdfjkljkd@static.96.23.63.178.clients.your-server.de) (Remote host closed the connection) | 20:00 | |
*** Joins: sdfjkljkdfsljkl (~sdfjkljkd@static.96.23.63.178.clients.your-server.de) | 20:00 |
Generated by irclog2html.py 2.10.0 by Marius Gedminas - find it at mg.pov.lt!