| *** Joins: giallu (~giallu@fedora/giallu) | 01:45 | |
| *** Joins: kirillka (~Miranda@195.242.142.17) | 01:46 | |
| GitHub17 | [mantisbt] dregad pushed 1 new commit to master: http://git.io/hOmveA | 04:37 |
|---|---|---|
| GitHub17 | [mantisbt/master] Don't throw error when using db_fetch_array on empty resultset - Vincent Sels | 04:37 |
| GitHub20 | [mantisbt] dregad pushed 1 new commit to master-1.2.x: http://git.io/5bmHvQ | 04:37 |
| GitHub20 | [mantisbt/master-1.2.x] Don't throw error when using db_fetch_array on empty resultset - Vincent Sels | 04:37 |
| *** Joins: dhx1 (~anonymous@60-242-247-232.static.tpgi.com.au) | 04:42 | |
| *** Quits: dregad (~dregad@155.250.128.35) (Quit: Ex-Chat) | 05:58 | |
| *** Quits: kirillka (~Miranda@195.242.142.17) (Quit: kirillka) | 10:02 | |
| *** Joins: linetrace (~linetrace@65.19.81.126) | 16:06 | |
| *** Quits: linetrace (~linetrace@65.19.81.126) (Client Quit) | 16:07 | |
| *** Joins: linetrace (~linetrace@65.19.81.126) | 16:09 | |
| linetrace | jreese: got a sec for implementation questions for the OAuth2 support for the SourceGithub plugin? | 16:14 |
| jreese | sure | 16:14 |
| linetrace | already working, just considerations for polish | 16:14 |
| linetrace | since OAuth is by "application" for GitHub, I initially implemented a plugin-wide config for OAuth | 16:15 |
| linetrace | but realized that one might have a Mantis installation needing to talk to different users/organizations, so would want it at the repo level | 16:15 |
| linetrace | so, in looking at switching that to repo-level, i noticed that the repo info is shown in plaintext (albeit with the management threshold) | 16:16 |
| jreese | yeah, those sorts of problems are why I wasn't sure how to best implement it =\ | 16:17 |
| linetrace | and that'd display the OAuth client ID, secret, and token, which seems very insecure | 16:17 |
| linetrace | user gets to select management threshold, so is that good enough? | 16:17 |
| jreese | I think that should be fine | 16:17 |
| linetrace | obviously, if too many complaints, it can be changed in the future | 16:18 |
| jreese | yeah, but I do think per-repo is the best option | 16:18 |
| linetrace | agreed | 16:18 |
| linetrace | next question is about language strings… naturally i've created some for english, but am not a native german speaker (the other language option)... | 16:18 |
| linetrace | do I leave them blank for someone else to fill in or just do best guess (e.g. Google Translate) | 16:19 |
| jreese | german users will see the english strings as fallback if you don't define them in the german translation file | 16:19 |
| linetrace | perfect | 16:19 |
| *** Joins: kirillka (~Miranda@209-30-68-178.baltnet.ru) | 16:23 | |
| GitHub142 | [mantisbt] jreese pushed 1 new commit to master-1.2.x: http://git.io/QLuM4Q | 16:47 |
| GitHub142 | [mantisbt/master-1.2.x] Rename admin guide folder to fix docbook builds for release/nightlies - John Reese | 16:47 |
| *** Quits: kirillka (~Miranda@209-30-68-178.baltnet.ru) (Quit: kirillka) | 17:14 | |
| *** Quits: linetrace (~linetrace@65.19.81.126) (Quit: linetrace) | 19:08 | |
| *** Joins: Paul_46 (~IceChat09@cpc1-enfi15-2-0-cust580.hari.cable.virginmedia.com) | 19:44 | |
| *** Quits: giallu (~giallu@fedora/giallu) (Ping timeout: 240 seconds) | 19:55 | |
| Paul_46 | moo | 19:55 |
| *** Quits: sdfjkljkdfsljkl (~sdfjkljkd@static.96.23.63.178.clients.your-server.de) (Remote host closed the connection) | 20:00 | |
| *** Joins: sdfjkljkdfsljkl (~sdfjkljkd@static.96.23.63.178.clients.your-server.de) | 20:00 | |
| *** Quits: Paul_46 (~IceChat09@cpc1-enfi15-2-0-cust580.hari.cable.virginmedia.com) (Quit: I cna ytpe 300 wrods pre mniuet!!!) | 20:10 | |
Generated by irclog2html.py 2.10.0 by Marius Gedminas - find it at mg.pov.lt!