| *** Joins: dregad (~dregad@155.250.128.35) | 00:07 | |
| *** Joins: kirillka (~Miranda@195.242.142.17) | 01:39 | |
| *** Joins: Paul_46 (~IceChat09@cpc1-enfi15-2-0-cust580.hari.cable.virginmedia.com) | 02:05 | |
| GitHub164 | [mantisbt] dregad pushed 1 new commit to master-1.2.x: http://git.io/VGhdPw | 02:17 |
|---|---|---|
| GitHub164 | [mantisbt/master-1.2.x] Fix #14574: MSSQL server 2005 as minimum version - Damien Regad | 02:17 |
| GitHub184 | [mantisbt] dregad pushed 1 new commit to master: http://git.io/2f9TVw | 02:17 |
| GitHub184 | [mantisbt/master] Fix #14574: MSSQL server 2005 as minimum version - Damien Regad | 02:17 |
| Paul_46 | dregad: why? | 02:19 |
| dregad | because it does not work properly with earlier versions | 02:19 |
| Paul_46 | tbh, i'd make 2008 the min | 02:21 |
| Paul_46 | as 2005 is in extended support phase and mainstream support phase ended august 2011 | 02:21 |
| dregad | well | 02:21 |
| dregad | we still have PHP 5.1 as minimum, so :/ | 02:22 |
| Paul_46 | we have 5.3.2 in next/2 | 02:22 |
| Paul_46 | :) | 02:22 |
| dregad | http://mantisbt.org/docs/master-1.2.x/en/administration_guide/admin.install.requirements.html#ADMIN.INSTALL.REQUIREMENTS.SOFTWARE.VERSIONS | 02:22 |
| dregad | I should probably update the databases section to clearly indicate that everything except MySQL has issues :P | 02:23 |
| Paul_46 | i should make my branch push here if i haven't already | 02:26 |
| * Paul_46 checks | 02:26 | |
| Paul_46 | shame we dont have a config_Get_bug function | 02:30 |
| dregad | ? | 02:30 |
| Paul_46 | well | 02:32 |
| Paul_46 | config_get_for_bug_id | 02:32 |
| Paul_46 | to save all the project override stuff | 02:33 |
| Paul_46 | i.e. we basically do: | 02:35 |
| Paul_46 | if ( $tpl_bug->project_id != helper_get_current_project() ) { | 02:35 |
| Paul_46 | $g_project_override = $tpl_bug->project_id; | 02:35 |
| Paul_46 | } | 02:35 |
| Paul_46 | access_ensure_bug_level( config_get( 'update_bug_threshold' ), $f_bug_id ); | 02:35 |
| Paul_46 | in some cases we add a config_flush in the middle | 02:35 |
| Paul_46 | dregad: I pushed updated branch btw | 02:40 |
| dregad | what's new ? | 02:41 |
| Paul_46 | stuff ;/ | 02:41 |
| Paul_46 | it's still a work in progress | 02:41 |
| dregad | i think I found the problem with attachment upload we discussed a couple days ago | 02:44 |
| dregad | going from db_query to db_query_bound corrupted attachments | 02:44 |
| dregad | it was caused by use of db_prepare_binary_string which quoted the data | 02:45 |
| dregad | not it seems to work | 02:45 |
| dregad | but the db_prepare function is still needed to properly encode the file contents on pgsql | 02:46 |
| dregad | there is also some encoding for mssql, but i have no idea if that's valid or not, and if it needs to be changed as I cannot test | 02:46 |
| dregad | Paul_46: re updating DB support doc, wdyt of | 02:49 |
| dregad | Note: There are known issues with all of the above platforms except MySQL; moreover, you should be aware that support for DB2, SQL server and Oracle is limited. | 02:49 |
| Paul_46 | i'd say so | 02:50 |
| Paul_46 | re the note | 02:50 |
| *** Quits: giallu (~giallu@fedora/giallu) (Ping timeout: 276 seconds) | 02:50 | |
| Paul_46 | problem is, we worked out adodb is broken, decided to replace it, then started working on fixing adodb | 02:51 |
| Paul_46 | so i've got no idea whats broken/works now | 02:51 |
| Paul_46 | :/ | 02:51 |
| Paul_46 | before dhx removed the custom patches we had for pgsql/mssql both of those worked fine | 02:52 |
| GitHub76 | [mantisbt] none pushed 3 new commits to master-2.0.x: http://git.io/mYmCcQ | 02:57 |
| GitHub76 | [mantisbt/master-2.0.x] oops - Paul Richards | 02:57 |
| GitHub76 | [mantisbt/master-2.0.x] fix undefined array error - Paul Richards | 02:57 |
| GitHub76 | [mantisbt/master-2.0.x] remove unused variable - Paul Richards | 02:57 |
| Paul_46 | dregad: cool that works | 02:57 |
| GitHub20 | [mantisbt] grangeway pushed 1 new commit to master-2.0.x: http://git.io/hn58Ug | 02:57 |
| GitHub20 | [mantisbt/master-2.0.x] helper_get_current_project handles the check for project_override internally - Paul Richards | 02:57 |
| dregad | what, the notices from github to IRC ? | 02:59 |
| Paul_46 | ya | 02:59 |
| *** Joins: giallu (~giallu@fedora/giallu) | 03:06 | |
| *** Joins: giallu_ (~giallu@fedora/giallu) | 03:35 | |
| *** Quits: giallu (~giallu@fedora/giallu) (Ping timeout: 246 seconds) | 03:38 | |
| *** giallu_ is now known as giallu | 03:38 | |
| GitHub110 | [mantisbt] grangeway pushed 1 new commit to master-2.0.x: http://git.io/ACUKOw | 03:40 |
| GitHub110 | [mantisbt/master-2.0.x] the project id passed to version_get_id should be for the current bug in the loop as we may pass in ALL_PROJECTS - Paul Richards | 03:40 |
| GitHub192 | [mantisbt] grangeway pushed 1 new commit to master-2.0.x: http://git.io/lGTN2Q | 03:40 |
| GitHub192 | [mantisbt/master-2.0.x] remove non-required trim statement - Paul Richards | 03:40 |
| GitHub120 | [mantisbt] dregad pushed 1 new commit to master: http://git.io/hekksA | 04:13 |
| GitHub120 | [mantisbt/master] Documentation: RDBMS support note - Damien Regad | 04:13 |
| GitHub125 | [mantisbt] dregad pushed 1 new commit to master-1.2.x: http://git.io/GAslzQ | 04:13 |
| GitHub125 | [mantisbt/master-1.2.x] Documentation: RDBMS support note - Damien Regad | 04:13 |
| GitHub124 | [mantisbt] grangeway pushed 1 new commit to master-2.0.x: http://git.io/treoig | 04:19 |
| GitHub124 | [mantisbt/master-2.0.x] 1) throw exception in both case - Paul Richards | 04:19 |
| GitHub165 | [mantisbt] grangeway pushed 1 new commit to master-2.0.x: http://git.io/n5Iwgg | 04:35 |
| GitHub165 | [mantisbt/master-2.0.x] email api should use config_get to retrieve $g_path and not the global directly - Paul Richards | 04:35 |
| Paul_46 | dregad: is bug -> build a string ? | 05:15 |
| dregad | I think so yes | 05:16 |
| Paul_46 | if ( user_exists( $t_existing_bug->reporter_id ) ) { | 05:33 |
| Paul_46 | bug_monitor( $f_bug_id, $t_existing_bug->reporter_id ); | 05:33 |
| Paul_46 | } | 05:33 |
| Paul_46 | if ( user_exists ( $t_existing_bug->handler_id ) ) { | 05:33 |
| Paul_46 | bug_monitor( $f_bug_id, $t_existing_bug->handler_id ); | 05:33 |
| Paul_46 | } | 05:33 |
| Paul_46 | bug_monitor_copy( $f_bug_id, $t_updated_bug->duplicate_id ); | 05:33 |
| Paul_46 | do the first 4 lines of that code block look redundant ;/ | 05:33 |
| Paul_46 | or in fact, maybe wrong | 05:34 |
| Paul_46 | bug_monitor_copy copies monitor's from bug id to updated bug id | 05:35 |
| Paul_46 | so if you add a duplicate relationship to a bug, it automatically adds someone as a monitor of both bugs | 05:35 |
| * Paul_46 ponders | 05:35 | |
| dregad | there is a difference | 05:49 |
| dregad | the reporter and developer working on the old bug (being copied) may not (and likely will not) be the same as the target bug | 05:49 |
| dregad | so you want to add them to monitor list | 05:50 |
| dregad | makes sense to me | 05:50 |
| Paul_46 | but we add them to the monitor list of the existing bug | 05:56 |
| Paul_46 | and we do it wouthout checking permissions | 05:57 |
| Paul_46 | so if a permission is set such that a reporter can not monitor a bug | 05:57 |
| Paul_46 | as soon as you clone the bug they are a monitor | 05:57 |
| dregad | i thought $f_bug_id was the new bug, since you had $t_existing_bug as the old one | 06:00 |
| dregad | but you're right about permission check | 06:01 |
| Paul_46 | i'm not 100% sure what the correct behaviour should be | 06:03 |
| Paul_46 | i'd *like* to move access_has_bug_level( config_get( 'monitor_bug_threshold' ), $f_bug_id ) inside bug_monitor | 06:03 |
| Paul_46 | was what I was evaluating | 06:04 |
| dregad | was going to suggest that actually | 06:06 |
| Paul_46 | but that would break this behaviour :P | 06:06 |
| dregad | current user should also have monitor_add_others_bug_threshold i guess | 06:07 |
| dregad | why would it break the behavior, I don't follow you | 06:07 |
| Paul_46 | well, in bug_reminder.php we add recipients via bug monitor if they are not handler/reporter, have monitor_bug_thrteshold and reminder_recipients_monitor_bug is on | 06:08 |
| Paul_46 | in bug_monitor we add if monitor_bug_threshold is met if yourself, and monitor_add_others_bug_threshold is met otherwise | 06:09 |
| Paul_46 | in bug_update.php we add reporter/handler to two bug, if you set up a duplicate | 06:10 |
| Paul_46 | and we do similar stuff in bug_copy and bug_resolve | 06:11 |
| dregad | the user list in bug_reminder is driven by bug_reminder_threshold which I guess should not be allowed to be lower than monitor_bug_threshold | 06:12 |
| Paul_46 | if you sponsor an bug you also automatically get added as a monitor | 06:12 |
| Paul_46 | so we've got 4-5 different ways you could get to monitor a bug | 06:13 |
| Paul_46 | and they all check different types of access levels | 06:13 |
| * Paul_46 sighs | 06:16 | |
| * Paul_46 just sighs | 06:16 | |
| Paul_46 | so what we should really have is a 'notifications to sponsors' of an issue | 06:18 |
| Paul_46 | :) | 06:18 |
| dregad | well, depends | 06:18 |
| dregad | in the current way, if a sponsor no longer wants to receive notifications, they can unmonitor the issue, while maintaining sponsorship | 06:18 |
| dregad | it's all centralized under a single functionality for monitoring | 06:19 |
| Paul_46 | but then maybe they should have to sign up for notifications | 06:19 |
| Paul_46 | i.e. if you sponsor an issue, you just sponsori t | 06:19 |
| Paul_46 | if you want to get notifications/udpates you monitor it | 06:19 |
| Paul_46 | where the monitor part checks you have permissions to add monitro | 06:20 |
| Paul_46 | you know, two screens | 06:20 |
| Paul_46 | "you've sponsored issue for 4$, would you also like to receive updates on this issue via email?" | 06:20 |
| Paul_46 | yes/no | 06:20 |
| dregad | guess you're right | 06:21 |
| dregad | one more screen ;) | 06:21 |
| Paul_46 | this is why i'm not too fussed about the "past" | 06:22 |
| Paul_46 | as atm, there's a whole host of config options | 06:22 |
| Paul_46 | that kick in in minor places | 06:22 |
| Paul_46 | so you can have a plugin/config/access check via route A, and you can in some cases achieve the same task via route B with a completely different set of checks/plugins etc | 06:22 |
| Paul_46 | the soap api is probably partly a case in point | 06:23 |
| Paul_46 | some of the ui options atm another | 06:23 |
| *** Quits: kirillka (~Miranda@195.242.142.17) (Quit: kirillka) | 07:14 | |
| *** Quits: dregad (~dregad@155.250.128.35) (Quit: Ex-Chat) | 08:00 | |
| GitHub61 | [mantisbt] rombert pushed 1 new commit to master-1.2.x: http://git.io/j3mH_A | 14:47 |
| GitHub61 | [mantisbt/master-1.2.x] Fix #14558: Monitors get lost when calling mc_issue_update via SOAP - Robert Munteanu | 14:47 |
| GitHub70 | [mantisbt] rombert pushed 1 new commit to master: http://git.io/f44M2w | 14:47 |
| GitHub70 | [mantisbt/master] Fix #14558: Monitors get lost when calling mc_issue_update via SOAP - Robert Munteanu | 14:47 |
| *** Joins: romer628 (~romer628@ip-64-134-181-135.public.wayport.net) | 16:02 | |
| *** Quits: romer628 (~romer628@ip-64-134-181-135.public.wayport.net) (Quit: Leaving.) | 16:09 | |
| *** Quits: Paul_46 (~IceChat09@cpc1-enfi15-2-0-cust580.hari.cable.virginmedia.com) (Quit: When the chips are down, the buffalo is empty) | 16:45 | |
| *** Quits: sdfjkljkdfsljkl (~sdfjkljkd@static.96.23.63.178.clients.your-server.de) (Remote host closed the connection) | 17:00 | |
| *** Joins: sdfjkljkdfsljkl (~sdfjkljkd@static.96.23.63.178.clients.your-server.de) | 17:00 | |
Generated by irclog2html.py 2.10.0 by Marius Gedminas - find it at mg.pov.lt!