| *** Joins: paulr (~IceChat09@cpc1-enfi15-2-0-cust580.hari.cable.virginmedia.com) | 01:33 | |
| *** Joins: e66 (~quassel@27.147.181.37) | 01:59 | |
| *** Joins: dhx1 (~dhx1@60-241-62-124.tpgi.com.au) | 05:12 | |
| *** Joins: EPG (~EPG@pC19EB788.dip.t-dialin.net) | 05:50 | |
| EPG | im trying to implement some kind of approval of issue reports. i have an anonymous reporter account enabled, issues are private by default (approval would be setting them to public by an admin). first problem was that the anonymous user could access his own (private) reports, i solved this by checking user id in access_has_bug_level(). However anonymous can still _list_ the private bugs. where can i prevent this? | 05:55 |
|---|---|---|
| EPG | ok, modifiying $t_public_view_state_check did the job | 06:31 |
| EPG | get_bugnotes_count seems to be dead code | 07:20 |
| EPG | how can i clear the bug_cache? | 07:33 |
| *** Joins: romer628 (~romer628@cpe-76-180-59-236.buffalo.res.rr.com) | 10:02 | |
| *** Parts: romer628 (~romer628@cpe-76-180-59-236.buffalo.res.rr.com) () | 10:03 | |
| *** Joins: kirillka (~Miranda@48-230-55-95.baltnet.ru) | 10:32 | |
| *** Quits: e66 (~quassel@27.147.181.37) (Read error: Connection reset by peer) | 10:44 | |
| GitHub9 | [mantisbt] rombert pushed 1 new commit to master-1.2.x: http://git.io/Yqtn5g | 11:12 |
| GitHub9 | [mantisbt/master-1.2.x] Fix #14737: Date filters do not work with match type = any condition - Robert Munteanu | 11:12 |
| GitHub137 | [mantisbt] rombert pushed 1 new commit to master: http://git.io/GWe3ug | 11:12 |
| GitHub137 | [mantisbt/master] Fix #14737: Date filters do not work with match type = any condition - Robert Munteanu | 11:12 |
| *** Quits: kirillka (~Miranda@48-230-55-95.baltnet.ru) (Quit: kirillka) | 11:23 | |
| *** Joins: kirillka (~Miranda@48-230-55-95.baltnet.ru) | 11:24 | |
| GitHub71 | [mantisbt] rombert pushed 1 new commit to master: http://git.io/40l1nA | 12:17 |
| GitHub71 | [mantisbt/master] bug_report: fix selection of default status and resolution - Robert Munteanu | 12:17 |
| GitHub23 | [mantisbt] rombert pushed 1 new commit to master-1.2.x: http://git.io/_putyw | 12:17 |
| GitHub23 | [mantisbt/master-1.2.x] bug_report: fix selection of default status and resolution - Robert Munteanu | 12:17 |
| *** Quits: kirillka (~Miranda@48-230-55-95.baltnet.ru) (Quit: kirillka) | 12:24 | |
| *** Joins: kirillka (~Miranda@48-230-55-95.baltnet.ru) | 12:25 | |
| *** Quits: kirillka (~Miranda@48-230-55-95.baltnet.ru) (Quit: kirillka) | 12:50 | |
| paulr | wheres dregad | 13:05 |
| *** Joins: dregad (~dregad@203-236.193-178.cust.bluewin.ch) | 13:37 | |
| paulr | lo | 13:37 |
| dregad | heard a cow on my blackberry ;) | 13:37 |
| paulr | what db backends do you have access to ? | 13:37 |
| paulr | blackberry eww | 13:37 |
| paulr | i've got a new android phone | 13:38 |
| dregad | not my choice | 13:38 |
| dregad | company phone | 13:38 |
| dregad | its free ;) | 13:38 |
| dregad | at home I have mysql and postgres | 13:38 |
| paulr | i was more thinking the obscure ones | 13:38 |
| paulr | :P | 13:38 |
| dregad | at work, oracle | 13:39 |
| paulr | i've just dumped db_prepare_bool from db brnach | 13:39 |
| dregad | that will kill postgres support unless you have a smart replacement | 13:40 |
| paulr | nono | 13:41 |
| paulr | for my branch | 13:41 |
| paulr | so oracle, you can test?/code? | 13:43 |
| dregad | in theory yes but atm the setup on my dev box is borked | 13:44 |
| dregad | and I lack of time to fix it | 13:45 |
| *** Quits: EPG (~EPG@pC19EB788.dip.t-dialin.net) (Quit: EPG) | 13:47 | |
| paulr | i see | 13:49 |
| paulr | well, i might upgrade my work setup to mantis 2 soon | 13:49 |
| dregad | did you get a chance to speak with dhx1 | 13:49 |
| dregad | he's been back for a few days now | 13:49 |
| dregad | and i really think the 2 of you should put your work together and pull at the same rope | 13:50 |
| paulr | i'd probably be inclined to dump "1.3" and "next" | 13:53 |
| dregad | according to dhx1, next contains a lot of your initial work on your 2.0 branch and he mentioned cherry-picking the rest | 13:56 |
| paulr | there's around 250 commits since then | 13:57 |
| dregad | what if they're all applied | 13:58 |
| paulr | well, gl with that | 13:58 |
| paulr | also, some (~3-4 at last count) of the commits in 1.3/next should be reverted IMO | 13:59 |
| paulr | do you have any thoughts on exceptions? | 14:10 |
| dregad | like them | 14:12 |
| dregad | much easier and cleaner programming | 14:12 |
| paulr | would you say we should have more or fewer? | 14:12 |
| paulr | er | 14:12 |
| paulr | i.e. should we have like | 14:12 |
| paulr | user not found exception | 14:13 |
| paulr | project not found | 14:13 |
| paulr | or just | 14:13 |
| paulr | 'not found' | 14:13 |
| dregad | short answer is "it depends" | 14:13 |
| dregad | generic = fewer of them = less maintenance | 14:14 |
| dregad | but may make handling them more complex | 14:14 |
| dregad | there's pros & cons for both sides of arguments | 14:15 |
| paulr | i'm thinking instead of using $g_foo for config | 14:52 |
| paulr | $config['foo'] might be more sensible | 14:52 |
| paulr | but can't decide | 14:52 |
| dregad | why change? | 14:55 |
| dregad | (i like arrays but it seems like a huge effort for little benefit) | 14:55 |
| paulr | a) fewer global variables | 14:56 |
| paulr | b) could cache the global config array for performance | 14:56 |
| dhx1 | paulr, dregad: hi :) | 14:56 |
| dregad | hi david | 14:56 |
| paulr | c) for 2.0, would be nice to get rid of global variables | 14:56 |
| paulr | dhx1: your still alive then ;p | 14:57 |
| dregad | i said the same thing last week ;) | 14:57 |
| dhx1 | haha | 14:57 |
| dhx1 | paulr, what part of 'next' needs to go IMO... fine granularity exceptions? | 14:58 |
| dhx1 | IYO | 14:58 |
| paulr | the file system layout | 14:59 |
| dhx1 | agreed that can change | 14:59 |
| dhx1 | I wasn't going to worry about that sort of stuff until closer to an eventual release though | 15:00 |
| paulr | should a global $config array be called $config | 15:00 |
| * paulr ponders | 15:00 | |
| paulr | i'm guessing 'yes' | 15:01 |
| paulr | i.e. you'd use | 15:01 |
| paulr | $config['hostname']= 'localhost'; | 15:01 |
| dhx1 | is an array the right data structure? | 15:01 |
| paulr | instead of $g_config | 15:01 |
| dhx1 | remember that project and user-specific config may override it | 15:02 |
| dhx1 | so a lot of the overhead is in those checks | 15:02 |
| paulr | that gets pulled out of db and stored as an array atm though right? :P | 15:02 |
| paulr | so atm, we have something like | 15:02 |
| paulr | lets say we want "config1" | 15:02 |
| paulr | we call config_get("config1"); | 15:03 |
| paulr | that goes | 15:03 |
| paulr | $user = currentuser(); | 15:03 |
| paulr | $project = currentproj(); | 15:03 |
| paulr | then basically goes | 15:03 |
| paulr | if $cachedconfig[$user][config1]; return; | 15:03 |
| paulr | if $cachedconfig[$project][config1]; return; | 15:03 |
| paulr | ok, we didn't find so: | 15:03 |
| paulr | return get_global | 15:03 |
| paulr | where that does return $GLOBALS['g_' . config1] | 15:04 |
| dhx1 | I see what you mean | 15:04 |
| paulr | so i'd be proposing we do exactly the same but make get_global just do | 15:04 |
| paulr | return; | 15:04 |
| paulr | or more | 15:04 |
| paulr | argh | 15:04 |
| paulr | get global would be cachedoncfig[-1,-1] | 15:04 |
| dregad | I like doncfigs ;) | 15:05 |
| paulr | as a by-product you lose all the global variables | 15:05 |
| dregad | makes sense | 15:05 |
| paulr | and arguably you could serialize the global config to disk/ram if you didn't want to parse it on load | 15:05 |
| paulr | in terms of "is an array the right type" | 15:06 |
| paulr | i'd probably argue that whilst $config->hostname is cleaner to type | 15:06 |
| paulr | does it make sense for db values | 15:07 |
| paulr | having said that | 15:07 |
| paulr | $config->hostname is less likely to have people cause syntax errors | 15:07 |
| paulr | and pulled from db to an array or object is probably about the same | 15:07 |
| dhx1 | syntax/readability is critical IMO | 15:07 |
| paulr | so $config->db_username? | 15:08 |
| paulr | MantisConfig::db_username | 15:08 |
| paulr | $config->username | 15:12 |
| paulr | ^ simple | 15:12 |
| paulr | dregad/dhx: makes more sense? | 15:12 |
| paulr | *most | 15:12 |
| dhx1 | the only problem is that $config can no longer be used as a local variable | 15:12 |
| paulr | $CFG then | 15:13 |
| dregad | I like the idea of using objects for config | 15:17 |
| dregad | re: naming - $MantisConfig ? | 15:17 |
| paulr | just need to check i dont break require_api with this | 15:24 |
| dhx1 | I'd like to stop adding "Mantis" to variable/class names | 15:24 |
| dhx1 | it's a sign that namespacing isn't being used correctly | 15:24 |
| dhx1 | other than that, agreed with dregad | 15:25 |
| dhx1 | require_api will disappear when everything is converted to objects | 15:25 |
| dhx1 | (ie. use autoloading) | 15:25 |
| dhx1 | well... not everything will turn into an object... :) | 15:25 |
| * dregad is not familiar with namespacing | 15:25 | |
| dhx1 | use \MantisBT\Exception\User\UserNotFound | 15:26 |
| dhx1 | etc | 15:26 |
| dhx1 | that way you import a small segment of MantisBT (or other library) code at a time | 15:26 |
| * dregad is reading up on it | 15:26 | |
| dregad | in this context, i agree that Mantis prefix doesn't make sense | 15:28 |
| dregad | i was concerned about collision on a common name like 'config' | 15:29 |
| dregad | namespaces makes that irrelevant | 15:29 |
| paulr | ok, that might be quick and easy to do | 15:34 |
| paulr | $t_new_globals = array_diff_key( get_defined_vars(), $GLOBALS, array( 't_existing_globals' => 0, 't_new_globals' => 0 ) ); | 15:36 |
| paulr | dhx1: i can ignore that right? | 15:36 |
| paulr | as that's for globals defined by class | 15:37 |
| paulr | not config variabls | 15:37 |
| paulr | well, might need some proofreading | 15:44 |
| paulr | but might also be done ;/ | 15:44 |
| paulr | or well, semi-d one | 15:44 |
| paulr | $MantisConfig->hostname = 'localhost'; | 15:44 |
| paulr | $MantisConfig->db_type = 'pdo_mysql'; | 15:44 |
| dregad | gotta go - i'm way past bedtime | 15:45 |
| dregad | ttyl | 15:45 |
| paulr | mm, me too soon | 15:45 |
| *** Quits: dregad (~dregad@203-236.193-178.cust.bluewin.ch) (Quit: A fine is a tax for doing wrong. A tax is a fine for doing well.) | 15:46 | |
| *** Quits: dhx1 (~dhx1@60-241-62-124.tpgi.com.au) (Quit: Leaving) | 15:56 | |
| *** Quits: paulr (~IceChat09@cpc1-enfi15-2-0-cust580.hari.cable.virginmedia.com) (Quit: OUCH!!!) | 16:12 | |
| *** Joins: romer628 (~romer628@cpe-76-180-59-236.buffalo.res.rr.com) | 16:50 | |
| *** Parts: romer628 (~romer628@cpe-76-180-59-236.buffalo.res.rr.com) () | 16:50 | |
| *** Quits: sdfjkljkdfsljkl (~sdfjkljkd@static.96.23.63.178.clients.your-server.de) (Remote host closed the connection) | 17:00 | |
| *** Joins: sdfjkljkdfsljkl (~sdfjkljkd@static.96.23.63.178.clients.your-server.de) | 17:00 | |
| *** Joins: intripoon (~quassel@manz-590f3335.pool.mediaWays.net) | 18:54 | |
| *** Quits: intripoon_ (~quassel@manz-590f0fb4.pool.mediaWays.net) (Ping timeout: 246 seconds) | 18:57 | |
| *** Joins: romer6281 (~romer628@cpe-76-180-59-236.buffalo.res.rr.com) | 22:07 | |
| *** Joins: kirillka (~Miranda@195.242.142.17) | 22:26 | |
| *** Joins: giallu (~giallu@fedora/giallu) | 23:42 | |
Generated by irclog2html.py 2.10.0 by Marius Gedminas - find it at mg.pov.lt!