*** Quits: Vooch2 (~msalvucci@71-88-193-144.dhcp.kgpt.tn.charter.com) (*.net *.split) | 00:09 | |
*** Joins: Vooch2 (~msalvucci@71-88-193-144.dhcp.kgpt.tn.charter.com) | 00:11 | |
*** Quits: kirillka (~Miranda@99-83-52-95.baltnet.ru) (Quit: kirillka) | 00:20 | |
*** Joins: dhx1 (~dhx1@60-241-62-124.tpgi.com.au) | 01:28 | |
*** Joins: dregad (~dregad@203-236.193-178.cust.bluewin.ch) | 02:07 | |
*** Joins: Paul_46 (~IceChat09@cpc1-enfi15-2-0-cust580.hari.cable.virginmedia.com) | 07:51 | |
*** Joins: e66 (~quassel@27.147.181.37) | 09:52 | |
*** Quits: giallu (~giallu@fedora/giallu) (Ping timeout: 246 seconds) | 14:28 | |
*** Quits: dhx1 (~dhx1@60-241-62-124.tpgi.com.au) (Quit: Leaving) | 15:57 | |
*** Quits: sdfjkljkdfsljkl (~sdfjkljkd@static.96.23.63.178.clients.your-server.de) (Remote host closed the connection) | 16:00 | |
*** Joins: sdfjkljkdfsljkl (~sdfjkljkd@static.96.23.63.178.clients.your-server.de) | 16:00 | |
GitHub48 | [mantisbt] dregad pushed 12 new commits to master-1.2.x: http://git.io/bxCRzQ | 16:13 |
---|---|---|
GitHub48 | mantisbt/master-1.2.x a8f5420 Damien Regad: Re-indent complex if statement for better readability | 16:13 |
GitHub48 | mantisbt/master-1.2.x a7f9feb Damien Regad: Restrict $g_allow_reporter_* to users with reporter access... | 16:13 |
GitHub48 | mantisbt/master-1.2.x 9089f5e Damien Regad: Fix whitespace | 16:13 |
Paul_46 | dregad: moo | 16:27 |
dregad | hey | 16:27 |
Paul_46 | do we really need to do whitespace fixes in 1.2 | 16:28 |
Paul_46 | i mean, it's not helping | 16:28 |
Paul_46 | ;) | 16:28 |
dregad | It's a habit | 16:29 |
dregad | and my editor is configured to trim trailing whitespace and to use tabs, which tends to "fix" whitespace semi automatically | 16:30 |
dregad | To make things easier, I try as much as possible, to commit whitespace changes separately from the rest | 16:30 |
dregad | In most cases, whitespace in 1.2 has already been fixed in 1.3/master | 16:31 |
Paul_46 | mm | 16:31 |
Paul_46 | also | 16:32 |
Paul_46 | + - new 'EVENT_UPDATE_BUG_STATUS_FORM' plugin event | 16:32 |
Paul_46 | can we discuss that | 16:33 |
Paul_46 | For example, there's a new 'json' api that isn't used ( | 16:36 |
Paul_46 | > https://github.com/mantisbt/mantisbt/blob/master-1.2.x/core/json_api.php ) | 16:36 |
Paul_46 | > within the core code. | 16:36 |
Paul_46 | Yes, I've introduced to prototype its usage in a plugin [1] to provide | 16:36 |
Paul_46 | in-page validation . If I'm happy with how this turns out from a | 16:36 |
Paul_46 | UI/code point of view I will consider porting it to master-1.2.x . | 16:36 |
Paul_46 | also | 16:36 |
Paul_46 | did you exclude that? | 16:36 |
dregad | re: the new event - it's something that already existed in master | 16:39 |
dregad | there was a request from a user to add it | 16:39 |
dregad | so i just backported | 16:39 |
dregad | regarding the json - not sure what your point is | 16:39 |
Paul_46 | I dont think we should be adding api's in minor releases | 16:40 |
Paul_46 | that imo we might like to scrap | 16:40 |
dregad | talk to the author then | 16:40 |
dregad | and revert the commit | 16:40 |
Paul_46 | [12:36.43] <Paul_46> in-page validation . If I'm happy with how this turns out from a | 16:40 |
Paul_46 | [12:36.43] <Paul_46> UI/code point of view I will consider porting it to master-1.2.x . | 16:40 |
Paul_46 | rombert seemed to suggest he'd not put it in master-1.2 | 16:40 |
dregad | tbh, i did not double-check all commits or re-test the whole thing | 16:41 |
Paul_46 | tbh, your idea of forking mantis sounds more interesting | 16:41 |
dregad | i would tend to agree with you on *really* freezing 1.2 | 16:42 |
dregad | and focusing improvements on a new release | 16:42 |
dregad | along the lines of what vboctor wrote on the ml | 16:42 |
dregad | if by forking you mean starting a separate project, that is not really my idea | 16:43 |
Paul_46 | it's more | 16:43 |
dregad | i just thought you were going to do it with the mantisbt2 thing | 16:44 |
Paul_46 | people are forcing features into 1.2 | 16:44 |
Paul_46 | which makes it harder to move forwards | 16:44 |
dregad | i agree | 16:44 |
Paul_46 | as in some cases | 16:44 |
Paul_46 | we've said before | 16:44 |
dregad | but that's a consequence of nothing happening in master for 2 years | 16:44 |
Paul_46 | we want to rewrite webservices from scratch | 16:44 |
Paul_46 | and db layer from scratch | 16:44 |
Paul_46 | so people "fixing" db layer+webservices | 16:44 |
Paul_46 | whilst cool | 16:44 |
dregad | so the easy solution is to push new version out asap | 16:44 |
Paul_46 | also is making it hardr | 16:45 |
Paul_46 | I might just set up automated builds of 2.0 | 16:45 |
Paul_46 | and start runnign it at work | 16:45 |
Paul_46 | on commit, rebuild 2.0 and if it builds send mail+twitter notification | 16:45 |
Paul_46 | .. | 17:00 |
Paul_46 | mm, irc client gone mad | 17:00 |
Paul_46 | dregad: check out mail I just sent to dev list | 17:14 |
dregad | Paul_46 what should i say | 17:37 |
dregad | you're right obviously | 17:37 |
Paul_46 | well, even then, not sure I am | 17:37 |
Paul_46 | as I think an 'error code' in json rpc requires an ID | 17:37 |
Paul_46 | so we wouldn't be able to use *that* implementation as it is | 17:37 |
Paul_46 | basically my quesiton is | 17:38 |
Paul_46 | or more point is | 17:38 |
Paul_46 | a) i've not done much jquery stuff | 17:38 |
Paul_46 | b) i've been looking at json+jquery stuff recently for something else | 17:38 |
Paul_46 | c) i've not seen the construction of json that we've added when looking at b | 17:38 |
Paul_46 | which makes me wonder if there is some logic, or if we invented something | 17:39 |
Paul_46 | there's two ways I can look at this | 17:39 |
Paul_46 | 1) being i don't really care as we can scrap api in '2.x' or review it at least - and count 2.x as a 'fresh start' | 17:40 |
Paul_46 | 2) we should try and make migration path from 1.2 to a '2.x' somewhat feasible | 17:40 |
*** Quits: dregad (~dregad@203-236.193-178.cust.bluewin.ch) (Quit: For Sale: Parachute. Only used once, never opened, small stain.) | 17:54 | |
GitHub74 | [mantisbt] dregad pushed 1 new commit to master-1.2.x: http://git.io/M3hwAw | 18:04 |
GitHub74 | mantisbt/master-1.2.x 23b9476 Damien Regad: Changed version to 1.2.13dev | 18:04 |
*** Quits: Paul_46 (~IceChat09@cpc1-enfi15-2-0-cust580.hari.cable.virginmedia.com) (Quit: Do fish get thirsty?) | 18:13 |
Generated by irclog2html.py 2.10.0 by Marius Gedminas - find it at mg.pov.lt!