Saturday, 2013-04-06

*** Joins: paulr__ (~IceChat09@cpc5-enfi19-2-0-cust776.20-2.cable.virginmedia.com)03:26
paulr__jreese: moo?03:44
GitHub160[mantisbt] grangeway pushed 3 new commits to master-2.0.x: http://git.io/zXHMlw04:30
GitHub160mantisbt/master-2.0.x 86448ed Paul Richards: reformatting04:30
GitHub160mantisbt/master-2.0.x 48d7b23 Paul Richards: Fix logic in category_get_id_by_name and use exceptions instead of $trigger_errors04:30
GitHub160mantisbt/master-2.0.x fbb5e95 Paul Richards: Port of 7beac566f25dc30ffb3224c2823fee77c9223a1b [dregad]:...04:30
paulr__jreese: it's not linking changesets04:33
GitHub41[mantisbt] grangeway pushed 1 new commit to master-2.0.x: http://git.io/MaueJA04:44
GitHub41mantisbt/master-2.0.x ca388c2 Paul Richards: use exceptions instead of $trigger_errors04:44
GitHub163[mantisbt] grangeway pushed 1 new commit to master-2.0.x: http://git.io/LkoKxQ04:44
GitHub163mantisbt/master-2.0.x 2f87420 Paul Richards: use exceptions instead of $trigger_errors04:44
GitHub148[mantisbt] grangeway pushed 1 new commit to master-2.0.x: http://git.io/FVYYdQ04:45
GitHub148mantisbt/master-2.0.x b5ec3fe Paul Richards: use exceptions instead of $trigger_errors04:45
*** Joins: dregad_ (~dregad@127-233.193-178.cust.bluewin.ch)05:02
dregad_jreese - hi05:15
dregad_seems that the source integration is not picking up the events from github05:15
dregad_did you get my mail from yesterday ?05:15
dregad_would appreciate if you could have a look, and maybe give me some pointers on how to go about fixing that05:16
dregad_i just imported recent changes05:31
dregad_that created a few changesets05:31
dregad_but still no idea why we're not getting stuff from github05:31
dregad_and how to debug that05:31
*** Joins: dhx1 (~david@60-241-62-124.tpgi.com.au)05:35
dregad_paulr__ also mentioned that his commits to master-2.0.x branch are not appearing on the tracker either05:59
dregad_e.g. fbb5e95e2b8c7b5360471c633029c0f59d06748305:59
dregad_but they used to06:00
dregad_see http://www.mantisbt.org/bugs/plugin.php?page=Source%2Fsearch&repo_id[]=7&branch[]=master-2.0.x06:00
dregad_all issues in the tracker are now resolved or closed again06:45
dregad_i created a tag "2.0.x check" on the ones paulr__ had set to "acknowledged"06:46
dregad_the e-mail notifications are enabled again06:46
dregad_as a side note, if like me you were wondering why your newsreader is not showing recent messages to mantisbt-dev list06:47
dregad_that is probably the reason ==> http://sourceforge.net/blog/mailing-list-archives-in-read-only-mode/06:48
paulr__hmm06:49
paulr__hmm06:51
paulr__config optiosn06:51
paulr__dregad: hows your jquery?07:01
dregad_virtually non-existent07:01
paulr__;/07:02
paulr__http://stackoverflow.com/questions/14354040/jquery-1-9-live-is-not-a-function07:02
paulr__i'm trying to work out if in our 2nd case we should use null07:02
paulr__and what to do in the first case07:02
dregad_i'm definitely not the right person to ask ;)07:03
* paulr__ kicks dhx107:08
dregad_beating a dead horse ? ;)07:13
paulr__I asdked someone else for migration line for jquery07:14
paulr__he's written 10 lines of text in a response07:14
paulr__obviously know's his stuff but lost me :)07:14
dregad_did you read the doc ? http://api.jquery.com/live/ about halfway down it gives equivalents for .live07:28
paulr__so i'm just gonna sulk now about my branch not appearing07:34
paulr__:)07:34
paulr__and finish off configuration editor07:34
paulr__which I can't decide whether it should be a plugin or not07:34
dregad_should be core imo07:36
paulr__plugin provides nice way for admin to disable though07:36
paulr__hence not being able to decide :)07:37
dregad_then make a config to enable the config of configs :P07:37
dregad_anyway signing off for now07:38
dregad_be back later, maybe07:38
paulr__hmm07:38
paulr__;/07:38
dregad_i'll check your mails probably tomorrow, or monday back at work07:38
GitHub149[mantisbt] grangeway pushed 2 new commits to master-2.0.x: http://git.io/vJmjVw07:38
GitHub149mantisbt/master-2.0.x ae6730a Paul Richards: use exceptions instead of $trigger_errors07:38
GitHub149mantisbt/master-2.0.x 332da7f Paul Richards: Fix javascript for newest jquery07:38
paulr__dregad: reminderS!?!?!?!07:38
dregad_i know, i know07:38
dregad_kids are screaming now, gotta go07:38
paulr__cya :)07:39
*** Quits: dregad_ (~dregad@127-233.193-178.cust.bluewin.ch) (Quit: If you can't laugh at yourself, make fun of other people.)07:39
*** Joins: Hans_Henrik (~Hans_Henr@90.149.250.68)09:09
*** Quits: Hans_Henrik (~Hans_Henr@90.149.250.68) (Quit: Leaving)09:56
GitHub91[mantisbt] grangeway pushed 1 new commit to master-2.0.x: http://git.io/u9aXpw11:01
GitHub91mantisbt/master-2.0.x 40079b6 Paul Richards: lang_get removal within relationship api11:01
GitHub109[mantisbt] grangeway pushed 1 new commit to master-2.0.x: http://git.io/qCKRYg11:22
GitHub109mantisbt/master-2.0.x 15f6a48 Paul Richards: optimise relationship_get_details11:22
*** Joins: TerrorBite (~lion@quassel.lethargiclion.net)13:43
TerrorBiteI just submitted a patch :D13:43
TerrorBitehttp://www.mantisbt.org/bugs/view.php?id=814113:44
GitHub165[mantisbt] grangeway pushed 2 new commits to master-2.0.x: http://git.io/U14zTg13:51
GitHub165mantisbt/master-2.0.x 3911f09 Paul Richards: Multibyte aware str_pad function13:51
GitHub165mantisbt/master-2.0.x 763a22c Paul Richards: use get_enum_element where appropriate13:51
TerrorBiteI suppose I should fork and make a pull request if I wanted to do it properly though13:55
paulr__i'm wondering if having an 'own' status in workflow would be better13:56
paulr__could then get rid of 'allow reporter to reopen', 'allow reporter to close', 'allow reporter to update' with a set what you can do to your own issues13:57
TerrorBiteYeah, that'd make sense. I basically used "allow reporter to reopen/close" as precedent13:58
paulr__(i'm trying to gradually rewrite mantis in large chunks, as an experiment13:59
paulr__one of the things i'm gradually not liking is the 1000000000 config options we have13:59
paulr__which in some cases are not used consistently13:59
TerrorBiteI did notice there were a lot of config options14:02
TerrorBiteCan you explain to me about the workflow? I can see that "Allow Reporter to close Issue" and co are present on the Workflow Thresholds page, but don't seem to fit in properly14:03
TerrorBiteI'm assuming they were just sort of shoehorned in there14:04
paulr__no idea14:04
paulr__but in terms of work flow14:04
paulr__in theory you can get quite fancy with who can see what14:04
paulr__and what status leads to what14:04
TerrorBiteyeah I played around a bit with the status stuff, restricting so that e.g. you can only go to feedback from resolved14:05
paulr__at the moment, we debating what next version of mantis is14:06
TerrorBiteIn what way?14:06
paulr__radical rewrites vs not ;)14:07
TerrorBiteaha14:07
TerrorBiteyou know I'm not sure why reporters can't close their own issues by default. At the start I was confused what the difference between resolved and closed was14:08
TerrorBiteBut I got the workflow sorted out after that14:08
paulr__well, I guess the other question is whether you need a 'closed' stuats14:09
TerrorBiteso that resolved is basically saying "We think we fixed it, how'd we do?" waiting for the reporter to either reopen, or close it14:09
TerrorBiteidea being, only the reporter ought to close an issue (unless it's invalid/spam/etc)14:10
TerrorBiteOr if it sits at resolved longer than a month, close it assuming the reporter was satisfied14:11
TerrorBiteOf course that's just my use-case and I understand that the power of mantis is being flexible to anyone's needs14:11
TerrorBiteBut it's a pretty mainstream use-case I'd think14:12
TerrorBiteIt did lead me to thinking that you ought to be able to leave notes on resolved issues but not closed ones. Then I realised that you can leave a note when changing the status, which is enough, and if further discussion is needed then it ought to be reopened anyway14:14
GitHub189[mantisbt] grangeway pushed 1 new commit to master-2.0.x: http://git.io/R0REdg14:15
GitHub189mantisbt/master-2.0.x bdd4325 Paul Richards: Fix up config_workflow_page to work without using lang_get14:15
paulr__My personal focus is that 1.2.x/1.3.x are "dead", and looking at a 2.x concept14:16
paulr__and experimenting14:16
TerrorBiteExperimenting is good14:16
paulr__[I use mantis with mssql at work, and adodb isn't as useful as one hoped for different db support]14:16
TerrorBiteI'm using mantis as an internal tracker for the admin team of a large Minecraft server14:17
paulr__what server?14:17
TerrorBitemcau.org14:17
paulr__i'm guessing no redpower etc?14:19
dregadJust a note re: allowing reporters to update their own14:20
paulr__if it's a config option i'm gonna stab you14:20
paulr__;p14:20
dregadYou might want to restrictwhich fields are editable14:20
* dregad ducks14:20
paulr__slowly fixing up 2.x :)14:21
TerrorBitehaha14:21
paulr__dregad: do you still hate me? ;p14:21
TerrorBitedregad: That would be a good idea, yes14:21
TerrorBitepaulr__: It's Bukkit, so nothing that requires client mods14:21
TerrorBiteRedPower is <3 though14:22
* paulr__ runs his own mc server for a few friends14:22
paulr__without mods, people spent hours making stuff14:22
paulr__with mods, people seem to spend hours making power to get uu matter to get resources for free14:22
paulr__instead of making pretty buildings14:22
paulr__dregad: https://github.com/mantisbt/mantisbt/blob/next/application/core/helper_api.php#L118 --> /me isn't sure about that14:23
TerrorBiteUgh yeah, EE2 is not very balanced in my opinion14:23
paulr__we turned EE off14:23
TerrorBitewait14:23
paulr__(for that reason)14:23
TerrorBiteYeah I'm getting confused.14:23
TerrorBiteSo turn off mass fabs too?14:23
TerrorBiteI always took joy in building complex sorting machines and other labor-saving devices14:24
paulr__we turned off mass fabs and left matter fab on from gregtech14:24
TerrorBiteI like gregtech actually14:24
paulr__so you get uu matter at slower rate14:24
paulr__but we've got 2 people with fusion reactors, and a 3rd going up14:24
paulr__so infinite power14:24
paulr__and infnite power in slower matter fab = infinite uu14:25
paulr__advanced pump in nether = infinite copper/tin14:25
paulr__etc14:25
dregadDont want to rain on your parade but you might want to take the minecraft stuff offline ;)14:25
paulr__hehe14:26
TerrorBiteI haven't played much gregtech, was experimenting on a friend's Mindcrack server, but got distracted by Ingress14:27
dregadpaulr__ what about get_enum_element?14:29
paulr__well, the strings14:29
paulr__should really live somewhere else14:29
paulr__or well ;/14:29
dregadI never like the way we are doing enus to begin with14:30
paulr__:)14:30
TerrorBitemaybe if you used a real language!14:30
* TerrorBite ducks14:30
paulr__want a sledgehammer?14:30
TerrorBitehaha14:30
dregadAnd their localization... that is just a disaster14:30
paulr__want a sledgehammer?14:30
paulr__$t_command_caption = sprintf( _( 'Update %1$s' ), lang_get_defaulted( $t_custom_field_def['name'] ) );14:31
dregadTerrorBite: lol14:31
paulr__i've been staring at that for about 30 minutes now14:31
paulr__so If I make a custom field called 'signup'14:31
paulr__or something14:31
paulr__i'll probably get "thanks for signingup " in the UI14:31
paulr__i'm not sure about that ;p14:32
TerrorBiteTry it and see?14:32
paulr__dregad: any thoughts?14:33
paulr__TerrorBite: there's no segmentation on the strings in the core14:33
paulr__TerrorBite: so if you used the right custom field name, could get funky results14:33
TerrorBiteFun14:35
paulr__dregad: reminders? ;p14:37
* dregad pretends he did not hear14:39
dregadRe: the sprintf trick, looks good on paper but as you said will be issues if cf name matches existing string14:42
dregadMaybe with a prefix?14:43
paulr__[10:30.53] <paulr__> want a sledgehammer?14:43
paulr__[10:31.07] <paulr__> $t_command_caption = sprintf( _( 'Update %1$s' ), lang_get_defaulted( $t_custom_field_def['name'] )14:43
paulr__dregad: I was more thining the  pgagfdaskf14:43
paulr__thinking the lang_get_Default bit on it's own14:44
paulr__anyway14:44
paulr__remidners!14:44
dregadWhat's a 'pgagfdaskf' ?14:45
* dregad is confused14:45
paulr__$t_custom_field_def['name'] )14:45
paulr__[10:43.59] <paulr__> dregad: I was more thining the14:45
paulr__[10:43.59] <paulr__> dregad: I was more thining the  pgagfdaskf14:45
paulr__[10:44.06] <paulr__> thinking the lang_get_Default bit on it's own14:45
paulr__that's a irc client14:45
paulr__not want to copy/paste14:45
paulr__correctly14:45
paulr__so anyway14:46
dregadIcechat sucks for copypaste14:46
paulr__i'm not sure history events on reminders are such a good idea14:46
dregadWhynot14:46
paulr__read what I wrote in mail14:46
paulr__i'm thinking of fixing properly by adjusting the db fields/structure14:47
paulr__we dont add a history event when we send a mail to someone on a new note, so why should we for a reminder14:47
paulr__it strikes me that the adding history event is because you can fill up 255 bytes in a db column that stores it if you send a lot of reminders14:48
dregadI told you my inbox is swamped in 500+ messages and I'm not gonna clean it up on the blackberry14:48
paulr__which means that to hit that case, given say <9999 users on the system, you'd need to have 51 people on the reminder14:48
paulr__and to add 51 rows to the history summary so you can see them all [as we truncate at ~51 if we have 4chars followed by a comma in the 255 byte field]14:49
dregadYes thats right14:49
paulr__seems like we'd then need a fix to fix the history summary to not sure 51 rows :)14:49
dregadIn fact i fixed a bug on that not too long ago14:50
paulr__which makes me think that either14:50
paulr__a) we need to look at limiting the number of people you can "remind"14:50
paulr__or if we dont like arbitary limits14:50
paulr__b) looking at the data field and seeing if it makes sense to change what is probably a varchar(255) to a larger varchar to avoid the need of A14:50
paulr__and if we feel that we need to log in the history table who got a reminder14:51
paulr__we should probably also log who got emailed on a bugnote being added or who got emailed for monitoring an issue - as monitors/managers/developers etc over time can change14:51
paulr__if we go for option A or B, we probably dont want to add history entries14:52
paulr__if we go for option C [aka log who gets mails], we should probably add it to a seperate 'communication log' table so as not to spam the history table for performance later on14:53
paulr__[and to allow the communication log to be purged by people in the future after 4 months for example]14:53
dregadI like B15:00
dregadBtw adding to history is http://www.mantisbt.org/bugs/view.php?id=297115:01
dregadSee also http://www.mantisbt.org/bugs/view.php?id=1547015:02
paulr__yea, I dont like that set of fixes15:02
paulr__I think both should be considered more fully15:03
paulr__so adding in a .15 release seems silly15:03
paulr__TBH - i more wonder about $g_store_reminders15:06
dregadIncreasing field size is probably best - limiting to 255 doesnt make much sense with todays varchar fields15:06
paulr__i'd probably be inclined to remove that15:06
paulr__and always store15:06
paulr__and add a 'send mail to' user option15:06
dregadAgreed15:06
paulr__so if you really really really did want to mail someone15:06
paulr__you could click on their name and get a form to fill in15:06
paulr__I can't really think of a usecase where, you'd not want to store a reminder15:07
paulr__[and not be able to email or something outside]15:07
dregadThink so too15:08
paulr__let alone a use case where you'd not want to store a reminder15:08
paulr__but you'd want to log the fact you'd sent a reminder15:08
dregadRight15:08
paulr__I want to send you this line of text, but I dont want anyone to see it!15:08
paulr__including myself or you15:08
paulr__:)15:08
dregadLol15:09
paulr__There is also the scenario where reminders are set to not add the reminded person to the monitored list, i.e. the case where the following config is OFF.15:09
paulr__ $g_reminder_recipents_monitor_bug = OFF;15:09
paulr__ I think the reminder should add a history entry per reminded person. This is independent of adding the target person to the monitor list.15:09
paulr__^ quoting victor15:09
paulr__ok, so you can remind people but not add them to monitor list15:10
paulr__that maybe makes more sense15:10
paulr__but even then, I don't know about you but that just says to me, there should be some 'control' on who you can 'remind'15:10
paulr__in any case, I think we should probably revert the history api change + constant15:11
paulr__and have a think about what we really want to do15:11
paulr__and are trying to do15:11
paulr__so pull or do you disagree?15:13
paulr__i'm probably inclined to not pull the change into the 2.x branch, and to add a note to upgrade scripts for people to run a manual query to remove the reminder log events when upgrading, and having a proper look at what functionality is available15:17
dregadI have to think about it15:18
paulr__as I don't really see the point of not storing the reminders15:18
dregadI think in any case its quite unlikely to send a reminder to somany ppl15:18
dregadCan't think of a business case for that15:19
paulr__if it's a 'reminder', it should really only go to anyone on the issue already15:20
paulr__"hey, have you forgotton about the patch you was testing?" ==> reminder15:20
dregadI would say in 2.x dont port the fix15:20
paulr__if it's functionality to add someone / poke someone about an issue, it's not really a reminder15:20
dregadIncrease db field size15:20
paulr__yea, but if you dont 'port the fix', we dont want the history events15:20
dregadAnd always log reminder in bugnote15:21
dregadNo history15:21
dregadHow does thatsound15:21
paulr__still need to look properly / think15:21
paulr__(the reason it's varchar(255) is because some db's limited varchars to 25515:21
paulr__for the mysql/pgsql/mssql that's legacy15:22
paulr__for oracle/db2... not sure if that's still valid15:22
paulr__I've never really got the 'send reminder' thing15:22
paulr__to me, to be 'reminded' about something, you must already be linked to it15:22
paulr__which i'd say would mean the reminder list of people should only include people that are already involved in the issue15:23
paulr__but then, whats the point of a reminder :)15:23
paulr__maybe what we really need is two things15:24
paulr__a) send reminder - which *only* sends a mail, can only be used on people involved with issue and *never* logs15:24
dregadi dont know db2 but i have varchar 2000 in oracle db15:24
paulr__b) add note [i.e. the if you have something useful to say]15:24
paulr__c) invite someone to join an issue [ which contacts people not involved in the issue at the moment]15:25
dregadIn fact doc says max size is 4000 http://docs.oracle.com/cd/B28359_01/server.111/b28320/limits001.htm15:25
paulr__and if you did those 3 things above15:25
paulr__would you then want to log who you invited/reminded in the history or not15:25
paulr__:)15:25
dregadReminder forces sending an email15:26
dregad'Normal" involvement and resulting email notices can be ignored by user preferences (as you noticed today)15:27
paulr__on that note, i'm not sure if it should force sending an mail15:29
paulr__under the spam rules etc now a days, should probably allow someone to opt out from receiving mail15:30
dregadIf not, what's the point of the reminder15:30
paulr__well, if you could view reminders in the system..15:30
paulr__i.e. internal flag up15:31
paulr__could be nice15:31
dregadDoes not replace a direct notification15:31
* paulr__ nods15:32
paulr__but then that comes back to my, to be reminded about an issue, you should already have to have been involved in it15:32
paulr__atm, I can use the reminder thing to forcibly send an email to you about any issue15:33
paulr__so it's better to use 'reminder' then to assign it to you15:33
dregadOr youre grangeway and want dhx's opinion on a bug youre working on15:33
paulr__as if I assign it to you, you might not see it until you log in depending on your settings15:33
paulr__whereas if I remind you, you definitely get an email15:34
dregadRight15:34
paulr__re the 'dhx opinion' - thats where I said maybe we need some 'invite someone to issue' functionality15:34
paulr__i.e. you can invite 1 person at a time15:34
paulr__"hey, can you look give your input into X"15:34
dregadThats how i use the feature myself15:35
dregadDont think i ever added more than 1 pers to a reminder15:35
paulr__(i'm liking the idea atm of making "reminder"'s only going to people already involved / linked to the issue in some way, and adding an invite thing that allows you to message 1 person at a time15:35
dregadThats an idea15:36
dregadI like it actually15:36
paulr__i'm thinking it might be nice to have a messaging table to then store the invites15:36
paulr__so you can see who you sent/received messages from/to15:37
paulr__[that oculd be a table that truncates after 30 days and shows mails or whatever]15:37
paulr__in any case, as we talking around this more and more, i'm thinking that whats in the master-1.2.x branch should probably get pulled out15:38
paulr__as this discussion seems to be a lot more sensible path :P15:38
dregadYep15:38
dregadRe: the 30 day cleanup thing, not feasible without cron or something similar15:39
paulr__whilst you revert the 3-4 commits on reminders15:39
paulr__could you add a array_unique on the $f_to variable :P15:39
paulr__as I suspect you could probably use that form to send you 50 mails from one http post request15:39
dregadOnly if you forge the request15:40
dregadThe gui offers a selection list15:40
paulr__hmm15:41
paulr__I wonder if the ability to use mantis to generate spam mails like that15:41
paulr__should get a CVE thing!15:41
paulr__everyone else gets CVE, I want one too15:41
dregadlol15:42
* paulr__ asks person that works for norway CERT15:42
dregadJust send mail to oss security15:42
paulr__or just get on with life :P15:43
dregadThat too15:43
paulr__did you know you can DDOS a webserver?15:43
paulr__if you send a HTTP GET / request15:43
paulr__you can send 10 bytes of data15:43
paulr__and get 20kb back15:43
dregadSpeaking of which i hould probably go to bed now15:43
paulr__:)15:43
dregadRight15:44
paulr__i might look at adding invite code15:44
paulr__you can then port it to 2.x15:44
paulr__erm15:44
paulr__you know what i mean!15:44
dregadBut ddos is slightly more involved than a single user clicking some buttons in search.php and killing mantis15:44
* paulr__ nosd15:45
paulr__I just think it's a hard one :)15:45
paulr__personally, I prefer to fix stuff15:45
paulr__then to spend time working out if a web request that generates 50 db inserts and 50 mails could warrant a security vuln15:46
dregadYouhave nothing better to do with your life anyway ;)15:46
paulr__nod15:46
*** Quits: dregad (~dregad@127-233.193-178.cust.bluewin.ch) (Ping timeout: 260 seconds)16:00
*** Joins: dregad (~dregad@127-233.193-178.cust.bluewin.ch)16:08
*** Quits: paulr__ (~IceChat09@cpc5-enfi19-2-0-cust776.20-2.cable.virginmedia.com) (Quit: Now if you will excuse me, I have a giant ball of oil to throw out my window)16:38
GitHub117[mantisbt] grangeway pushed 2 new commits to master-2.0.x: http://git.io/EiAcXQ17:24
GitHub117mantisbt/master-2.0.x 116d9f3 Paul Richards: remove use of lang_get17:24
GitHub117mantisbt/master-2.0.x fea788d Paul Richards: implement UserNotFound Exception17:24
*** Quits: giallu (~giallu@fedora/giallu) (Ping timeout: 245 seconds)17:30
*** Quits: dregad (~dregad@127-233.193-178.cust.bluewin.ch) (Ping timeout: 246 seconds)18:21
*** Joins: dregad (~dregad@127-233.193-178.cust.bluewin.ch)23:09

Generated by irclog2html.py 2.10.0 by Marius Gedminas - find it at mg.pov.lt!