| *** Quits: micahg (~micahg@ubuntu/member/micahg) (Ping timeout: 255 seconds) | 01:24 | |
| *** Quits: giallu (~giallu@fedora/giallu) (Ping timeout: 252 seconds) | 04:09 | |
| *** Joins: giallu (~giallu@fedora/giallu) | 06:48 | |
| *** Quits: kirillka (~Miranda@195.242.142.17) (Quit: kirillka) | 06:59 | |
| GitHub66 | [mantisbt] dregad pushed 2 new commits to master-1.2.x: http://git.io/hwQnnQ | 08:50 |
|---|---|---|
| GitHub66 | mantisbt/master-1.2.x 2cbd52d Damien Regad: Revert "Fix #2971: add reminder events to the bug history"... | 08:50 |
| GitHub66 | mantisbt/master-1.2.x 5683625 Damien Regad: Create reminder bugnote even if no message text provided... | 08:50 |
| GitHub106 | [mantisbt] dregad pushed 2 new commits to master: http://git.io/1-HiDw | 08:50 |
| GitHub106 | mantisbt/master 0ff9acd Damien Regad: Revert "Fix #2971: add reminder events to the bug history"... | 08:50 |
| GitHub106 | mantisbt/master 49406e5 Damien Regad: Create reminder bugnote even if no message text provided... | 08:50 |
| *** Joins: paulr__ (~IceChat09@cpc5-enfi19-2-0-cust776.20-2.cable.virginmedia.com) | 08:55 | |
| *** Joins: jasonr (454c00b2@gateway/web/freenode/ip.69.76.0.178) | 10:21 | |
| jasonr | Is is possible to search for multiple bug ids at once from the View Issues screen? | 10:22 |
| *** Quits: jasonr (454c00b2@gateway/web/freenode/ip.69.76.0.178) (Ping timeout: 245 seconds) | 10:31 | |
| *** Joins: micahg (~micahg@ubuntu/member/micahg) | 14:27 | |
| *** Quits: giallu (~giallu@fedora/giallu) (Ping timeout: 252 seconds) | 15:38 | |
| *** Joins: dregad (~dregad@127-233.193-178.cust.bluewin.ch) | 15:46 | |
| dregad | paulr__: moo | 15:48 |
| paulr__ | dregad! | 15:48 |
| paulr__ | atrol made me checkout 1.2.14 ;/ | 15:48 |
| dregad | Woot! | 15:48 |
| paulr__ | did you just see my reply to his reply? | 15:49 |
| dregad | Not yet just came home after dinner at friend's place | 15:49 |
| paulr__ | cool | 15:49 |
| paulr__ | you dont hate me yet then :P | 15:49 |
| paulr__ | http://sourceforge.net/mailarchive/forum.php?thread_name=CAA2mj%3DdTdS3nE1JNCVNckNfUjPv%3DDssHFTGAbmacPatmM7ouRQ%40mail.gmail.com&forum_name=mantisbt-dev | 15:50 |
| dregad | Ooooo | 15:50 |
| * dregad fires up newsreader | 15:51 | |
| paulr__ | short version: atrol said he started thinking about context, then thought "that'll just delay a 2.x" | 15:51 |
| paulr__ | my response was to start reviewing our use of config_get to find examples of why I dislike the current approach :) | 15:52 |
| dregad | No reason for hate | 15:56 |
| paulr__ | with the push/pop concept, you could even make add a pop to the end of html_end() | 15:57 |
| paulr__ | and look for non-empty arrays | 15:57 |
| paulr__ | i.e. insist that anything gets pop'd | 15:58 |
| paulr__ | and throw an exception in developer mode if something does't | 15:58 |
| dregad | What happens if context not set? Current user/project? | 15:58 |
| paulr__ | you'd make auth etc set a context | 15:59 |
| paulr__ | so it was always set to something | 15:59 |
| paulr__ | even if it was set to 'any_project' | 15:59 |
| paulr__ | you could basically make bug_is_read_only something like try { context_set(bug->project); if access_check_threshold( 'read only' ) (true ) else (false) catch () finally ( context_pop(); ) return true|false | 16:02 |
| paulr__ | and if the context set arrays are greater then 0 or 1 (Depending how you look at it) at end of a page request or whatever, you could consider that a code error | 16:03 |
| paulr__ | so it would probably be quite easy to make sure that we remembered to cmoe out of the context at appropriate points | 16:04 |
| dregad | Makes sense i guess | 16:05 |
| dregad | But what about atrol's point that concept of context applies to other things than user/project? | 16:06 |
| paulr__ | yes | 16:07 |
| paulr__ | whilst I didn't write it, lang_push / lang_pop would be something obvious to mvoe to that model | 16:07 |
| paulr__ | (albeit, with the locale stuff that dhx did it's slightly different probably, but) | 16:07 |
| paulr__ | apart from user, lang and project I can't think of anything that we do that would be candidates | 16:08 |
| paulr__ | maybe timezone | 16:08 |
| paulr__ | and thinking about it | 16:09 |
| paulr__ | language/timezone are not needed | 16:09 |
| paulr__ | at least, you'd probably want to look up language/timezone from a user | 16:09 |
| paulr__ | however, in any case, user,lang,project,timezone would be the things that I think might vary | 16:09 |
| dregad | Not familiar with new locale stuff but lang is derived from user, and sometimes needs to fall back to default | 16:11 |
| dregad | Timezone is strictly user-dependent | 16:11 |
| paulr__ | the only time you need to change timezone/language is for displaying information to users | 16:12 |
| paulr__ | anyway, am i right that my two exampples are bugs that need fixing? | 16:12 |
| dregad | Dunnoneed tocheck in detail | 16:22 |
| dregad | Right now i'd rather focus on 1.2.15 | 16:22 |
| paulr__ | they 1.2.15 bugs :P | 16:25 |
| paulr__ | with access checks not working right :p | 16:26 |
| paulr__ | could allow a user in one project to edit stuff in a different project ;p | 16:26 |
| paulr__ | maybe ;p | 16:26 |
| paulr__ | right no though, I need sleep as it' 00:30 | 16:26 |
| paulr__ | so nn | 16:26 |
| dregad | Wait | 16:27 |
| paulr__ | :( | 16:27 |
| dregad | Hey its 1.24 for me :P | 16:27 |
| paulr__ | your clock is wrong | 16:27 |
| dregad | No its not i'm CEST | 16:28 |
| paulr__ | p.s. expect next commit from me to probably be the context idea ;p | 16:28 |
| paulr__ | yea, but it's 1.28 in cest i think | 16:28 |
| dregad | About the reminders | 16:28 |
| paulr__ | not 1.24 | 16:28 |
| dregad | Gimme a break | 16:28 |
| paulr__ | :) | 16:28 |
| paulr__ | you did walk into that though ;p | 16:29 |
| paulr__ | anyway, reminders | 16:29 |
| dregad | Re: |a|b|c| | 16:29 |
| dregad | I know its a hack | 16:29 |
| dregad | But do you see any other way? | 16:29 |
| paulr__ | well, I can't actually see someone sending a reminder to 50 people :P | 16:30 |
| * dregad thinks he should actually change 50 to 10 | 16:30 | |
| paulr__ | so personally, i'd probably rather a limit of say 30 people [and see if anyone complains] | 16:31 |
| paulr__ | then the hack on the length | 16:31 |
| paulr__ | (if people are really sending reminders to 50 people | 16:31 |
| paulr__ | what that says to me is we really really really really need a 'group concept' | 16:31 |
| paulr__ | which we dont have, have never decided best way to implement etc | 16:32 |
| dregad | Following throuhg on vctor's idea, that number should be a config option | 16:32 |
| dregad | Which makes sense | 16:32 |
| dregad | But if we leave it open we do need the safety check of the hack | 16:33 |
| paulr__ | I can think of like 4 times you'd use a mail/reminder thing: | 16:33 |
| paulr__ | a) to poke an individual | 16:33 |
| paulr__ | b) to poke the 'developer' team of a project [aka group support] | 16:33 |
| paulr__ | c) to poke anyone linked to a bug | 16:33 |
| paulr__ | in case of c, you'd probably just add a bug note | 16:34 |
| paulr__ | you'd use b to say, poke all of us on a security issue | 16:34 |
| paulr__ | and a, would be the 'can you look at this' | 16:34 |
| dregad | Group support - now THAT's a killer user benefit for next release | 16:35 |
| paulr__ | so in a way, only reason you need a config/option/hack is because you don't have groups ;p | 16:35 |
| dregad | What about d) ? You mention 4 cases | 16:35 |
| paulr__ | which makes me think there's probably little point adding a config option, and just adding a hard limit of 51-X to avoid the truncation issue | 16:36 |
| paulr__ | and tbh, I dont think I got to 4 :P | 16:36 |
| dregad | But X depends on length of user ids... | 16:37 |
| paulr__ | [side note: group support should be easy to add, as i'd probably say what you'd want to do is add make config_get more complicated by adding 'group' as an option and you'd be a good step there] | 16:37 |
| paulr__ | if user id's are linked to autonumber field and padding is irrelevant, 5-6 is gonna be max number of digits | 16:38 |
| paulr__ | so 6+| = 7 | 16:38 |
| paulr__ | 255/7 = 36 | 16:38 |
| paulr__ | ==> 30 people on a reminder :) | 16:38 |
| paulr__ | which is quite similar to number I randomnly pulled out air earlier | 16:39 |
| dregad | 30 is still too high imo | 16:39 |
| paulr__ | I need to go to bed | 16:40 |
| paulr__ | but yea, pick a number | 16:40 |
| dregad | But anyway capping max recipients is the only alternative | 16:40 |
| paulr__ | all i'm thinking is it seems silly to rely on effectively an extra comma to identify a truncation | 16:40 |
| paulr__ | would almost be better just doing |T|1|2|3| | 16:41 |
| paulr__ | if 'T' appears in string, truncated | 16:41 |
| paulr__ | or something | 16:41 |
| paulr__ | but i'm still thinking it's getting random and messy for something that i'd really like to know if anyone has hit | 16:41 |
| paulr__ | (if you use 'reminders' to make up for the fact we miss a 'send email to all users' feature, that's a case of needing to add that feature not fix reminders | 16:42 |
| paulr__ | and if you assume that the point of sending a reminder is to ask someone to update an issue | 16:43 |
| paulr__ | asking 30 people to update an issue is gonna generate lots of bug notes | 16:43 |
| paulr__ | anyway, i'm running :) | 16:43 |
| paulr__ | nn | 16:43 |
| dregad | Ciao | 16:43 |
| *** Quits: paulr__ (~IceChat09@cpc5-enfi19-2-0-cust776.20-2.cable.virginmedia.com) (Quit: Depression is merely anger without enthusiasm) | 16:43 | |
| GitHub39 | [mantisbt] dregad pushed 1 new commit to master: http://git.io/bb7U5A | 17:11 |
| GitHub39 | mantisbt/master d95eeae Damien Regad: Revised reminder_list_truncated string... | 17:11 |
| GitHub35 | [mantisbt] dregad pushed 1 new commit to master-1.2.x: http://git.io/l3rHaw | 17:11 |
| GitHub35 | mantisbt/master-1.2.x bb6b113 Damien Regad: Revised reminder_list_truncated string... | 17:11 |
| *** Quits: dregad (~dregad@127-233.193-178.cust.bluewin.ch) (Quit: Bye) | 17:24 | |
Generated by irclog2html.py 2.10.0 by Marius Gedminas - find it at mg.pov.lt!