| dhx1 | breaking in 3...2...1... | 00:58 |
|---|---|---|
| CIA-27 | Mantisbt: hickseydr * r49aac093ce6a / (54 files in 5 dirs): Issue #12545: Replace deprecated <b> tags with <strong> | 00:58 |
| CIA-27 | Mantisbt: hickseydr * r6f0f5930d3f0 /account_sponsor_page.php: Issue #12545: Remove deprecated <u> tag from account_sponsorship_page | 00:58 |
| CIA-27 | Mantisbt: hickseydr * r9f6433e1c96f /core/bug_group_action_api.php: Issue #12545: Remove duplicate form closing tag (bug actiongroup) | 00:58 |
| CIA-27 | Mantisbt: hickseydr * r90cc5cc12180 / (125 files in 6 dirs): Issue #12545: Remove deprecated <center> tag, align and valign attrs | 00:58 |
| CIA-27 | Mantisbt: hickseydr * r246332d41d3c / (8 files in 3 dirs): Issue #12545: Remove deprecated <font> tags from XHTML output | 00:58 |
| CIA-27 | Mantisbt: hickseydr * raa04132f79bd / (27 files in 5 dirs): Issue #12545: Remove deprecated border attribute | 00:58 |
| CIA-27 | Mantisbt: hickseydr * r3045096dd7a0 / (3 files in 3 dirs): Issue #12545: Replace deprecated nowrap attribute with CSS equivalent | 00:59 |
| CIA-27 | Mantisbt: hickseydr * r096b8c20314f /core/custom_function_api.php: Issue #12545: Replace deprecated <strike> tag with CSS equivalent | 00:59 |
| CIA-27 | Mantisbt: hickseydr * r58f8ad2aeb22 /print_all_bug_page_word.php: Issue #12545: Remove deprecated clear attribute | 00:59 |
| CIA-27 | Mantisbt: hickseydr * r6a0714fec042 / (5 files in 2 dirs): Issue #12545: Remove deprecated size and width attributes from <hr> | 00:59 |
| *** Joins: Github (~Github@sh1-ext.rs.github.com) | 02:30 | |
| Github | mantisbt: master David Hicks * 7790835 (12 files in 6 dirs): Issue #12631: Replace old dynamic filter JavaScript code with jQuery ... | 02:30 |
| Github | mantisbt: master David Hicks * cb5007d (1 files in 1 dirs): Issue #12545: Convert admin/check script to produce strict XHTML output ... | 02:30 |
| Github | mantisbt: master David Hicks * e7ab342 (1 files in 1 dirs): Update jQuery UI to v1.8.7 | 02:30 |
| Github | mantisbt: master David Hicks * 471900e (45 files in 6 dirs): Issue #12545: Replace with HTML5 compatible   ... | 02:30 |
| Github | mantisbt: master David Hicks * bac3bae (2 files in 1 dirs): Issue #12545: Replace last remaining <br>'s with <br /> ... | 02:30 |
| Github | mantisbt: master David Hicks * 246332d (8 files in 3 dirs): Issue #12545: Remove deprecated <font> tags from XHTML output ... | 02:30 |
| Github | mantisbt: master David Hicks * 49aac09 (54 files in 5 dirs): Issue #12545: Replace deprecated <b> tags with <strong> ... | 02:30 |
| Github | mantisbt: master David Hicks * 6f0f593 (1 files in 1 dirs): Issue #12545: Remove deprecated <u> tag from account_sponsorship_page ... | 02:30 |
| Github | mantisbt: master David Hicks * 9f6433e (1 files in 1 dirs): Issue #12545: Remove duplicate form closing tag (bug actiongroup) ... | 02:30 |
| Github | mantisbt: master David Hicks * 90cc5cc (125 files in 6 dirs): Issue #12545: Remove deprecated <center> tag, align and valign attrs ... | 02:30 |
| Github | mantisbt: master David Hicks * aa04132 (27 files in 5 dirs): Issue #12545: Remove deprecated border attribute ... | 02:30 |
| Github | mantisbt: master David Hicks * 096b8c2 (1 files in 1 dirs): Issue #12545: Replace deprecated <strike> tag with CSS equivalent ... | 02:30 |
| Github | mantisbt: master David Hicks * 58f8ad2 (1 files in 1 dirs): Issue #12545: Remove deprecated clear attribute ... | 02:30 |
| Github | mantisbt: master David Hicks * 3045096 (3 files in 3 dirs): Issue #12545: Replace deprecated nowrap attribute with CSS equivalent ... | 02:30 |
| *** Parts: Github (~Github@sh1-ext.rs.github.com) | 02:30 | |
| *** Quits: kirillka (~Miranda@156-237-55-95.baltnet.ru) (Quit: kirillka) | 02:57 | |
| *** Joins: paulr (~IceChat09@cpc1-enfi9-0-0-cust389.hari.cable.virginmedia.com) | 03:57 | |
| paulr | Morning | 03:57 |
| *** Joins: paulr_ (~IceChat09@cpc1-enfi9-0-0-cust389.hari.cable.virginmedia.com) | 04:06 | |
| *** Quits: paulr_ (~IceChat09@cpc1-enfi9-0-0-cust389.hari.cable.virginmedia.com) (Quit: Friends help you move. Real friends help you move bodies.) | 04:06 | |
| *** Quits: giallu (~giallu@fedora/giallu) (Ping timeout: 240 seconds) | 04:10 | |
| *** Joins: giallu (~giallu@host118-186-dynamic.18-79-r.retail.telecomitalia.it) | 04:34 | |
| *** Quits: giallu (~giallu@host118-186-dynamic.18-79-r.retail.telecomitalia.it) (Changing host) | 04:34 | |
| *** Joins: giallu (~giallu@fedora/giallu) | 04:34 | |
| *** Joins: kirillka (~Miranda@201-226-55-95.baltnet.ru) | 04:48 | |
| *** Quits: giallu (~giallu@fedora/giallu) (Ping timeout: 276 seconds) | 05:10 | |
| *** Joins: giallu (~giallu@host244-189-dynamic.8-79-r.retail.telecomitalia.it) | 05:33 | |
| *** Quits: giallu (~giallu@host244-189-dynamic.8-79-r.retail.telecomitalia.it) (Changing host) | 05:33 | |
| *** Joins: giallu (~giallu@fedora/giallu) | 05:33 | |
| *** Quits: giallu (~giallu@fedora/giallu) (Ping timeout: 240 seconds) | 05:45 | |
| *** Joins: moto-moi (~hylke@2001:888:13e4:1010:21f:e2ff:fe0c:ce28) | 06:21 | |
| *** Joins: giallu (~giallu@host117-10-dynamic.9-79-r.retail.telecomitalia.it) | 07:00 | |
| *** Quits: giallu (~giallu@host117-10-dynamic.9-79-r.retail.telecomitalia.it) (Changing host) | 07:00 | |
| *** Joins: giallu (~giallu@fedora/giallu) | 07:00 | |
| paulr | giallu | 07:03 |
| paulr | what version of php does fedora ship nowadays? | 07:03 |
| *** Quits: giallu (~giallu@fedora/giallu) (Ping timeout: 276 seconds) | 07:13 | |
| moto-moi | paulr: core 6 seems to be shipping 5.1.6 ( http://archive.nl.eu.kernel.org/fedora-archive/core/6/x86_64/os/Fedora/RPMS/ ) | 07:18 |
| paulr | http://distrowatch.com/table.php?distribution=redhat says 5.3 | 07:18 |
| paulr | dhx/myself talking about php versions | 07:18 |
| moto-moi | maybe they are looking at the development tree? | 07:22 |
| paulr | I thought 5.1.6 was rhel5 | 07:23 |
| paulr | http://www.redhat.com/rhel/server/details/ | 07:27 |
| paulr | Updates to the popular web scripting and programming languages PHP (5.3.2), | 07:28 |
| CIA-27 | Mantisbt: hickseydr * r7a6fba7c7d89 /bugnote_add_inc.php: Issue #12545: Remove inline onclick attribute from bugnote submit button | 07:54 |
| CIA-27 | Mantisbt: hickseydr * radf2338accb8 / (4 files in 4 dirs): Issue #12545: Remove inline JavaScript handlers from MantisGraph | 07:55 |
| *** Joins: giallu (~giallu@host25-188-dynamic.32-79-r.retail.telecomitalia.it) | 08:38 | |
| *** Quits: giallu (~giallu@host25-188-dynamic.32-79-r.retail.telecomitalia.it) (Changing host) | 08:38 | |
| *** Joins: giallu (~giallu@fedora/giallu) | 08:38 | |
| giallu | paulr, https://admin.fedoraproject.org/community/package_maintenance?package=php | 08:45 |
| paulr | so rhel = 5.3.2, MS = 5.2.14, fedore = 5.3.4, ubuntu = 5.3 | 08:50 |
| paulr | giallu: trying to kill off adodb | 08:52 |
| paulr | :) | 08:52 |
| giallu | paulr, what's the plan? | 08:56 |
| dhx1 | giallu: trying to move to using PDO | 08:57 |
| dhx1 | giallu: paulr wants to have the option of writing alternative native SQL implementations of our database layer too | 08:57 |
| dhx1 | giallu: although I disagree with that and would prefer to stick with PDO for everything (less code, less risk of bugs in a native implementation, etc) | 08:58 |
| dhx1 | not that I mind too much either way at the moment... will wait and see what happens | 08:58 |
| giallu | sigh | 08:59 |
| dhx1 | giallu: regarding PHP versions I suggested we starting looking at using PHP 5.3 namespaces for some of the new code | 08:59 |
| *** Quits: giallu (~giallu@fedora/giallu) (Ping timeout: 240 seconds) | 09:04 | |
| *** Joins: giallu (~giallu@fedora/giallu) | 09:08 | |
| giallu | what strikes me is how I always start to work on stuff, then someone tells me paulr is in the same area | 09:11 |
| giallu | anyway, I'll just finish this stuff I'm on now, then push it somewhere and see | 09:12 |
| CIA-27 | Mantisbt: hickseydr * r4b0e0d5d5494 / (4 files in 3 dirs): Issue #11826: Remove inline JavaScript for tag filter + date filter | 09:12 |
| dhx1 | giallu: since when did you start? :) | 09:12 |
| dhx1 | giallu: paulr started writing code just a few minutes ago, so it's not too late to collaborate (I'd encourage it) | 09:13 |
| paulr | dropping adodb has been on cards for a while | 09:13 |
| paulr | dhx/myself just took until last week to agree on pdo | 09:14 |
| dhx1 | I always agreed on PDO btw :P | 09:14 |
| *** Joins: thraxisp (~thraxisp@24.139.16.154) | 09:14 | |
| dhx1 | my aim here is to write the simplest database layer possible... and have it supported by someone else :P | 09:14 |
| paulr | i'm just copying/pasting chunks of what I had before | 09:15 |
| paulr | heh | 09:15 |
| dhx1 | (as long as it is still useful and functional) | 09:15 |
| giallu | btw. I helped a company to merge a couple servers they had with some new code I wanted to contribute, as it's basically a Zend based database layer | 09:15 |
| giallu | the code I have now it's for 1.1, so I will need to adapt it to the 1.2 schema | 09:17 |
| dhx1 | giallu: what does ZendDB add over native PDO? | 09:17 |
| giallu | no need to write SQL? | 09:18 |
| dhx1 | my idea was to really just use PDO with some interception of calls to create a statement using a query string (so we can search/replace or translate queries between particulars of each database backend... ILIKE/LIKE, etc) | 09:18 |
| dhx1 | abstractions of SQL are doomed IMO | 09:18 |
| giallu | my Django application for another project I'm working on does not agree... ;) | 09:19 |
| dhx1 | they can't handle anything even remotely complex (SELECT COUNT(bugs.bug_id) AS count, users.reporter_name AS reporter FROM bugs LEFT JOIN users WHERE bugs.reporter_id = users.user_id ORDER BY users.reporter ASC) | 09:21 |
| nuclear_eclipse | just as a point of interest, I've been using CodeIgniter's ActiveRecord in my latest project, and it has worked really well for everything except for compound where clauses, eg, if I want to do `where A and (B or C) and D`, I have to write that where clause myself | 09:21 |
| nuclear_eclipse | but for everything else in the project, which is fairly complicated, it has been able to accomplish everything I've needed it to | 09:22 |
| paulr | well, I was showing dhx a framework a while back where you have ->select()->where()->orderby() type thing abstraction | 09:22 |
| nuclear_eclipse | paulr: that's basically what CI uses | 09:23 |
| paulr | but david at least doesn't seem keen on having db_insert_record() type functions | 09:23 |
| nuclear_eclipse | http://codeigniter.com/user_guide/database/active_record.html | 09:23 |
| dhx1 | it's also harder to read ->select()->where()->orderby().. than an SQL query | 09:23 |
| dhx1 | and harder to debug and maintain (cannot trace a query from DB server logs to a location in the MantisBT source code as easily) | 09:24 |
| *** Quits: giallu (~giallu@fedora/giallu) (Ping timeout: 276 seconds) | 09:25 | |
| paulr | right now, i'm trying to get a 'simple' MantisDB layer | 09:26 |
| paulr | that can replace adodb | 09:26 |
| paulr | as we've been unable to "agree" on a db api (although that's more from random chats but) | 09:27 |
| paulr | Step 1: add MantisDB | 09:27 |
| paulr | Step 2: Bin adodb | 09:27 |
| paulr | Step 3: Add helper functions/hooks to do ->select or whatever | 09:27 |
| paulr | we kinda know from looking at moodle/zend/ecz/symfony/<insert db framework here> that none meet out needs exactly | 09:27 |
| paulr | and for what we support it's probably quick enough to code our own | 09:28 |
| *** Joins: giallu (~giallu@fedora/giallu) | 09:33 | |
| CIA-27 | Mantisbt: hickseydr * r2a1eed9db111 /core/http_api.php: Fix #11826: All inline JavaScript now removed | 09:34 |
| giallu | I'm on a flaky connection today :( anyway, after thinking about it a bit more, I don't see much overlap between my work and the "let's remove adodb" task | 09:34 |
| dhx1 | Firefox 4 users rejoice! :) | 09:34 |
| dhx1 | in the 1.3.x branch, Firefox 4 users are now protected against future XSS vulnerabilities... JavaScript code cannot be used in such attacks | 09:35 |
| giallu | let's party :) | 09:36 |
| * giallu hates XSS | 09:36 | |
| dhx1 | next up on my security improvements list: output templating, mitigating timing attacks on logins, implementing RBAC to replace access_api, new authentication API | 09:38 |
| paulr | giallu: dhx/myself had/have a bunch of stuff to push and some other stuff we want to get fixed | 09:38 |
| thraxisp | paulr: I don't understand why we need our own db abstraction? What is missing from moodle/zend/ecz/symfony/<insert db framework here>? | 09:38 |
| * giallu loves thraxisp | 09:38 | |
| paulr | thraxisp: none of them handle the schema stuff | 09:39 |
| thraxisp | I've not run across anything I can't do in Zend or Doctrine yet. | 09:39 |
| paulr | or well, moodle's does | 09:39 |
| thraxisp | Synphony / doctrine does | 09:39 |
| paulr | moodle's was closest with there xmldb stuff, but it's hard to unbundle their layer | 09:39 |
| dhx1 | why not just use PDO directly though... it's built into PHP, is least likely to become unmaintained, etc | 09:39 |
| paulr | thraxisp: not exactly :) | 09:39 |
| paulr | thraxisp: as they dont like ALTER statements in some cases | 09:39 |
| paulr | e.g. where you've got existing date | 09:40 |
| paulr | er data | 09:40 |
| paulr | dhx wants to just use pdo directly | 09:40 |
| paulr | so we're probably more talking a simple wrapper | 09:40 |
| paulr | we've hit issues with adodb where we've needed to patch it specifically for us | 09:41 |
| paulr | to the extent, trying to get those changes into upstream has wasted more time then i'd estimate our own layer would cost | 09:41 |
| *** Quits: giallu (~giallu@fedora/giallu) (Ping timeout: 240 seconds) | 09:42 | |
| paulr | ( I need to replace adodb before 4th January when I go back to work, so I can upgrade mantis at work - as adodb = broken (as people dont want us adding our own patches) | 09:43 |
| paulr | As of 6 weeks ago, the other frameworks still fail on some of our historical schema updates, or dont support all of the DB's we support etc | 09:44 |
| paulr | (technically we 'support' db2, oracle, pgsql, sqlsrv, mysql atm) | 09:44 |
| dhx1 | paulr: by 4th January is a bit ambitious IMO | 09:44 |
| dhx1 | paulr: the upgrade script will require a lot of thought | 09:45 |
| paulr | dhx1: did I mention i've got nothing else to do wiht my life until 4th? :) | 09:45 |
| paulr | could be 30 hours of development :p | 09:45 |
| dhx1 | :) | 09:46 |
| paulr | also, in terms of upgrade's | 09:46 |
| dhx1 | just make sure you commit in small quantities | 09:47 |
| paulr | i'd like to keep addob's datadict format | 09:47 |
| dhx1 | as in, commit the backing classes | 09:47 |
| dhx1 | then go through one file at a time updating the old DB code | 09:47 |
| dhx1 | you'll notice HTML formatting in 1.3.x may be broken | 09:47 |
| paulr | hoping to keep db_query_bound at least as a compat layer | 09:47 |
| dhx1 | and it won't work in IE < 9 at all... for now | 09:47 |
| paulr | yea, i fixed a couple of issues in install.php | 09:48 |
| dhx1 | I'm working to fix that ;) | 09:48 |
| thraxisp | dhx1: Will it work in IE6 eventually? (40% of IE) | 09:48 |
| dhx1 | thraxisp: not sure yet... I was thinking it'd be better to implement 2 "skins" - one very basic and supporting text browsers, IE6, etc - the other aimed towards modern browsers | 09:50 |
| dhx1 | IE6 is dead anyhow | 09:50 |
| dhx1 | when Google et al don't support it any more, I think it's safe to say that we don't need to either | 09:51 |
| thraxisp | It's 40% of the IE users. It's not dead yet. | 09:51 |
| dhx1 | "support" = most features... | 09:51 |
| thraxisp | Most are corporate as well. | 09:51 |
| dhx1 | I'm sure IE6 will render something, it just won't look good | 09:51 |
| paulr | thraxisp: I wouldn't worry too much about IE6, most of dhx's stuff doesn't work in chrome either :P | 09:52 |
| thraxisp | So we're going Win7 only :) | 09:52 |
| paulr | chrome trunk probably | 09:53 |
| dhx1 | it's not possible to produce a skin aimed towards modern browsers that also works with IE6 | 09:53 |
| dhx1 | there are too many things that break | 09:53 |
| paulr | detect browser version in javascript :P | 09:54 |
| thraxisp | http://code.google.com/p/ie7-js/ | 09:54 |
| dhx1 | that is why I was thinking of having a simple "text only" mode that is the simplest/dumbest interface possible | 09:54 |
| dhx1 | almost "text only" | 09:54 |
| dhx1 | with a minimal amount of CSS 2 thrown in | 09:55 |
| paulr | thraxisp: i'd say your numbers are out on ie6 btw | 09:55 |
| paulr | It's 40% of the IE users. It's not dead yet. | 09:56 |
| paulr | [02:51.25] <dhx1> "support" = most features... | 09:56 |
| paulr | [02:51.47] <thraxisp> Most are corporate as well. | 09:56 |
| paulr | [02:51.47] <dhx1> I'm sure IE6 will render something, it just won't look good | 09:56 |
| paulr | [02:52.31] <paulr> thraxisp: I wouldn't worry too much about IE6, most of dhx's stuff doesn't work in chrome either :P | 09:56 |
| paulr | [02:52.58] <thraxisp> So we're going Win7 only :) | 09:56 |
| paulr | [02:53.21] <paulr> chrome trunk probably | 09:56 |
| paulr | [02:53.46] <dhx1> it's not possible to produce a skin aimed towards modern browsers that also works with IE6 | 09:56 |
| paulr | [02:53.54] <dhx1> there are too many things that break | 09:56 |
| paulr | [02:54.08] <paulr> detect browser version in javascript :P | 09:56 |
| paulr | [02:54.14] < | 09:56 |
| paulr | ahh | 09:56 |
| paulr | eww | 09:56 |
| paulr | http://stats.wikimedia.org/archive/squid_reports/2010-10/SquidReportClients.htm | 09:56 |
| paulr | would imply more like 10% of ie users | 09:56 |
| paulr | http://www.w3counter.com/globalstats.php?year=2010&month=11 says 4.93% of web users on ie6 | 09:57 |
| dhx1 | actually around 5% (considering mobile users aren't counted in the 5.32%) | 09:57 |
| dhx1 | yep | 09:57 |
| paulr | however 5% of 200million is still quite a big number ;p | 09:57 |
| paulr | and dhx, I guess it's important to consider that mantis users might both be people/companies that either run cutting edge or old | 09:59 |
| dhx1 | right - which is why I suggested two skins/frontends | 10:00 |
| paulr | however, IE6 is support by MS until end of support for XP | 10:01 |
| paulr | which is April 8th 2014 | 10:02 |
| micahg | I think most IE6 users are corporate users | 10:02 |
| paulr | i'd be inclined to think by next summer most corporate users will be off IE6 or have plans in place | 10:03 |
| paulr | i.e. | 10:03 |
| paulr | Win7 SP1 out, XP dying off - 2 year or whatever countdown | 10:03 |
| paulr | new hardware etc | 10:03 |
| dhx1 | well I think it'd be safe to make a MantisBT frontend that contains just the basic pages - view, edit, report, summarise, etc for IE6 users | 10:05 |
| paulr | if we release a mantis 1.3 in say... June July - 2-3 months after win7 SP1 - i'm not sure i'd necessarily see an issue with going "IE6 dropped, php5.3 only" | 10:05 |
| dhx1 | and if anyone needs to manage their installation they can do so with a more modern browser | 10:05 |
| paulr | more modern = google trunk? | 10:06 |
| *** Joins: giallu (~giallu@fedora/giallu) | 10:06 | |
| dhx1 | paulr: I was thinking Firefox 3+ | 10:06 |
| paulr | isn't 4 out? | 10:07 |
| dhx1 | not yet | 10:07 |
| paulr | maybe we should come up with some sort of policy on what we support ;) | 10:09 |
| paulr | or more how we calculate what we support ;p | 10:09 |
| dhx1 | we can support multiple things :) | 10:09 |
| dhx1 | if we finally implement a theming/templating approach it'll be possible to have multiple versions of the same page | 10:09 |
| paulr | I was more thinking in terms of db's, php, browsers | 10:10 |
| dhx1 | one version might use HTML5, another might use HTML4 with <font> tags... (I'm not helping with that :P) | 10:10 |
| dhx1 | also worth noting is that IE6 users aren't going to install the latest MantisBT 1.3.x release | 10:10 |
| dhx1 | they're going to opt for something "stable" like mantisbt-1.2.x | 10:11 |
| dhx1 | Debian et al are still stuck with MantisBT 1.1.x! | 10:11 |
| paulr | dare I ask? | 10:12 |
| micahg | it's unfortunate, the upgrade scripts need updating and no one has had time yet | 10:19 |
| paulr | dare I ask | 10:20 |
| paulr | does that translate to | 10:20 |
| paulr | debian doesn't want to / can't / won't use whatever mantis does, and haven't had time to upgrade their own scripts? | 10:20 |
| dhx1 | paulr: they need maintainers to look after MantisBT, write the package script, etc | 10:21 |
| paulr | tar zxvf mnantisbt.tgz ; curl http://localhost/admin/upgrade.php | 10:23 |
| micahg | paulr:: the debian package needs to update the db, it would be nice if we can get that to use the mantis upgrade mechanisms, but I haven't looked into the package policy enough to know if it's possible | 10:26 |
| thraxisp | I talked with the debian maintainer about 3 years ago. Our upgrade script wasn't acceptable because it didn't use the debian way. I think that there is a bug in the tracker on this. | 10:28 |
| * paulr sighs | 10:41 | |
| paulr | we'd be better asking them to drop the package fullstop then tbh ;p | 10:41 |
| paulr | http://people.debian.org/~seanius/policy/dbapp-policy.html/ch-dbapps.html | 10:43 |
| paulr | "while not essential, a set of common tools for packaging and configuring these applications can make the life of the maintainer as well as the administrator much easier." | 10:44 |
| paulr | so not essential? | 10:44 |
| paulr | so we can use our own | 10:44 |
| paulr | providing it backs up first? | 10:44 |
| *** Quits: paulr (~IceChat09@cpc1-enfi9-0-0-cust389.hari.cable.virginmedia.com) (Read error: Connection reset by peer) | 10:48 | |
| *** Joins: paulr (~IceChat09@cpc1-enfi9-0-0-cust389.hari.cable.virginmedia.com) | 10:49 | |
| giallu | umh. is it correct we now include/require files with the absolute paths? | 11:21 |
| paulr | no? | 11:27 |
| paulr | or what do you mean | 11:27 |
| paulr | and yes, it would seem so | 11:29 |
| paulr | we seem to include based on what library path and class path are set to | 11:29 |
| giallu | no way to disable it? | 11:29 |
| paulr | looking, would seem not | 11:30 |
| giallu | :( | 11:30 |
| paulr | or well, I guess it might fall through if files dont exist | 11:30 |
| paulr | iirc, that was dhx :) | 11:30 |
| giallu | well, I suspected "require_api" was going to bite me one day :) | 11:32 |
| paulr | heh | 11:32 |
| paulr | well, | 11:32 |
| paulr | 99% of people probably use tarball from site | 11:33 |
| * paulr shrugs | 11:33 | |
| giallu | only if we believe Linux is under 1% ;) | 11:34 |
| paulr | well it depends how many people use packages | 11:34 |
| paulr | but yea | 11:34 |
| paulr | the mess of what seems to be linux packaging is one of the reasons i'd rather write our own db layer | 11:35 |
| giallu | paulr, keyword is "seems" | 11:36 |
| paulr | :) | 11:36 |
| paulr | well, the fact that ubuntu put on their LTS release (from April 2010) mantis 1.1, where we released 1.2.0 (february 2010), doesn't help to change my view :) | 11:37 |
| giallu | that's not really a good example | 11:38 |
| giallu | but I see the point | 11:38 |
| giallu | distro needs do not always blend with upstream projects needs | 11:39 |
| paulr | my issue is, if we add a library, in some cases, it causes more issues with the various distributions then not adding the library in the first place | 11:40 |
| paulr | which in some cases is a shame | 11:40 |
| paulr | even the license thing of our code | 11:41 |
| paulr | we gotta jump through hoops to relicense it correctly | 11:41 |
| giallu | well. that's not distro's fault | 11:42 |
| paulr | and I suspect that most people dont care :) | 11:42 |
| paulr | yea | 11:42 |
| paulr | it doesn't help that mantis isn't really an entity | 11:43 |
| giallu | back to my issue. I'll need to investigate why we include stuff with absolute paths | 11:43 |
| paulr | you might find it falls through? | 11:43 |
| paulr | i.e. if your in a plugin | 11:43 |
| paulr | trying to include something | 11:43 |
| paulr | yay | 12:00 |
| *** Quits: giallu (~giallu@fedora/giallu) (Quit: Leaving) | 12:02 | |
| paulr | nuclear_eclipse: can you do me a favour? | 12:16 |
| nuclear_eclipse | depends | 12:23 |
| *** Quits: thraxisp (~thraxisp@24.139.16.154) (Read error: Connection reset by peer) | 12:28 | |
| *** Joins: thraxisp (~thraxisp@24.139.16.154) | 12:28 | |
| *** Joins: Github (~Github@sh1-ext.rs.github.com) | 12:30 | |
| Github | mantisbt: master David Hicks * 7a6fba7 (1 files in 1 dirs): Issue #12545: Remove inline onclick attribute from bugnote submit button ... | 12:30 |
| Github | mantisbt: master David Hicks * adf2338 (4 files in 4 dirs): Issue #12545: Remove inline JavaScript handlers from MantisGraph ... | 12:30 |
| Github | mantisbt: master David Hicks * 4b0e0d5 (4 files in 3 dirs): Issue #11826: Remove inline JavaScript for tag filter + date filter ... | 12:30 |
| Github | mantisbt: master David Hicks * 2a1eed9 (1 files in 1 dirs): Fix #11826: All inline JavaScript now removed ... | 12:30 |
| Github | mantisbt: master commits 6a0714f...2a1eed9 - http://bit.ly/fyNdcS | 12:30 |
| *** Parts: Github (~Github@sh1-ext.rs.github.com) | 12:30 | |
| paulr | nuclear_eclipse: kill David for me :) | 12:46 |
| nuclear_eclipse | Not happening, he at least makes commits and doesn't complain about merging his working copy with latest master ;) | 12:46 |
| paulr | we couldn't decide earlier | 12:47 |
| paulr | for a user to upgrade to 1.3 | 12:47 |
| paulr | does he need to be able to do that from 1.0? | 12:47 |
| nuclear_eclipse | I would personally say yes, that's the entire point of us having versioned db schema from 1.0.0 | 12:49 |
| paulr | nodnod | 12:49 |
| paulr | i'm just wondering about dates :P | 12:49 |
| nuclear_eclipse | well, we could probably improve the migration process, but I definitely think it's important to maintain that upgrade path | 12:52 |
| paulr | I think i'm going to assume that db_query() is dead | 12:53 |
| paulr | nuclear_eclipse: what would you expect db_param() to insert into query? | 13:20 |
| paulr | :name or ? ? | 13:20 |
| nuclear_eclipse | I would expect it to be based on the database type in use, expecting it to send a proper parameterized query to the db | 13:21 |
| paulr | with pdo? ;p | 13:21 |
| paulr | dhx seemed to think pdo'll handle it for us | 13:21 |
| paulr | I'm thinking therefore :1, :2 etc | 13:22 |
| paulr | so we can always replace :<int> with ? | 13:22 |
| paulr | but we can define an order if needbe | 13:22 |
| nuclear_eclipse | I don't know anything about pdo, but my point is that I would expect it to be completely based on whatever our dbal says is the correct placeholder to use | 13:22 |
| paulr | PDO will emulate prepared statements/bound parameters for drivers that do not natively support them, and can also rewrite named or question mark style parameter markers to something more appropriate, if the driver supports one style but not the other. | 13:22 |
| paulr | The SQL statement can contain zero or more named (:name) or question mark (?) parameter markers for which real values will be substituted when the statement is executed. You cannot use both named and question mark parameter markers within the same SQL statement; pick one or the other parameter style. Use these parameters to bind any user-input, do not include the user-input directly in the query. | 13:23 |
| paulr | You must include a unique parameter marker for each value you wish to pass in to the statement when you call PDOStatement::execute(). You cannot use a named parameter marker of the same name twice in a prepared statement. You cannot bind multiple values to a single named parameter in, for example, the IN() clause of an SQL statement | 13:23 |
| paulr | so i'm basically thinking | 13:23 |
| paulr | we should always use :name (as that allows us to alter order in php, and pdo magically deals with it | 13:23 |
| nuclear_eclipse | doesn't matter to me as long as you support the existing usage of db_param and db_query_param -- I'll break your fingers if you break the way plugins are expecting to use the database api | 13:26 |
| paulr | db_query = dead (but that's in database_api as 'will be removed before 1.2.0 final') | 13:49 |
| paulr | i've got mysql working without adodb atm | 13:49 |
| paulr | and i've not actually written any code yet really | 13:49 |
| paulr | [06:26.09] <nuclear_eclipse> doesn't matter to me as long as you support the existing usage of db_param and db_query_param -- I'll break your fingers if you break the way plugins are expecting to use the database api | 13:56 |
| paulr | db_query_param? | 13:56 |
| paulr | you meant bound? | 13:56 |
| nuclear_eclipse | yeah | 13:56 |
| paulr | did we not add something so you could set order of db_param? | 13:57 |
| nuclear_eclipse | no | 13:57 |
| paulr | rephrase then | 13:57 |
| paulr | would you like to be able to set order of db_param? | 13:57 |
| paulr | i.e. if you could do either | 13:57 |
| paulr | bound( sql, array( 1,2,3) ; | 13:57 |
| paulr | or | 13:57 |
| paulr | bound ( sql, array( 'p1'=>1, 'p3'=>3, 'p2'=>2); | 13:58 |
| nuclear_eclipse | my point is that db_param() should default to being unordered imo, because there are places where db_param() isn't always called in the order it will appear in the query, although I could be wrong about that, but that assumption should IMO be maintained unless you add optional parameters to specify otherwise | 13:59 |
| nuclear_eclipse | unless that was always an incorrect assumption | 13:59 |
| paulr | atm, we call db_param(); | 14:00 |
| paulr | as only way to call it | 14:00 |
| paulr | and for most part db_param is probably putting ? into query string | 14:00 |
| paulr | therefore it's "ordered" | 14:00 |
| nuclear_eclipse | yes, I'm saying to maintain that as the default behavior | 14:01 |
| paulr | I thought we had some unordered stuff but i think I worked around that by building an array of params seperately to buidling the query | 14:01 |
| * paulr grpes for db_param_count | 14:02 | |
| paulr | brilliant makes life easy | 14:03 |
| paulr | whats actually going to be hardest is working out how/if we can translate the datetime<>int schema changes | 14:07 |
| *** Joins: roentgen (~arthur@openvpn/community/support/roentgen) | 14:41 | |
| *** Quits: micahg (~micah@ubuntu/member/micahg) (Quit: Leaving.) | 16:03 | |
| *** Joins: micahg (~micah@ubuntu/member/micahg) | 16:04 | |
| dhx1 | paulr: use named parameters such as SELECT something FROM table WHERE field = :param; | 16:30 |
| dhx1 | paulr: and then bind those parameters one per line as follows: | 16:30 |
| dhx1 | $statement->bindParam(':param', $phpvar, PDO::PARAM_STR); etc | 16:31 |
| dhx1 | unless you're referring to writing a compatibility layer with the old db_ API... in which case do whatever :) | 16:31 |
| *** Quits: dhx1 (~anonymous@c122-107-170-247.eburwd5.vic.optusnet.com.au) (Remote host closed the connection) | 16:58 | |
| paulr | :) | 17:11 |
| paulr | I guess that's dhx gone | 17:18 |
| *** Joins: giallu (~giallu@fedora/giallu) | 17:42 | |
| *** Quits: roentgen (~arthur@openvpn/community/support/roentgen) (Ping timeout: 260 seconds) | 17:45 | |
| *** Joins: roentgen (~arthur@openvpn/community/support/roentgen) | 17:46 | |
| *** Quits: moto-moi (~hylke@2001:888:13e4:1010:21f:e2ff:fe0c:ce28) (Ping timeout: 260 seconds) | 17:47 | |
| giallu | is admin/install.php borken on master? | 18:58 |
| paulr | yes | 18:58 |
| paulr | I fixed it locally earlier | 18:59 |
| paulr | or well, it's not broken but not rendering proper xhtml | 18:59 |
| paulr | so google chrome at least wouldn't display it | 18:59 |
| *** Quits: scribe9343423 (~scribe934@static.96.23.63.178.clients.your-server.de) (Remote host closed the connection) | 19:00 | |
| paulr | giallu: can you do us a favour | 19:00 |
| *** Joins: scribe9343423 (~scribe934@static.96.23.63.178.clients.your-server.de) | 19:00 | |
| paulr | does the current/"old" db debug stuff show the query BEFORE or AFTER parameters have been applied | 19:00 |
| giallu | FF3.6 not displaying it either | 19:03 |
| paulr | it does't return valid xhtml in trunk atm | 19:03 |
| paulr | I found this out when changing other stuff earlier ;/ | 19:03 |
| giallu | yay for strict ;) | 19:03 |
| giallu | paulr, I'm not sure what you mean | 19:04 |
| giallu | wrt debug stuff | 19:04 |
| paulr | i think i've worked it out | 19:07 |
| paulr | at one point we used to do the unique queries stuff | 19:07 |
| paulr | was trying to remember what that built | 19:07 |
| paulr | giallu: fedore has a mantis package? | 19:07 |
| giallu | yeah. 1.2 in what will be F15, 1.1 elsewhere | 19:08 |
| paulr | how does it update the db? | 19:08 |
| paulr | via our web scripts or? | 19:08 |
| paulr | giallu: and yes 'strict' is starting to piss me off | 19:11 |
| paulr | as it gives white pages :) | 19:11 |
| giallu | yeah, I'm wasting time there instead of doing the stuff I planned :( | 19:13 |
| giallu | so. I'm off to bed | 19:14 |
| *** Quits: paulr (~IceChat09@cpc1-enfi9-0-0-cust389.hari.cable.virginmedia.com) (Quit: For Sale: Parachute. Only used once, never opened, small stain.) | 20:22 | |
Generated by irclog2html.py 2.9.2 by Marius Gedminas - find it at mg.pov.lt!