| *** Joins: kirillka (~Miranda@195.242.142.17) | 01:10 | |
| *** Quits: kirillka (~Miranda@195.242.142.17) (Remote host closed the connection) | 01:11 | |
| *** Joins: kirillka (~Miranda@195.242.142.17) | 01:11 | |
| *** Joins: mantisbt_79111 (54a5abfd@gateway/web/freenode/ip.84.165.171.253) | 02:21 | |
| *** Quits: siebrand (~chatzilla@535392CA.cm-6-4c.dynamic.ziggo.nl) (Remote host closed the connection) | 02:31 | |
| *** Joins: Cupertino (~Cupez@62-177-158-122.dsl.bbeyond.nl) | 02:38 | |
| *** Quits: Cupertino (~Cupez@62-177-158-122.dsl.bbeyond.nl) (Changing host) | 02:38 | |
| *** Joins: Cupertino (~Cupez@unaffiliated/cupertino) | 02:38 | |
| *** Joins: giallu (~giallu@fedora/giallu) | 02:44 | |
| *** Joins: rolfkleef (~rolfkleef@urtica.xs4all.nl) | 03:54 | |
| *** Quits: mantisbt_79111 (54a5abfd@gateway/web/freenode/ip.84.165.171.253) (Quit: Page closed) | 04:09 | |
| *** Joins: Rixie (~Rixie@0x4dd7390e.adsl.cybercity.dk) | 04:40 | |
| *** Joins: YiSh (~joanna@host86-178-115-105.range86-178.btcentralplus.com) | 05:04 | |
| *** Joins: Al_Chapone (~chatzilla@ATuileries-153-1-73-105.w83-202.abo.wanadoo.fr) | 05:13 | |
| *** Quits: rolfkleef (~rolfkleef@urtica.xs4all.nl) (Ping timeout: 250 seconds) | 06:41 | |
| *** Quits: giallu (~giallu@fedora/giallu) (Ping timeout: 255 seconds) | 06:55 | |
| *** Joins: giallu (~giallu@fedora/giallu) | 06:56 | |
| *** Joins: rolfkleef (~rolfkleef@82-204-82-162.fttx.bbeyond.nl) | 06:58 | |
| *** Quits: Al_Chapone (~chatzilla@ATuileries-153-1-73-105.w83-202.abo.wanadoo.fr) (Ping timeout: 240 seconds) | 07:10 | |
| *** Joins: paulr (~a@212.85.5.19) | 07:35 | |
| * paulr pokes dhx1 | 07:35 | |
| paulr | I've got a configuration issue :) | 07:36 |
|---|---|---|
| paulr | can I make it such that a global manage is only a reporter in a specific project? | 07:37 |
| paulr | +r | 07:37 |
| paulr | i.e. can I assume it'll downgrade their rights :) | 07:38 |
| paulr | oh, PS, i'm gonna kill you :) | 07:39 |
| *** Joins: Al_Chapone (~chatzilla@ATuileries-153-1-73-105.w83-202.abo.wanadoo.fr) | 07:49 | |
| *** Quits: Al_Chapone (~chatzilla@ATuileries-153-1-73-105.w83-202.abo.wanadoo.fr) (Ping timeout: 240 seconds) | 08:22 | |
| *** Joins: Al_Chapone (~chatzilla@ATuileries-153-1-73-105.w83-202.abo.wanadoo.fr) | 08:26 | |
| *** Joins: Al_Chapone_ (~chatzilla@ATuileries-153-1-67-239.w83-202.abo.wanadoo.fr) | 08:32 | |
| *** Quits: Al_Chapone (~chatzilla@ATuileries-153-1-73-105.w83-202.abo.wanadoo.fr) (Ping timeout: 240 seconds) | 08:35 | |
| *** Al_Chapone_ is now known as Al_Chapone | 08:35 | |
| *** Joins: daryn (~daryn@h20.110.88.75.dynamic.ip.windstream.net) | 09:32 | |
| *** Quits: paulr (~a@212.85.5.19) () | 09:44 | |
| *** Quits: kirillka (~Miranda@195.242.142.17) (Quit: kirillka) | 10:02 | |
| *** Joins: siebrand (~chatzilla@535392CA.cm-6-4c.dynamic.ziggo.nl) | 10:38 | |
| *** Joins: micahg (~micah@ubuntu/member/micahg) | 10:39 | |
| *** Parts: Rixie (~Rixie@0x4dd7390e.adsl.cybercity.dk) | 11:02 | |
| *** Quits: Cupertino (~Cupez@unaffiliated/cupertino) (Quit: I give up...) | 11:07 | |
| *** Quits: giallu (~giallu@fedora/giallu) (Ping timeout: 255 seconds) | 12:02 | |
| *** Quits: Al_Chapone (~chatzilla@ATuileries-153-1-67-239.w83-202.abo.wanadoo.fr) (Quit: ChatZilla 0.9.86 [Firefox 3.6.13/20101203075014]) | 12:23 | |
| *** Joins: Cupertino (~Cupez@unaffiliated/cupertino) | 12:32 | |
| *** Joins: moto-moi (~hylke@2001:888:13e4:1010:21f:e2ff:fe0c:ce28) | 12:35 | |
| *** Joins: daryn_ (~daryn@h78.158.16.98.dynamic.ip.windstream.net) | 13:00 | |
| *** Quits: daryn (~daryn@h20.110.88.75.dynamic.ip.windstream.net) (Ping timeout: 260 seconds) | 13:03 | |
| *** Joins: daryn__ (~daryn@h117.64.29.71.dynamic.ip.windstream.net) | 13:04 | |
| *** Quits: daryn_ (~daryn@h78.158.16.98.dynamic.ip.windstream.net) (Ping timeout: 260 seconds) | 13:07 | |
| *** Quits: micahg (~micah@ubuntu/member/micahg) (Quit: Leaving.) | 13:17 | |
| *** Joins: micahg (~micah@ubuntu/member/micahg) | 13:26 | |
| *** Quits: YiSh (~joanna@host86-178-115-105.range86-178.btcentralplus.com) (Ping timeout: 240 seconds) | 13:51 | |
| *** Joins: JonMarkGo (~Jon@ool-4572146f.dyn.optonline.net) | 14:11 | |
| JonMarkGo | Hi, I am trying to set up GitHub to post to my Mantis install. When I do Import Latest Data it applies the changesets to tickets properly | 14:11 |
| JonMarkGo | But it doesn't auto-post when I push | 14:11 |
| JonMarkGo | I've tried both the MantisBT hook and the generic Post URL hook | 14:11 |
| nuclear_eclipse | JonMarkGo: I'm currently trying to resolve that problem | 14:12 |
| nuclear_eclipse | the mantisbt hook isn't sending data correctly, and I believe Github changed the data format used by the generic post-commit hook | 14:13 |
| JonMarkGo | Ah | 14:13 |
| JonMarkGo | So I should just wait for a patch? | 14:13 |
| nuclear_eclipse | unfortunately, I don't have much spare time to work on the fix, so if you happen to know ruby and php, you might be able to help get it working | 14:14 |
| *** Quits: micahg (~micah@ubuntu/member/micahg) (Ping timeout: 260 seconds) | 14:14 | |
| JonMarkGo | I do | 14:14 |
| * JonMarkGo coughs | 14:14 | |
| JonMarkGo | So you think the data format is just messed up? | 14:15 |
| nuclear_eclipse | I know the data format is messed up in the mantisbt hook, because I'm no good at ruby and couldn't get a proper test bed set up on my machine, so I had submitted something only to find out afterwards that it's not correct | 14:16 |
| nuclear_eclipse | either way, if you're willing to help out, check out https://github.com/github/github-services | 14:16 |
| JonMarkGo | Ah | 14:16 |
| JonMarkGo | I was going to say, Mantis doesn't use Ruby... | 14:16 |
| JonMarkGo | But the github side does | 14:16 |
| nuclear_eclipse | if you fork that, you can modify the mantis hook, and use a pull request to get them to merge it back to their system | 14:17 |
| JonMarkGo | Yeah | 14:17 |
| nuclear_eclipse | and if you need to modify the mantis plugin set at all, that repo is located at http://git.mantisforge.org | 14:17 |
| JonMarkGo | Wouldn't it be easier to modify the mantis side to match what github is sending rather than the other way around? | 14:17 |
| JonMarkGo | Or is the github side not sending all necessary data? | 14:17 |
| nuclear_eclipse | the github side isn't sending correctly formatted data, I don't know if I screwed up the way that it formats it, or what | 14:18 |
| JonMarkGo | Ok | 14:18 |
| nuclear_eclipse | I tried winging it based on code from other hooks, but I must have done soemthing wrong | 14:19 |
| JonMarkGo | Yeah | 14:19 |
| JonMarkGo | I keep getting connection refused when I try to clone from mantisforge | 14:20 |
| nuclear_eclipse | if you add some logging from mantis' plugin.php or from Source/pages/checkin.php, you should be able to see the data that Github is sending, and should be able to figure it out that way -- ideally I would like github's mantisbt hook to match their generic post-commit hook as much as possible so that the plugin can use the same code to handle both | 14:20 |
| JonMarkGo | Yup | 14:21 |
| nuclear_eclipse | yeah, paul never seems to get mantisforge running correctly, let me push to my github repo | 14:21 |
| nuclear_eclipse | 14:20 < JonMarkGo> I keep getting connection refused when I try to clone from mantisforge | 14:22 |
| nuclear_eclipse | crap | 14:22 |
| nuclear_eclipse | https://github.com/jreese/source-integration | 14:23 |
| *** daryn__ is now known as daryn | 14:23 | |
| JonMarkGo | So end goal is to have the mantisbt hook receive the same data as the post-receive URL | 14:25 |
| JonMarkGo | But for the mantisbt hook to be idiot-proof and append the plugin.php for you | 14:26 |
| nuclear_eclipse | that's at least the way I would handle it, but if there's a different way that would make it easier/simpler, I'm all ears | 14:26 |
| JonMarkGo | Ok | 14:27 |
| nuclear_eclipse | I happier just to have someone willing to help out :) | 14:27 |
| JonMarkGo | No problem | 14:27 |
| JonMarkGo | You on twitter? | 14:27 |
| nuclear_eclipse | @nuclear_eclipse | 14:28 |
| JonMarkGo | CM 7 is out? | 14:28 |
| nuclear_eclipse | it's in alpha stage atm | 14:29 |
| JonMarkGo | Ooh | 14:29 |
| JonMarkGo | I use CM6.1 on the incredible | 14:29 |
| nuclear_eclipse | but it's based on stock 2.3.1, runs really well so far on my Nexus S | 14:29 |
| JonMarkGo | Can't wait for a gingerbread update | 14:29 |
| nuclear_eclipse | gingerbread is seriously awesome | 14:29 |
| JonMarkGo | Is it a nightly build or experimental? | 14:30 |
| nuclear_eclipse | it's an alpha build available from rommanager | 14:30 |
| JonMarkGo | Ah | 14:31 |
| JonMarkGo | Isn't one for Inc yet | 14:31 |
| nuclear_eclipse | it's one of the benefits of running the unlocked phones from Google, they tend to get first wave support from custom roms | 14:36 |
| JonMarkGo | Yeah | 14:37 |
| JonMarkGo | json_commit_changeset is what's processing the github post data, right? | 14:47 |
| nuclear_eclipse | no | 14:47 |
| JonMarkGo | Heh, what is? | 14:48 |
| nuclear_eclipse | the post data really only triggers the plugin to send json requests to github's API to request updates for the repo | 14:48 |
| JonMarkGo | Oh | 14:48 |
| JonMarkGo | But doesn't the post data have all the info you'd need? | 14:48 |
| nuclear_eclipse | I don't know if it does these days, but a) it didn't when I first created the plugin, and b) if for some reason the system missed a previous update, this way it makes sure it gets the most up-to-date info for the entire repo | 14:49 |
| JonMarkGo | Ah | 14:49 |
| JonMarkGo | Heh | 14:57 |
| JonMarkGo | The mantis service hook is really funky | 14:57 |
| JonMarkGo | In reality, all it should do is pass the same data that the generic one does | 14:58 |
| JonMarkGo | I found one fun issue that you may know about | 15:20 |
| nuclear_eclipse | what's that? | 15:21 |
| JonMarkGo | Github is cloud hosted | 15:21 |
| JonMarkGo | So the single IP you provide is wron | 15:21 |
| JonMarkGo | wrong | 15:21 |
| *** Joins: micahg (~micah@ubuntu/member/micahg) | 15:21 | |
| nuclear_eclipse | ah, yeah, that used to be the only address that they used for post-commits | 15:22 |
| JonMarkGo | Yup | 15:22 |
| JonMarkGo | Actually, that might be the only issue with the generic post | 15:22 |
| nuclear_eclipse | these days I whitelist a few ip blocks | 15:22 |
| JonMarkGo | Heh | 15:23 |
| JonMarkGo | Once I allowed all IPs the generic post works fine | 15:23 |
| nuclear_eclipse | it's probably a bit too open, but for the most part I'm not too worried because it doesn't trust any of the data from the hook, just uses it to trigger an API pull | 15:23 |
| JonMarkGo | Yup | 15:23 |
| JonMarkGo | So how do you think this should be handled since there's no real way to define ALL of github's IPs? | 15:24 |
| JonMarkGo | For github you could jsut check the referrer | 15:24 |
| nuclear_eclipse | referrer? | 15:24 |
| JonMarkGo | Actually, that wont work | 15:25 |
| JonMarkGo | Not sure how you could verify that its actually from github | 15:25 |
| JonMarkGo | Or why you'd need to if all it does is trigger a pull | 15:27 |
| nuclear_eclipse | well, you'd technically still want to limit originating addresses to limit random attempts or DOS attacks | 15:29 |
| JonMarkGo | You could DDoS a server even if the page refuses your "checkin", but I guess it could help in preventing ddos against github | 15:29 |
| JonMarkGo | Though I imagine your server would crash before you dented github | 15:29 |
| JonMarkGo | Also, I figured out what's wrong with your github service | 15:30 |
| JonMarkGo | You do Net::HTTP.post_form(URI.parse(full_url), payload) | 15:30 |
| JonMarkGo | You need something like Net::HTTP.post_form(URI.parse(url), "payload" => payload.to_json) | 15:30 |
| nuclear_eclipse | true, I just tend to figure that it's better to whitelist a select set of IPs than to let everyone in | 15:30 |
| JonMarkGo | payload is an object | 15:30 |
| JonMarkGo | payload.to_json is a json object string | 15:30 |
| JonMarkGo | I agree, but clearly thats not possible with github | 15:30 |
| nuclear_eclipse | well, three IP blocks is still better than the entire internet :P | 15:31 |
| JonMarkGo | I suppose | 15:31 |
| nuclear_eclipse | if someone really wants to whitelist the entire internet, they can just enter 0.0.0.0 :P | 15:32 |
| JonMarkGo | https://github.com/jonmarkgo/github-services/commit/2455a22567df77a2f8348ad4cdf918965efb5fb2 | 15:32 |
| nuclear_eclipse | glad someone could save the day, probably would have taken me hours to figure that out :P | 15:33 |
| JonMarkGo | Submitted it for a pull request | 15:34 |
| JonMarkGo | Hopefully it fixes the issue | 15:34 |
| nuclear_eclipse | thank you | 15:34 |
| JonMarkGo | So anyway, as for IP recognition | 15:35 |
| JonMarkGo | Its up to you, but I'm doubtful you'll be able to get a proper whitelist | 15:35 |
| nuclear_eclipse | do you propose to just remove the IP check? | 15:36 |
| JonMarkGo | It seems kind of useless | 15:36 |
| JonMarkGo | If you were using the posted data to update mantis, you'd need some kind of security | 15:36 |
| JonMarkGo | But all it really does is trigger a pull from your repo | 15:37 |
| JonMarkGo | If someone tried to DDoS it, it wouldn't be any more effective than DDoSing index.php except that you'd be trying to hit github as well | 15:37 |
| JonMarkGo | And in reality, your webserver would crash and prevent the ddos long before github did :P | 15:37 |
| nuclear_eclipse | probably | 15:38 |
| JonMarkGo | If you want to do a proper fix, though.. | 15:38 |
| JonMarkGo | I'd recommend setting an API username/pass in the source module | 15:38 |
| JonMarkGo | And giving github a spot to pass that along in the post data | 15:38 |
| nuclear_eclipse | hmmm | 15:38 |
| JonMarkGo | Should be easy enough | 15:38 |
| nuclear_eclipse | yeah, that does seem reasonable, I'll probably put that on my to-do list | 15:40 |
| JonMarkGo | Adding it to the github side would take like 30 seconds | 15:40 |
| JonMarkGo | Adding it to mantis would be a little harder | 15:40 |
| nuclear_eclipse | yeah, ideally I'd like each repo to have a generated key, and it would mean updating all of the plugins and hook templates to deal with that | 15:41 |
| JonMarkGo | Yup | 15:41 |
| JonMarkGo | Or you could just have a generic key for now | 15:41 |
| JonMarkGo | For all repos | 15:41 |
| JonMarkGo | But only use it on github | 15:41 |
| nuclear_eclipse | I'd gladly accept code contributions :P | 15:47 |
| JonMarkGo | Yeah | 15:47 |
| JonMarkGo | So I'm a total mantis development newb | 15:48 |
| JonMarkGo | But how does $_POST get pulled and filtered? | 15:48 |
| JonMarkGo | And how do you retrieve post data | 15:48 |
| JonMarkGo | gpc_get_string? | 15:48 |
| nuclear_eclipse | yeah, it's in core/gpc_api.php | 15:48 |
| nuclear_eclipse | as a rule of thumb, all of our API functions are in the form "x_func_name", and reside in core/x_api.php | 15:50 |
| JonMarkGo | Ok | 15:50 |
| *** Quits: rolfkleef (~rolfkleef@82-204-82-162.fttx.bbeyond.nl) (Ping timeout: 240 seconds) | 15:57 | |
| JonMarkGo | Testing it... | 15:59 |
| JonMarkGo | Hooray, it works on the mantis side | 16:00 |
| JonMarkGo | Sent you a pull request | 16:05 |
| nuclear_eclipse | thanks, I'll try to get to it sometime when I'm at home | 16:05 |
| JonMarkGo | Sure thing | 16:06 |
| JonMarkGo | I also added an api key field to the mantis bt service hook | 16:06 |
| JonMarkGo | And submitted a pull request | 16:06 |
| nuclear_eclipse | awesome :) | 16:06 |
| JonMarkGo | Sweet deal | 16:07 |
| JonMarkGo | If I go to http://mysite/bugs/plugin.php?page=Source/checkin&api_key=abc123&payload=github it pulls from github :P | 16:08 |
| nuclear_eclipse | how does it know which repo to pull from? | 16:08 |
| JonMarkGo | I actually sent a proper payload obj | 16:09 |
| JonMarkGo | But it didn't copy well | 16:10 |
| nuclear_eclipse | ok | 16:11 |
| JonMarkGo | None of the actual core code should be changed | 16:11 |
| JonMarkGo | All I did was add the api_key field and add a check to set $t_valid=true if the api key was correct | 16:11 |
| nuclear_eclipse | ok, so this should work for all repo types then if they pass that parameter? | 16:13 |
| JonMarkGo | Yup | 16:13 |
| JonMarkGo | ITs an override if your repo doesn't have a list of ips | 16:13 |
| nuclear_eclipse | excellent | 16:13 |
| JonMarkGo | If you add &api_key= to your generic url in github it should work too | 16:17 |
| *** Joins: spm-Draget (~quassel@ip-78-94-105-168.unitymediagroup.de) | 16:18 | |
| JonMarkGo | And it does for me with no remote IPs in the allow list | 16:19 |
| JonMarkGo | Hooray | 16:19 |
| spm-Draget | I am supposed to update a plain manthis 1.1.7 to latest stable, which would be 1.2.4. Anything I need to take care when updating? | 16:20 |
| nuclear_eclipse | spm-Draget: just make sure to backup your database and old installation, then follow the directions in your new tarball at doc/INSTALL | 16:20 |
| spm-Draget | I read the documentation on the website, it was only talking abotu new installs. I will check that doc and try it =) | 16:21 |
| JonMarkGo | spm-Draget - http://www.mantisbt.org/manual/manual.installation.upgrading.php | 16:23 |
| JonMarkGo | That helped me a bit | 16:23 |
| *** Joins: YiSh (~joanna@5ade2c24.bb.sky.com) | 16:23 | |
| *** Joins: rolfkleef (~rolfkleef@urtica.xs4all.nl) | 17:39 | |
| *** Quits: Cupertino (~Cupez@unaffiliated/cupertino) (Quit: I give up...) | 17:41 | |
| *** Joins: roentgen (~arthur@openvpn/community/support/roentgen) | 17:56 | |
| *** Quits: moto-moi (~hylke@2001:888:13e4:1010:21f:e2ff:fe0c:ce28) (Read error: Operation timed out) | 18:15 | |
| *** Joins: daryn_ (~daryn@h70.8.96.216.dynamic.ip.windstream.net) | 18:27 | |
| *** Quits: daryn (~daryn@h117.64.29.71.dynamic.ip.windstream.net) (Ping timeout: 276 seconds) | 18:31 | |
| *** Quits: YiSh (~joanna@5ade2c24.bb.sky.com) (Ping timeout: 255 seconds) | 18:39 | |
| *** Joins: daryn__ (~daryn@h139.152.16.98.dynamic.ip.windstream.net) | 18:40 | |
| *** Quits: daryn_ (~daryn@h70.8.96.216.dynamic.ip.windstream.net) (Ping timeout: 240 seconds) | 18:41 | |
| *** Quits: daryn__ (~daryn@h139.152.16.98.dynamic.ip.windstream.net) (Client Quit) | 18:44 | |
| *** Quits: scribe9343423 (~scribe934@static.96.23.63.178.clients.your-server.de) (Remote host closed the connection) | 19:00 | |
| *** Joins: scribe9343423 (~scribe934@static.96.23.63.178.clients.your-server.de) | 19:00 | |
| *** Quits: micahg (~micah@ubuntu/member/micahg) (Ping timeout: 260 seconds) | 19:27 | |
| *** Quits: rolfkleef (~rolfkleef@urtica.xs4all.nl) (Remote host closed the connection) | 20:55 | |
Generated by irclog2html.py 2.9.2 by Marius Gedminas - find it at mg.pov.lt!