| *** Quits: JonMarkGo (~Jon@ool-18bfe16f.dyn.optonline.net) (Ping timeout: 250 seconds) | 00:01 | |
| *** Joins: kirillka (~Miranda@195.242.142.17) | 01:06 | |
| *** Joins: mellen (~thansen@cl-289.cph-01.dk.sixxs.net) | 01:14 | |
| *** Quits: wolog (~wolog@wolog.info) (Quit: leaving) | 02:16 | |
| *** Joins: wolog (~wolog@wolog.info) | 02:18 | |
| *** Joins: Cupertino (~Cupez@unaffiliated/cupertino) | 02:32 | |
| *** Quits: giallu (~giallu@fedora/giallu) (Ping timeout: 252 seconds) | 02:39 | |
| *** Joins: soustruh (~Miranda@firewall.czech-tv.cz) | 02:53 | |
| *** Joins: giallu (~giallu@fedora/giallu) | 03:11 | |
| *** Joins: soc42 (~soc42@e181179110.adsl.alicedsl.de) | 03:12 | |
| *** Quits: mellen (~thansen@cl-289.cph-01.dk.sixxs.net) (Ping timeout: 248 seconds) | 03:18 | |
| *** Joins: mellen (~thansen@x1-6-00-22-02-00-0c-40.k1109.webspeed.dk) | 03:19 | |
| *** Joins: [KK]Kirill (~Miranda@195.242.142.17) | 03:35 | |
| *** Quits: kirillka (~Miranda@195.242.142.17) (Disconnected by services) | 03:36 | |
| *** [KK]Kirill is now known as kirillka | 03:36 | |
| *** Joins: paulr (~IceChat09@cpc1-enfi9-0-0-cust389.hari.cable.virginmedia.com) | 04:34 | |
| dhx1 | paulr: hi | 04:37 |
|---|---|---|
| paulr | lo | 04:39 |
| paulr | mm, dhx | 04:41 |
| paulr | how well you know sqlite? | 04:41 |
| dhx1 | paulr: nothing specific... just the general gist of what it does | 04:42 |
| dhx1 | paulr: have had no real need to use it before | 04:42 |
| *** Quits: mellen (~thansen@x1-6-00-22-02-00-0c-40.k1109.webspeed.dk) (Ping timeout: 260 seconds) | 04:55 | |
| *** Joins: mellen (~thansen@cl-289.cph-01.dk.sixxs.net) | 05:08 | |
| paulr | dhx: mm | 05:11 |
| paulr | :) | 05:11 |
| *** Quits: mellen (~thansen@cl-289.cph-01.dk.sixxs.net) (Ping timeout: 248 seconds) | 05:13 | |
| paulr | this is tedious ;/ | 05:14 |
| paulr | CREATE TABLE IF NOT EXISTS `mantis_tag_table` ( | 05:23 |
| paulr | `id` INTEGER UNSIGNED NOT NULL AUTOINCREMENT , | 05:23 |
| paulr | `user_id` INTEGER UNSIGNED NOT NULL DEFAULT '0' , | 05:23 |
| paulr | `name` VARCHAR(100) NOT NULL DEFAULT '' , | 05:23 |
| paulr | `description` LONGTEXT NOT NULL , | 05:23 |
| paulr | `date_created` INTEGER UNSIGNED NOT NULL DEFAULT '1' , | 05:23 |
| paulr | `date_updated` INTEGER UNSIGNED NOT NULL DEFAULT '1' , | 05:23 |
| paulr | PRIMARY KEY (`id`, `name`) ) | 05:23 |
| *** Joins: Phileas1 (~chatzilla@vpn.rzz.ch) | 05:28 | |
| paulr | why primary key on id, name?? | 05:30 |
| dhx1 | haha | 05:30 |
| dhx1 | that is wrong | 05:30 |
| *** Joins: mellen (~thansen@x1-6-00-22-02-00-0c-40.k1109.webspeed.dk) | 05:32 | |
| paulr | hmm | 05:32 |
| paulr | what default values do you have on config table | 05:32 |
| paulr | access_reqd I DEFAULT '0', | 05:33 |
| paulr | 46 type I DEFAULT '90', | 05:33 |
| paulr | shouldn't that be 90 / 0 | 05:33 |
| paulr | not 0 /90 :) | 05:33 |
| dhx1 | I'm not sure of the context there | 05:34 |
| paulr | wow | 05:57 |
| paulr | this is gonna be annoying | 05:57 |
| paulr | can't rely on if( 0 == db_num_rows( $result ) ) | 05:58 |
| dhx1 | paulr: if I wanted to help with some coding... is there anything I can do? :) | 06:01 |
| dhx1 | paulr: it seems that if I was to touch anything it'd break all your work :) | 06:01 |
| paulr | i pushed branch to github last night | 06:02 |
| dhx1 | paulr: I'll have a look then :) | 06:02 |
| paulr | Your browser either does not know how to handle cookies, or refuses to handle them. | 06:03 |
| paulr | what db query failing would cause thaT? :P | 06:03 |
| dhx1 | paulr: can I rewrite some queries? | 06:03 |
| dhx1 | paulr: SQL standard as opposed to MySQL crap | 06:03 |
| paulr | i thought ours were standard ;p | 06:04 |
| dhx1 | far from | 06:04 |
| paulr | I thought they were all select * from table ;p0 | 06:05 |
| dhx1 | I assume there is some sort of code to handle query conversion/translation (or search/replace)? | 06:05 |
| dhx1 | or would I need to look at that too? | 06:05 |
| paulr | the pdo layer is quite light | 06:05 |
| dhx1 | yeah those are the same... it's more for ORDER BY, GROUP BY, etc clauses | 06:05 |
| paulr | i'd take a difficult db | 06:05 |
| paulr | that you'd expect to play up ;p | 06:05 |
| paulr | For most databases, PDOStatement::rowCount() does not return the number of rows affected by a SELECT statement. Instead, use PDO::query() to issue a SELECT COUNT(*) statement with the same predicates as your intended SELECT statement, then use PDOStatement::fetchColumn() to retrieve the number of rows that will be returned. Your application | 06:05 |
| dhx1 | IMO the best approach is to use an approach similar to string translations | 06:05 |
| dhx1 | so we can rewrite queries on a per-database-backend approach where necessary | 06:06 |
| dhx1 | it would be the fastest, easiest and most accurate approach | 06:06 |
| dhx1 | at the cost of needing to test against each database backend we support... which we should do anyway | 06:06 |
| paulr | --------------------------- | 06:07 |
| paulr | Find | 06:07 |
| paulr | --------------------------- | 06:07 |
| paulr | Can't find the text: | 06:07 |
| paulr | "cookie" | 06:07 |
| paulr | --------------------------- | 06:07 |
| paulr | OK | 06:07 |
| paulr | --------------------------- | 06:07 |
| paulr | oops | 06:07 |
| dhx1 | paulr: COUNT(*) is the only approach we should use... it has to do with asynchronous vs synchronous query methods | 06:07 |
| paulr | # return true if a matching cookie was found | 06:07 |
| paulr | how evil: | 06:07 |
| paulr | # return true if a matching cookie was found | 06:07 |
| paulr | $row = db_fetch_array( $result ); | 06:07 |
| paulr | if( !db_fetch_array( $result ) ) { | 06:07 |
| paulr | user_cache_database_result( $row ); | 06:07 |
| paulr | return true; | 06:07 |
| * paulr wonders if that pasted | 06:07 | |
| paulr | ] <paulr> --------------------------- | 06:08 |
| paulr | [11:07.16] <p | 06:08 |
| paulr | # return true if a matching cookie was found | 06:08 |
| * paulr gives up | 06:08 | |
| paulr | # return true if a matching cookie was found | 06:08 |
| paulr | [11:08.32] $row :Unknown command | 06:08 |
| paulr | cool | 06:08 |
| paulr | anyway | 06:08 |
| paulr | dehx: what ydo you think of the change I just pushed? | 06:22 |
| dhx1 | checking | 06:23 |
| *** Joins: Github (~Github@sh1-ext.rs.github.com) | 06:30 | |
| Github | mantisbt: master Stefan Pettersson * acf78fa (8 files in 2 dirs): Use CSS classes instead of bgcolor to apply different status styles ... - http://bit.ly/gPjnKE | 06:30 |
| *** Parts: Github (~Github@sh1-ext.rs.github.com) () | 06:30 | |
| CIA-35 | Mantisbt: stefpet * racf78fa5d9d8 / (8 files in 2 dirs): Use CSS classes instead of bgcolor to apply different status styles | 06:30 |
| paulr | that doens't look like checking :( | 06:33 |
| *** Quits: giallu (~giallu@fedora/giallu) (Ping timeout: 246 seconds) | 06:34 | |
| dhx1 | was half way through doing it | 06:35 |
| dhx1 | Undefined variable: t_driver_type | 06:35 |
| dhx1 | Filename: MantisDatabase.class.php | 06:35 |
| *** Joins: giallu (~giallu@fedora/giallu) | 06:35 | |
| dhx1 | Line: 95 | 06:35 |
| dhx1 | /var/www/localhost/htdocs/mantis-git/core/database_api.php72MantisDatabase::get_driver_instance( <string>'mysql' ) | 06:35 |
| dhx1 | do I have to update configuration? | 06:35 |
| paulr | yea | 06:36 |
| paulr | for now pdo_mysql | 06:36 |
| dhx1 | ah | 06:37 |
| dhx1 | E_ERRORCall to undefined function db_query() | 06:37 |
| dhx1 | 06:37 | |
| dhx1 | Filename: custom_field_api.php | 06:37 |
| dhx1 | 06:37 | |
| dhx1 | 06:37 | |
| dhx1 | Line: 1262 | 06:37 |
| dhx1 | the stack trace also seems broken now? | 06:38 |
| paulr | in what way? | 06:38 |
| dhx1 | it doesn't show for that error (it's blank) | 06:38 |
| dhx1 | I get the headings: | 06:38 |
| dhx1 | FilenameLineFunctionArgs | 06:38 |
| dhx1 | and the page contents dump | 06:38 |
| dhx1 | no menu showing | 06:39 |
| paulr | menu = correct | 06:39 |
| paulr | as, atm, it's avoiding html api | 06:39 |
| paulr | completely | 06:39 |
| dhx1 | it's probably easier if I fix these bugs and push a branch to github for you | 06:40 |
| paulr | can you edit my branch? | 06:40 |
| *** Joins: rolfkleef (~rolfkleef@92.254.21.180) | 06:40 | |
| paulr | i'm a bit confused as to why you get no stack trace | 06:41 |
| paulr | in fact, I know ;p | 06:41 |
| paulr | set: | 06:41 |
| paulr | $g_show_friendly_errors = OFF; | 06:41 |
| paulr | in config inc | 06:41 |
| dhx1 | ah | 06:41 |
| dhx1 | I was using the old config :) | 06:41 |
| paulr | although, I dont get the headings | 06:42 |
| * paulr checks error api | 06:42 | |
| paulr | yea, not sure why you get filename headers ;/ | 06:44 |
| paulr | you should either get: | 06:44 |
| paulr | a) application error, text, ID:user_api:397 | 06:44 |
| paulr | or | 06:44 |
| paulr | b) full dump | 06:44 |
| paulr | idea being option A is for users, and has a line number to give someone a clue or where bug occurs | 06:45 |
| paulr | option B is for dev's working on some issue | 06:45 |
| dhx1 | can we split the error page into a "template" that is included? | 06:45 |
| dhx1 | ie. another PHP file that is mostly HTML with a few <?php if $t_blah ... ?> etc clauses | 06:46 |
| paulr | surprising that's the plan ;p | 06:46 |
| paulr | i.e. i'd like error page to be just that | 06:47 |
| paulr | an unseen error page | 06:47 |
| paulr | therefore, can look **different** | 06:47 |
| dhx1 | yeah | 06:47 |
| paulr | and then rather then having horrendous loops where we have | 06:47 |
| paulr | I mean, I had the old error code | 06:48 |
| paulr | falling over in html_top1 | 06:48 |
| paulr | as that calls config_get | 06:48 |
| paulr | which calls db api | 06:48 |
| paulr | and I hadn't got as far as writing db_table_Exists for pdo | 06:48 |
| paulr | I think I might have nuked some of the CSS that daryn added to error api though with this | 06:49 |
| dhx1 | never mind, it'll get rewritten 10 times :D | 06:51 |
| dhx1 | you've done the hard work though hah | 06:51 |
| dhx1 | (ie. refactoring the old code) | 06:52 |
| *** Quits: mellen (~thansen@x1-6-00-22-02-00-0c-40.k1109.webspeed.dk) (Ping timeout: 248 seconds) | 06:55 | |
| paulr | dhx: can you fix http://127.0.0.1/view_all_set.php?type=1&temporary=y&handler_id=1&hide_status=80 ? | 07:04 |
| dhx1 | let me see | 07:04 |
| dhx1 | yes, change: | 07:06 |
| dhx1 | html_meta_redirect( $t_redirect_url, 0 ); | 07:06 |
| dhx1 | to | 07:06 |
| dhx1 | print_header_redirect( $t_redirect_url ); | 07:06 |
| dhx1 | hang on, I'll commit a cleaner patch | 07:07 |
| dhx1 | brb | 07:12 |
| *** Quits: dhx1 (~anonymous@60-242-108-164.static.tpgi.com.au) (Remote host closed the connection) | 07:13 | |
| paulr | right going to go for a swim | 07:13 |
| paulr | i'll | 07:13 |
| paulr | fdsk | 07:13 |
| paulr | ajksldjsak | 07:13 |
| *** Joins: dhx1 (~anonymous@60-242-108-164.static.tpgi.com.au) | 07:14 | |
| paulr | [12:13.17] <paulr> right going to go for a swim | 07:15 |
| paulr | [12:13.19] <paulr> i'll | 07:15 |
| paulr | [12:13.20] <paulr> fdsk | 07:15 |
| paulr | [12:13.21] <paulr> ajksldjsak | 07:15 |
| paulr | continue later on tonight | 07:15 |
| dhx1 | I'll push a branch called "dbfixes" to Github with my commits | 07:16 |
| paulr | we may/maynot cros | 07:16 |
| paulr | hmm | 07:16 |
| dhx1 | you can merge those across quite easily | 07:16 |
| paulr | just leave instructions for what to do with it | 07:16 |
| paulr | ! | 07:16 |
| dhx1 | just do: | 07:16 |
| dhx1 | ok | 07:16 |
| paulr | bbiab | 07:16 |
| dhx1 | paulr: I can just send a pull request and you should be able to merge it via github | 07:18 |
| *** Quits: Phileas1 (~chatzilla@vpn.rzz.ch) (Quit: ChatZilla 0.9.86.1 [Firefox 3.6.16/20110319135224]) | 07:35 | |
| *** Quits: giallu (~giallu@fedora/giallu) (*.net *.split) | 07:58 | |
| *** Quits: scribe9343423 (~scribe934@static.96.23.63.178.clients.your-server.de) (*.net *.split) | 07:58 | |
| *** Quits: siebrand (~chatzilla@535392CA.cm-6-4c.dynamic.ziggo.nl) (*.net *.split) | 07:58 | |
| *** Quits: rolfkleef (~rolfkleef@92.254.21.180) (*.net *.split) | 07:58 | |
| *** Quits: killefiz (~sven@fedora/pdpc.base.killefiz) (*.net *.split) | 07:58 | |
| *** Quits: Cupertino (~Cupez@unaffiliated/cupertino) (*.net *.split) | 07:58 | |
| *** Quits: chilts (~chilts@184-106-200-232.static.cloud-ips.com) (*.net *.split) | 07:58 | |
| *** Quits: dhx1 (~anonymous@60-242-108-164.static.tpgi.com.au) (*.net *.split) | 07:58 | |
| *** Quits: deepy (~deepy@wrongplanet/deepa) (*.net *.split) | 07:58 | |
| *** Quits: paulr (~IceChat09@cpc1-enfi9-0-0-cust389.hari.cable.virginmedia.com) (*.net *.split) | 07:58 | |
| *** Quits: CIA-35 (~CIA@208.69.182.149) (*.net *.split) | 07:58 | |
| *** Quits: soustruh (~Miranda@firewall.czech-tv.cz) (*.net *.split) | 07:58 | |
| *** Quits: chris38` (~chris38@bayle.eu) (*.net *.split) | 07:58 | |
| *** Quits: wolog (~wolog@wolog.info) (*.net *.split) | 07:58 | |
| *** Quits: `Leonard (~Leonard@150.237.48.99) (*.net *.split) | 07:58 | |
| *** Quits: PennStater (Aaron@unaffiliated/pennstater) (*.net *.split) | 07:58 | |
| *** Quits: kirillka (~Miranda@195.242.142.17) (*.net *.split) | 07:58 | |
| *** Quits: soc42 (~soc42@e181179110.adsl.alicedsl.de) (*.net *.split) | 07:58 | |
| *** Joins: dhx1 (~anonymous@60-242-108-164.static.tpgi.com.au) | 08:01 | |
| *** Joins: rolfkleef (~rolfkleef@92.254.21.180) | 08:01 | |
| *** Joins: giallu (~giallu@fedora/giallu) | 08:01 | |
| *** Joins: paulr (~IceChat09@cpc1-enfi9-0-0-cust389.hari.cable.virginmedia.com) | 08:01 | |
| *** Joins: kirillka (~Miranda@195.242.142.17) | 08:01 | |
| *** Joins: soustruh (~Miranda@firewall.czech-tv.cz) | 08:01 | |
| *** Joins: Cupertino (~Cupez@unaffiliated/cupertino) | 08:01 | |
| *** Joins: wolog (~wolog@wolog.info) | 08:01 | |
| *** Joins: scribe9343423 (~scribe934@static.96.23.63.178.clients.your-server.de) | 08:01 | |
| *** Joins: `Leonard (~Leonard@150.237.48.99) | 08:01 | |
| *** Joins: siebrand (~chatzilla@535392CA.cm-6-4c.dynamic.ziggo.nl) | 08:01 | |
| *** Joins: CIA-35 (~CIA@208.69.182.149) | 08:01 | |
| *** Joins: deepy (~deepy@wrongplanet/deepa) | 08:01 | |
| *** Joins: killefiz (~sven@fedora/pdpc.base.killefiz) | 08:01 | |
| *** Joins: chilts (~chilts@184-106-200-232.static.cloud-ips.com) | 08:01 | |
| *** Joins: PennStater (Aaron@unaffiliated/pennstater) | 08:01 | |
| *** Joins: chris38` (~chris38@bayle.eu) | 08:01 | |
| dhx1 | jreese: hi :) | 08:34 |
| jreese | Howdy | 08:35 |
| jreese | Just about to head to work | 08:35 |
| dhx1 | jreese: Paul's DB branch seems to work nicely without ADOdb.... tested with MySQL only though | 08:35 |
| dhx1 | and haven't tested upgrades | 08:36 |
| dhx1 | jreese: ah ok :) | 08:36 |
| dhx1 | jreese: keep a look out on github for the latest MantisBT work | 08:36 |
| jreese | dhx1: if upgrades still work well, then its fine with me, but without upgrades, IMO its not ready for master branch | 08:37 |
| dhx1 | jreese: still some work to do... but it's better than I was expecting :) | 08:37 |
| jreese | Todd to hear | 08:38 |
| jreese | Good even | 08:38 |
| dhx1 | :) | 08:38 |
| jreese | Can you tell I'm on my phone? :P | 08:38 |
| dhx1 | haha | 08:39 |
| dhx1 | jreese: any idea how to change the reference branch a branch on github refers to? | 08:39 |
| dhx1 | for instance, I have a local tracking branch of Paul's db branch | 08:39 |
| dhx1 | then I push that branch to my github repository | 08:40 |
| dhx1 | and Github thinks that the reference is mantisbt/mantisbt instead of grangeway/mantisbt/db | 08:40 |
| jreese | That I have no idea | 08:40 |
| dhx1 | jreese: no problem, I'll look around :) | 08:41 |
| jreese | Ok, ill be. Back in about 20 mins | 08:41 |
| dhx1 | later | 08:42 |
| *** Joins: mantisbt_74396 (3e995de2@gateway/web/freenode/ip.62.153.93.226) | 08:44 | |
| mantisbt_74396 | :) | 08:44 |
| *** Parts: mantisbt_74396 (3e995de2@gateway/web/freenode/ip.62.153.93.226) () | 08:46 | |
| *** Joins: daryn (~daryn@h158.249.190.173.static.ip.windstream.net) | 08:52 | |
| dhx1 | daryn: hey | 08:54 |
| daryn | hello | 08:54 |
| dhx1 | https://github.com/davidhicks/mantisbt/tree/dbfixes | 08:55 |
| dhx1 | I've asked Paul to pull those fixes into his db branch | 08:55 |
| dhx1 | with those, all the MantisBT functionality I've tested (which is a fair portion) seems to work OK | 08:55 |
| daryn | ok, i'm reviewing as well and have some changes. actually quite a few. mostly moving things around and removing dependencies, self or otherwise | 08:56 |
| daryn | i'll take a look at yours | 08:56 |
| daryn | dhx1, i have quite a significant 2.0 (or whatever) branch going. it isn't quite working yet but i'm going to try to starting pushing some stuff to github today so people can start taking a look | 08:58 |
| dhx1 | daryn: sounds good :) | 08:58 |
| dhx1 | daryn: we're going to have so much fun merging though :P | 08:58 |
| daryn | there will be additional refactoring where the branch will be rewritten but i'd rather get eyes on soon | 08:58 |
| dhx1 | daryn: basically I think we'll all need to decide on what is good/what is not | 08:59 |
| daryn | what are you working on? | 08:59 |
| *** Joins: soc42 (~soc42@e181179110.adsl.alicedsl.de) | 08:59 | |
| dhx1 | and then give each person a few days to merge their branches one at a time - from scratch because there will be so many merge conflicts | 08:59 |
| dhx1 | daryn: was just doing some reviewing/bugfixing | 09:00 |
| daryn | i have most of paulrs changes already in my branch | 09:00 |
| daryn | just moved | 09:00 |
| dhx1 | daryn: great :) | 09:00 |
| daryn | and using camel case in class function names rather than _ | 09:00 |
| dhx1 | I'd prefer if you kept the "master" development branch and pulled in branches from me/paul | 09:00 |
| daryn | well that will probably make it easier for me anyway | 09:01 |
| dhx1 | you seem to have the largest amount of changes :) | 09:02 |
| dhx1 | namely directory restructuring | 09:02 |
| daryn | yeah...well, much more than that actually but yeah. | 09:02 |
| daryn | hm... | 09:03 |
| daryn | you know i think i'm just going to make a temp commit and push so you can see what i've got | 09:03 |
| daryn | and start commenting | 09:03 |
| dhx1 | :) | 09:04 |
| dhx1 | GitHub makes it easy to make a few patches and send a pull request back :) | 09:04 |
| daryn | there is still a good bit of reworking and 'unifying' to do as i'm learning as i go and correcting things | 09:05 |
| dhx1 | FYI error_api's look and feel is screwed in Paul's branch | 09:06 |
| dhx1 | I'm happy to work on that using the new directory layout | 09:06 |
| daryn | yeah, i told him i had some issues with it but haven't fully reviewed it yet | 09:06 |
| dhx1 | I really want to try and push towards putting the HTML for that in a separate file we can include | 09:06 |
| daryn | yes | 09:06 |
| dhx1 | at least it is now decoupled from a lot of unwanted MantisBT code | 09:06 |
| daryn | yeah...partially anyway | 09:07 |
| dhx1 | yeah... we can make it better still :) | 09:07 |
| * jreese is back now | 09:11 | |
| jreese | 20 minutes turned into 30 due to torrential rain | 09:11 |
| dhx1 | :) | 09:13 |
| daryn | dhx1, jreese, giallu https://github.com/daryn/mantisbt/tree/refactor/application | 09:27 |
| daryn | it is broken and in progress so there is stuff that doesn't belong, stuff that will change, etc. | 09:27 |
| daryn | but I think you can see where I'm heading | 09:28 |
| jreese | I'll try to look at that sometime today | 09:29 |
| giallu | yo | 09:29 |
| daryn | k. most of it is in application/MantisBT | 09:29 |
| daryn | hi giallu | 09:29 |
| daryn | no template class in yet because i haven't gotten to that yet but i have that part in another branch | 09:30 |
| dhx1 | daryn: thanks, will take a look | 09:31 |
| dhx1 | giallu: hi | 09:31 |
| daryn | looking forward to comments | 09:32 |
| daryn | btw, you can get to any existing page directly. index.php is rerouting to the new application but you can login by going to login_page.php | 09:33 |
| dhx1 | :) | 09:34 |
| giallu | daryn, can we kill *.class.php files? ;) | 09:35 |
| daryn | i don't care... | 09:35 |
| daryn | that's just been the standard so i kept it | 09:36 |
| daryn | i'd be happy to use .php | 09:36 |
| daryn | jreese? dhx1? paulr? | 09:36 |
| dhx1 | agreed, drop .class.php | 09:37 |
| jreese | doesn't much matter to me | 09:37 |
| dhx1 | it can be inferred from the directory structure :) | 09:37 |
| dhx1 | do we need core/classes/MantisBT/ | 09:37 |
| dhx1 | instead of just core/ | 09:38 |
| dhx1 | I'm not sure what the Zend standard is though | 09:38 |
| dhx1 | also can I suggest we drop the old variable naming scheme | 09:38 |
| dhx1 | $t, $p, $f, etc | 09:39 |
| daryn | all of the legacy stuff is in core | 09:39 |
| daryn | I'm adding no new stuff there | 09:39 |
| dhx1 | application/core I see | 09:39 |
| daryn | core will go away completely when the rest of the app is converted | 09:39 |
| daryn | we could name core legacy I guess | 09:39 |
| daryn | to be more clear | 09:40 |
| dhx1 | core/ seems like the new stuff and application/core/ the old? | 09:40 |
| daryn | oh, crap | 09:40 |
| jreese | zounds! today is the launch of Portal 2! | 09:40 |
| daryn | ignore core | 09:40 |
| jreese | I should have called in sick! | 09:40 |
| dhx1 | ah ok | 09:40 |
| daryn | application/core is correct legacy | 09:40 |
| dhx1 | jreese: haha | 09:40 |
| jreese | and I already told my brother-in-law I'd help install his new printer after work today.... | 09:41 |
| * jreese cries | 09:41 | |
| daryn | well that's like 5 minutes... | 09:42 |
| jreese | hahahahahaha | 09:42 |
| jreese | I wish | 09:42 |
| dhx1 | daryn: it's probably Windows with legacy HP drivers... :P | 09:42 |
| jreese | I'll have to stop at the store during lunch or on my way home... | 09:43 |
| dhx1 | :) | 09:46 |
| *** Joins: fusenigk (~Karsten@p4FFC9F50.dip.t-dialin.net) | 09:51 | |
| daryn | giallu, dhx1, .class is gone. history rewritten | 09:52 |
| daryn | only for new classes though. | 09:52 |
| giallu | right | 09:52 |
| dhx1 | :) | 09:52 |
| dhx1 | daryn: wow... I didn't realise you had reworked so much of the API... nice work! | 09:53 |
| daryn | well when you start dependency injection it 'propogates violently to the root objects' | 09:54 |
| daryn | thanks | 09:54 |
| daryn | there are pieces in multiple places so if you see dupe code it will be removed as i work out where it belongs | 09:54 |
| dhx1 | yep | 09:56 |
| *** Quits: kirillka (~Miranda@195.242.142.17) (Quit: kirillka) | 10:02 | |
| *** Joins: jreese_ (~jreese@noswap.com) | 10:13 | |
| *** Quits: jreese (~jreese@noswap.com) (Disconnected by services) | 10:13 | |
| *** jreese_ is now known as jreese | 10:13 | |
| *** Joins: JonMarkGo (~Jon@ool-18bfe16f.dyn.optonline.net) | 10:24 | |
| paulr | moo | 10:30 |
| paulr | has dhx gone? | 10:30 |
| paulr | daryn? | 10:32 |
| daryn | ya | 10:33 |
| paulr | i have a pull request from dx | 10:33 |
| paulr | a) what do I do | 10:34 |
| paulr | b) how do I fix the conflicts in it ? :P | 10:34 |
| daryn | pull will merge and tell you what the conflicts are...then you fix them and commit | 10:37 |
| paulr | hmm | 10:39 |
| *** Joins: soc42_ (~soc42@f052057114.adsl.alicedsl.de) | 10:41 | |
| paulr | ok | 10:41 |
| paulr | I dont get it | 10:42 |
| paulr | but i'll assume it's fine | 10:42 |
| daryn | don't get what? | 10:42 |
| paulr | well, looking at patch | 10:42 |
| paulr | it should conflict | 10:42 |
| paulr | but it does't | 10:42 |
| paulr | anyway | 10:42 |
| paulr | git push origin db | 10:42 |
| *** Quits: soc42 (~soc42@e181179110.adsl.alicedsl.de) (Ping timeout: 246 seconds) | 10:42 | |
| paulr | I do that at end? | 10:42 |
| paulr | or will that update git.mantisbt.org? | 10:42 |
| daryn | origin will update mantisbt.org | 10:42 |
| jreese | depends on what origin is | 10:42 |
| daryn | git is pretty smart so i'm not too surprised it doesn't conflict | 10:43 |
| paulr | so git push github db:Db right? | 10:43 |
| daryn | yah | 10:43 |
| paulr | shame github dont give out the correct help ;p | 10:43 |
| daryn | well if the local branch name is the same as remote you can probably just git push github | 10:44 |
| paulr | [01:37.50] <dhx1> jreese: still some work to do... but it's better than I was expecting :) | 10:44 |
| jreese | github assumes you've cloned from them, which is why I said it depends on what origin is | 10:44 |
| paulr | and what was that suppsoed to mean | 10:44 |
| paulr | http://git.mantisbt.org/?p=mantisbt.git;a=commitdiff;h=9c64d885ce30699e26641ea60eb15239487dc3ab | 10:46 |
| paulr | ahh john | 10:46 |
| paulr | does your secure seession support hit db in some way? | 10:46 |
| jreese | csrf protection uses the database, yes | 10:47 |
| paulr | via what api | 10:47 |
| jreese | or at least iirc | 10:47 |
| paulr | hmm, dhx's patch broke something | 10:47 |
| jreese | nvm, csrf should only be using php sessions | 10:48 |
| paulr | it keeps wanting me to log in when i'm trying to use sqlite ;p | 10:49 |
| paulr | You are visiting a secure page, and your secure session has expired. Please authenticate yourself to continue. | 10:49 |
| paulr | so some db query isn't working I'm guessing ;p | 10:49 |
| jreese | sounds more like php sessions aren't storing correctly | 10:50 |
| paulr | it was fine with mysql | 10:50 |
| jreese | oh | 10:50 |
| jreese | you're visiting an admin page | 10:50 |
| jreese | *that* uses the token_api, which does hit the database... | 10:50 |
| jreese | too many different ways that mantis stores temporary data | 10:51 |
| paulr | did i mention i'm not in work this week ? | 10:52 |
| paulr | anyway, we can't really rely on a row count from select queries officially | 10:55 |
| *** Quits: Cupertino (~Cupez@unaffiliated/cupertino) (Quit: I give up...) | 11:02 | |
| paulr | how well did giallu's import/export model work? | 11:25 |
| paulr | if(( $t_row['user_id'] == $t_user_id ) || db_prepare_bool( $t_row['is_public'] ) ) { | 11:28 |
| paulr | w | 11:28 |
| paulr | t | 11:28 |
| paulr | f | 11:28 |
| *** Quits: giallu (~giallu@fedora/giallu) (Ping timeout: 260 seconds) | 11:35 | |
| *** Joins: tmckeown (~Adium@64.191.211.43) | 12:09 | |
| *** Parts: tmckeown (~Adium@64.191.211.43) () | 12:11 | |
| *** Quits: soustruh (~Miranda@firewall.czech-tv.cz) (Quit: visit http://wormscesky.cz) | 12:57 | |
| *** Quits: rolfkleef (~rolfkleef@92.254.21.180) (Ping timeout: 240 seconds) | 13:05 | |
| *** Quits: soc42_ (~soc42@f052057114.adsl.alicedsl.de) (Remote host closed the connection) | 14:20 | |
| *** Joins: giallu (~giallu@fedora/giallu) | 14:36 | |
| *** Joins: mellen (~thansen@x1-6-00-22-02-00-0c-40.k1109.webspeed.dk) | 14:47 | |
| *** Quits: mellen (~thansen@x1-6-00-22-02-00-0c-40.k1109.webspeed.dk) (Ping timeout: 248 seconds) | 15:02 | |
| *** Joins: mellen (~thansen@cl-289.cph-01.dk.sixxs.net) | 15:03 | |
| *** Joins: soc42 (~soc42@f052057114.adsl.alicedsl.de) | 15:18 | |
| * paulr sighs | 15:26 | |
| *** Parts: fusenigk (~Karsten@p4FFC9F50.dip.t-dialin.net) () | 16:12 | |
| *** Quits: soc42 (~soc42@f052057114.adsl.alicedsl.de) (Remote host closed the connection) | 16:25 | |
| *** Joins: fusenigk (~Karsten@p4FFC9F50.dip.t-dialin.net) | 16:27 | |
| paulr | new push | 16:54 |
| daryn | paulr, what changes? | 16:57 |
| paulr | see github | 16:57 |
| daryn | blah! summary...i'm working :P | 16:57 |
| paulr | db_num_rows removed a bit | 16:58 |
| paulr | so every file :) | 16:59 |
| paulr | & in urls should be & right? | 17:01 |
| daryn | yeah | 17:02 |
| *** Quits: fusenigk (~Karsten@p4FFC9F50.dip.t-dialin.net) (Quit: fusenigk) | 17:04 | |
| *** Quits: daryn (~daryn@h158.249.190.173.static.ip.windstream.net) (Quit: Ex-Chat) | 17:45 | |
| *** Quits: siebrand (~chatzilla@535392CA.cm-6-4c.dynamic.ziggo.nl) (Quit: ChatZilla 0.9.86.1 [Firefox 4.0/20110318052756]) | 18:11 | |
| paulr | john? | 18:15 |
| paulr | jreese :) | 18:18 |
| *** Quits: JonMarkGo (~Jon@ool-18bfe16f.dyn.optonline.net) (Ping timeout: 246 seconds) | 18:39 | |
| paulr | $t_query = '?' . join( '&', $t_clean_pairs ); | 18:43 |
| paulr | should that be & ? :P | 18:43 |
| paulr | or are we doing that conversion in a different function ;p | 18:44 |
| jreese | paulr: it all depends on where it's going and how it's being used | 18:44 |
| paulr | permalink.php currently does: | 18:44 |
| paulr | $f_url = string_sanitize_url( gpc_get_string( 'url' ) ); | 18:44 |
| paulr | $t_safe_url = string_display_line( $f_url ); | 18:44 |
| paulr | $t_safe_url = string_display_line( $f_url ); | 18:45 |
| paulr | echo "<a href=\"$t_safe_url\">$t_safe_url</a></p>"; | 18:45 |
| jreese | so in that case its string_display_line that should be somehow converting & to & -- not string_sanitize_url | 18:45 |
| paulr | well | 18:46 |
| paulr | it's not really stringdisplay line's job | 18:46 |
| jreese | it should be | 18:46 |
| paulr | surely you'd have to parse the url to work out whether & needs replacing? | 18:46 |
| paulr | e.g. $t_safe_url doesn't need to show & for the 2nd one | 18:46 |
| paulr | just for the first ;p | 18:46 |
| jreese | well, yes | 18:47 |
| paulr | can we blanket replace &->& | 18:47 |
| jreese | no | 18:47 |
| paulr | in a url? why not? :) | 18:47 |
| jreese | this is why I hate web apps | 18:47 |
| paulr | ;p | 18:47 |
| jreese | <a href="?a=b&c=d">?a=b&c=d</a> | 18:48 |
| jreese | that's the correct output | 18:48 |
| paulr | erm | 18:48 |
| paulr | isn't it other way around? | 18:48 |
| jreese | no | 18:48 |
| paulr | I thought <a href needed to include & | 18:48 |
| jreese | no | 18:48 |
| jreese | only if the actual *data* includes an & in it | 18:48 |
| jreese | although iirc that shouldn't be & it should be a %xx | 18:49 |
| jreese | or something like that | 18:49 |
| jreese | this is why I hate web apps | 18:49 |
| paulr | hmm | 18:57 |
| paulr | how do i nuke the last commit I did to git | 18:57 |
| paulr | i've not pushed it | 18:58 |
| jreese | `git reset HEAD~1` will drop the commit while leaving the files the way they were; `git reset --hard HEAD~1` will also revert all your files at the same time | 18:58 |
| paulr | oops | 18:59 |
| paulr | i'm confused | 18:59 |
| paulr | ahh it might be alright | 19:00 |
| *** Quits: scribe9343423 (~scribe934@static.96.23.63.178.clients.your-server.de) (Remote host closed the connection) | 20:00 | |
| *** Joins: scribe9343423 (~scribe934@static.96.23.63.178.clients.your-server.de) | 20:00 | |
| *** Quits: paulr (~IceChat09@cpc1-enfi9-0-0-cust389.hari.cable.virginmedia.com) (Quit: Oops. My brain just hit a bad sector) | 20:11 | |
| *** Quits: deepy (~deepy@wrongplanet/deepa) (Ping timeout: 276 seconds) | 20:59 | |
| *** Joins: deepy (~deepy@c83-248-154-79.bredband.comhem.se) | 21:06 | |
Generated by irclog2html.py 2.9.2 by Marius Gedminas - find it at mg.pov.lt!