*** Quits: micahg (~micahg@ubuntu/member/micahg) (Ping timeout: 252 seconds) | 00:44 | |
*** Joins: micahg (~micahg@ubuntu/member/micahg) | 00:46 | |
*** Joins: Cupertino (~Cupez@62-177-158-122.dsl.bbeyond.nl) | 02:38 | |
*** Quits: Cupertino (~Cupez@62-177-158-122.dsl.bbeyond.nl) (Changing host) | 02:38 | |
*** Joins: Cupertino (~Cupez@unaffiliated/cupertino) | 02:38 | |
*** Joins: soustruh (~Miranda@169.211.broadband13.iol.cz) | 02:54 | |
*** Joins: asm89 (~asm89@unaffiliated/asm89) | 02:54 | |
asm89 | aha! | 03:01 |
---|---|---|
asm89 | how's my favorite bug tracker doing? | 03:01 |
*** Quits: Cesare (~Adium@creati59.lnk.telstra.net) (Quit: Leaving.) | 04:01 | |
dhx1 | asm89: hey | 04:03 |
*** Joins: siebrand (~siebrand@80.179.214.170.cable.012.net.il) | 04:14 | |
*** Joins: Paul_ (~IceChat09@2001:470:9310:aaaa:2dfd:753c:c6f9:2651) | 04:35 | |
Paul_ | moo | 04:35 |
dhx1 | Paul_: hey | 04:53 |
Paul_ | lo | 04:55 |
Paul_ | I've broken my local branch completely atm ;/ | 04:56 |
Paul_ | it wont let me login :( | 04:56 |
Paul_ | dhx1: also, was thinking | 04:56 |
Paul_ | you said | 04:56 |
Paul_ | your version of exceptions had http error codes in? | 04:56 |
dhx1 | yes | 04:56 |
dhx1 | hah @ breaking | 04:56 |
Paul_ | that strikes me as wrong | 04:56 |
Paul_ | I make a request to mantis, to add a bug via email, it throws an exception | 04:57 |
dhx1 | no no, only for HTTP requests | 05:00 |
dhx1 | we shouldn't be returning HTTP output for SOAP/etc requests | 05:00 |
Paul_ | what I mean is surely the exception shouldn't pick the http return code | 05:01 |
Paul_ | but more indicate the type of exception | 05:01 |
dhx1 | access denied, server error, client error | 05:03 |
dhx1 | client error for invalid input | 05:04 |
dhx1 | server error for invalid server config, etc | 05:04 |
dhx1 | access denied for requests the user doesn't have permission to execute | 05:04 |
dhx1 | etc | 05:04 |
dhx1 | still have to check whether that is OK by HTTP standards | 05:04 |
Paul_ | that would imply that really exception should have a 'type' command | 05:05 |
Paul_ | of either ACCESS,SERVER,USER,NOTFOUND | 05:05 |
dhx1 | nah, I was just hard coding a HTTP return code into each extended Exception class | 05:05 |
Paul_ | and when the shutdown handler processes exceptions, [as in theory, we could have multiple exceptions right?] | 05:05 |
dhx1 | yeah you're right, we may want to return multiple exceptions at once | 05:06 |
dhx1 | in which case... I don't know ;) | 05:06 |
dhx1 | perhaps if all the errors are of the same type, use that type | 05:06 |
Paul_ | tbh, i'm thinking we probably want to return 200 or 404 any way at all times | 05:06 |
dhx1 | if they're different, use an order of hierarchy to determine what will be returned | 05:06 |
Paul_ | [given that webbrowsers have a habit of making 500 errors etc look pretty, and I think IIS does similar] | 05:07 |
dhx1 | we can't customise 500 pages in those browsers? | 05:07 |
Paul_ | iirc, when you have friendly errors ticked in internet explorer | 05:08 |
dhx1 | IE9? | 05:08 |
Paul_ | they'll override the server-returned error message UNLESS its X chars long | 05:08 |
dhx1 | hmmm | 05:08 |
Paul_ | i can't find a reference to google on the x chars long thing atm | 05:11 |
dhx1 | we could detect IE browsers and always return a 200 response | 05:11 |
dhx1 | Internet Explorer (before Internet Explorer 7), however, will not display custom pages unless they are larger than 512 bytes, opting instead to display a "friendly" error page. | 05:11 |
Paul_ | http://www.xav.com/scripts/guardian/help/1004.html | 05:11 |
Paul_ | yea | 05:11 |
dhx1 | http://en.wikipedia.org/wiki/HTTP_404#Custom_error_pages | 05:11 |
Paul_ | just need to be a bit careful | 05:12 |
Paul_ | iis7 [before 7.5] was a pain for hiding php error messages | 05:12 |
Paul_ | i.e. if fastcgi didn't return a valid response from php, it told you it didn't get a valid response | 05:13 |
Paul_ | as opposed to showing you the parse error it got :P | 05:13 |
Paul_ | [that was vista, but not win7sp1] | 05:13 |
dhx1 | ;/ | 05:13 |
dhx1 | I'm not sure if it's even a good idea for web apps to return error status codes | 05:14 |
dhx1 | or whether they're meant to be for HTTP protocol level errors only | 05:14 |
Paul_ | personally i'd retunr 200/4040 | 05:15 |
dhx1 | I see that Facebook/etc are using custom HTTP status codes for their JSON feeds | 05:15 |
dhx1 | well we wouldn't need to return 404 ourselves unless we're talking about attachments and perhaps plugin stuff | 05:15 |
dhx1 | the web server would handle all the response codes usually | 05:15 |
Paul_ | could the credits list live in the manual? | 05:16 |
dhx1 | probably | 05:17 |
Paul_ | but yea, password auth is broken ;/ | 05:18 |
dhx1 | I'm not sure about our approach to binding parameters to queries | 05:19 |
Paul_ | hehe | 05:19 |
dhx1 | it's unwieldy when inserting lots of fields into a table | 05:19 |
dhx1 | as it's hard to determine which parameters are strings, ints, etc | 05:19 |
dhx1 | + we lose the string "length" restriction possible with PDO bindParam | 05:20 |
*** Quits: siebrand (~siebrand@80.179.214.170.cable.012.net.il) (Quit: siebrand) | 05:20 | |
Paul_ | we only use strings and ints | 05:20 |
Paul_ | ;) | 05:20 |
Paul_ | and i'd personally argue that the user object for example | 05:21 |
Paul_ | shouldn't allow a string to set against, say a username, which is longer then the allowed length in the database | 05:21 |
Paul_ | as the object, [if you also consider the possibility of allowing it to live in memcache etc] should be valid | 05:22 |
Paul_ | also, pdo bindparam doesn't support length? | 05:23 |
dhx1 | it does ;) | 05:23 |
dhx1 | and it wouldn't hurt to place an extra check in there | 05:23 |
Paul_ | yea, ok, manual was jut confsuing | 05:23 |
dhx1 | it sounds like some database servers truncate strings that are too long? | 05:24 |
Paul_ | [talking about out params from stored procs] | 05:24 |
dhx1 | I would have hoped they produce an error instead | 05:24 |
dhx1 | oh, perhaps you're right | 05:24 |
dhx1 | that would make more sense | 05:24 |
dhx1 | also for input/ouput bindings | 05:24 |
Paul_ | Most parameters are input parameters, that is, parameters that are used in a read-only fashion to build up the query | 05:25 |
Paul_ | - | 05:25 |
Paul_ | Length of the data type. To indicate that a parameter is an OUT parameter from a stored procedure, you must explicitly set the length. | 05:25 |
Paul_ | but then the example they give shows it used on an input parameter | 05:25 |
Paul_ | so I dont know :) | 05:25 |
Paul_ | i'd be surprised if a db truncated | 05:25 |
Paul_ | if not given a length | 05:26 |
dhx1 | yea | 05:26 |
Paul_ | I could imagine it truncated if you tell it you want 12 charaters in bindparam and pass in 20 | 05:26 |
dhx1 | well I'd argue it should produce an error in that case | 05:26 |
Paul_ | but in either case, i'd hope you'd get an error | 05:26 |
Paul_ | although in theory, i'd hope we'll have fewer db queries knocking around | 05:28 |
Paul_ | by time we are done | 05:28 |
Paul_ | i.e. object will have a create,get,update,delete query | 05:28 |
Paul_ | whereas at the moment, we've sometimes got the same get query in different places | 05:29 |
Paul_ | dhx1: can we make the view issues thing a jquery grid? :P | 05:31 |
dhx1 | doesn't sound good IMO | 05:31 |
dhx1 | bad usability? | 05:31 |
Paul_ | not sure about bad usability | 05:32 |
Paul_ | older browsers could have fun! | 05:32 |
Paul_ | or is that what you meant ;p | 05:32 |
dhx1 | even on modern browsers | 05:34 |
dhx1 | I don't see what a Javascript powered grid would achieve | 05:34 |
dhx1 | sorting columns = useless because we display data in pages | 05:34 |
Paul_ | I don't see what a Javascript powered grid would achieve | 05:35 |
Paul_ | [10:34.48] <d | 05:35 |
Paul_ | oh, btw, what is http://www.mantisbt.org/bugs/view.php?id=13193 | 05:35 |
Paul_ | other then a bad idea | 05:36 |
dhx1 | Paul_: whoooa, agreed | 05:42 |
dhx1 | burn that commit with fire | 05:42 |
*** Quits: mellen (~thansen@cl-289.cph-01.dk.sixxs.net) (Ping timeout: 264 seconds) | 05:51 | |
*** Quits: toddf (~todd@pf.FreeDaemonHosting.com) (Ping timeout: 255 seconds) | 06:08 | |
*** Joins: kirillka (~Miranda@195.242.142.17) | 06:12 | |
*** Joins: mellen (~thansen@cl-289.cph-01.dk.sixxs.net) | 06:15 | |
Paul_ | dhx1: well, I'm ignoring it atm ;p | 06:17 |
Paul_ | i'm also still not listed on https://github.com/mantisbt so ignoring next too atm | 06:18 |
*** Quits: mellen (~thansen@cl-289.cph-01.dk.sixxs.net) (Ping timeout: 264 seconds) | 06:30 | |
*** Joins: mellen (~thansen@x1-6-00-22-02-00-0c-40.k1109.webspeed.dk) | 06:30 | |
asm89 | jreese: i'd like to add a "open all diffs" button to source integration | 06:36 |
asm89 | do you want a PR for such a 'feature' ? | 06:37 |
*** Joins: siebrand (~siebrand@bzq-218-208-41.red.bezeqint.net) | 06:44 | |
Paul_ | siebrand! | 07:04 |
Paul_ | siebrand: can you generate me some languages files | 07:04 |
siebrand | Paul_! | 07:04 |
* siebrand is in Haifa, Israel at the moment for Wikimania 2011 | 07:04 | |
Paul_ | 'ok' | 07:04 |
siebrand | Paul_: language files for what version (can only do for 1.2.x) | 07:08 |
Paul_ | i've tweaked the next version for you | 07:16 |
Paul_ | in my branch | 07:16 |
*** Quits: siebrand (~siebrand@bzq-218-208-41.red.bezeqint.net) (Quit: siebrand) | 07:33 | |
*** Joins: siebrand (~siebrand@bzq-218-88-83.red.bezeqint.net) | 08:14 | |
dhx1 | siebrand: sounds like fun :) | 08:15 |
siebrand | dhx1: it is! | 08:16 |
dhx1 | siebrand: from past events it seems like it draws quite a crowd | 08:17 |
siebrand | dhx1: ~600 people from ~56 countries | 08:18 |
dhx1 | siebrand: 600!... didn't know it had grown that much | 08:18 |
dhx1 | siebrand: a good thing, given how useful Wikipedia is :) | 08:19 |
siebrand | dhx1: Wikimania appears to be growing with about 100 people per year. | 08:19 |
siebrand | dhx1: next year it's in Washington, D.C., so I expect there will be over 700 people there. | 08:20 |
dhx1 | siebrand: any talk about switching to git for the Mediawiki project? I'd love to help, but can't stand Subversion ;) | 08:21 |
Paul_ | I dont get banks | 08:22 |
Paul_ | I have an account where I put in £X.61 | 08:23 |
Paul_ | I receive interest of £X.19 | 08:23 |
Paul_ | therefore my balance is £X.05 | 08:23 |
dhx1 | Paul_: Bitcoin? :P | 08:25 |
Paul_ | bitcoin? | 08:26 |
dhx1 | Paul_: Wikipedia | 08:29 |
dhx1 | siebrand: I've got to try applause on landing here in Australia | 08:32 |
siebrand | hehe | 08:33 |
siebrand | dhx1: talk yes, consensus no. So it's a no for now. | 08:33 |
dhx1 | siebrand: around here the only applause you'd see is after an announcement "Ladies and gentlemen, we've been cleared for take-off" :) | 08:34 |
siebrand | hehe | 08:34 |
dhx1 | siebrand: understood, it's not an easy task when you factor in automated scripts needing to be changed, etc | 08:34 |
Paul_ | also | 08:37 |
dhx1 | now I remember what else frustrates me about Mediawiki... "Scripts should use an informative User-Agent string with contact information, or they may be IP-blocked without notice." | 08:37 |
Paul_ | with svn you tend to know where 'trunk' is | 08:37 |
dhx1 | with git, you know where 'master' is ;) | 08:38 |
dhx1 | it depends on how you use it | 08:38 |
Paul_ | I know where master is atm | 08:38 |
Paul_ | :P | 08:38 |
jreese | asm89: what do you mean by "open all diffs" / | 09:11 |
asm89 | at the end of the changeset table | 09:13 |
asm89 | a button | 09:13 |
asm89 | that opens all changset diff links | 09:13 |
asm89 | :P | 09:13 |
jreese | as in mass tab spam? or open a specially crafted url that contains a single diff of all those changesets? | 09:14 |
asm89 | tab spam | 09:14 |
asm89 | it's nowhere near special. but i guessed that if you liked it i'd commit it to github ;) | 09:15 |
jreese | I'm not even sure how you would do that without javascript, and tbh, that sounds like something that most browsers' pop-up blockers would like | 09:15 |
jreese | wouldn't* | 09:15 |
asm89 | it works with js | 09:15 |
asm89 | we do code review on those changesets ;) | 09:15 |
jreese | ah | 09:16 |
jreese | I guess I'm not fond of the idea | 09:16 |
asm89 | then i won't commit it :) | 09:16 |
asm89 | it's kind of hackish anyway, but quite useful if you use it as we do i guess :) | 09:16 |
jreese | I'd imagine a lot of people would click on it wondering what it does, and then be frustrated the moment 20+ tabs open up in their browser | 09:16 |
asm89 | well, that's what they deserve | 09:17 |
jreese | lol | 09:17 |
asm89 | for creating to big tickets :P | 09:17 |
jreese | oh, you're talking about on the issue page | 09:17 |
asm89 | instead of splitting everything up in nice subtickets :> | 09:17 |
asm89 | ;) | 09:17 |
asm89 | ah yeah, sorry xD | 09:17 |
jreese | I thought you were talking about the repository's list of all changesets | 09:18 |
jreese | ok, that makes a bit more sense then | 09:18 |
* asm89 should ASS U ME less | 09:18 | |
jreese | lol | 09:18 |
asm89 | :'D | 09:18 |
jreese | ok, that actually sounds interesting, and yes, if you want to commit that with a couple caveats, then that would be neat | 09:19 |
jreese | 1- make sure the link text makse it clear that they will open in new tabs | 09:19 |
jreese | 2- allow admins to enable/disable the feature from the source config page | 09:19 |
asm89 | make it visible by default? | 09:20 |
jreese | sure | 09:20 |
asm89 | http://i.imgur.com/o8eo9.png | 09:21 |
asm89 | but ok, i'll add those | 09:21 |
asm89 | any other things? | 09:21 |
jreese | only other thing I can think is potentially adding a link to open a single diff of all the changesets, but that's not a big deal | 09:22 |
asm89 | it opens the diff of the underlying webgit/cgit/websvn etc | 09:22 |
asm89 | so that has to support that | 09:22 |
jreese | true, that sort of thing would probably require a new method for source plugins | 09:23 |
jreese | so don't worry about that | 09:23 |
*** Joins: tmckeown (~Adium@pool-108-56-179-231.washdc.fios.verizon.net) | 09:25 | |
*** Parts: tmckeown (~Adium@pool-108-56-179-231.washdc.fios.verizon.net) () | 09:25 | |
asm89 | cool | 09:26 |
jreese | Paul_: added you to github now | 09:41 |
*** Joins: daryn (~daryn@h158.249.190.173.static.ip.windstream.net) | 09:43 | |
*** Quits: kirillka (~Miranda@195.242.142.17) (Quit: kirillka) | 09:57 | |
*** Joins: tmckeown (~Adium@pool-108-56-179-231.washdc.fios.verizon.net) | 10:11 | |
*** Parts: tmckeown (~Adium@pool-108-56-179-231.washdc.fios.verizon.net) () | 10:11 | |
*** Quits: siebrand (~siebrand@bzq-218-88-83.red.bezeqint.net) (Quit: siebrand) | 10:52 | |
*** Quits: Cupertino (~Cupez@unaffiliated/cupertino) (Quit: I give up...) | 11:02 | |
*** Joins: tmckeown (~Adium@pool-108-56-179-231.washdc.fios.verizon.net) | 11:07 | |
*** Parts: tmckeown (~Adium@pool-108-56-179-231.washdc.fios.verizon.net) () | 11:07 | |
*** Quits: asm89 (~asm89@unaffiliated/asm89) (Quit: WeeChat 0.3.5) | 11:09 | |
*** Quits: soustruh (~Miranda@169.211.broadband13.iol.cz) (Quit: visit http://wormscesky.cz) | 11:16 | |
*** Quits: mellen (~thansen@x1-6-00-22-02-00-0c-40.k1109.webspeed.dk) (Ping timeout: 240 seconds) | 11:21 | |
*** Joins: mellen (~thansen@x1-6-00-22-02-00-0c-40.k1109.webspeed.dk) | 11:22 | |
*** Quits: mellen (~thansen@x1-6-00-22-02-00-0c-40.k1109.webspeed.dk) (Ping timeout: 260 seconds) | 11:31 | |
*** Joins: mellen (~thansen@cl-289.cph-01.dk.sixxs.net) | 11:36 | |
*** Lukosanthropos is now known as lukosanthropos | 12:50 | |
Paul_ | dhx1: http://labs.adobe.com/ | 13:15 |
*** Quits: scribe9343423 (~scribe934@static.96.23.63.178.clients.your-server.de) (Ping timeout: 250 seconds) | 13:25 | |
*** Quits: daryn (~daryn@h158.249.190.173.static.ip.windstream.net) (Ping timeout: 240 seconds) | 13:25 | |
*** Quits: chris38` (~chris38@AGrenoble-751-1-11-236.w90-9.abo.wanadoo.fr) (Ping timeout: 240 seconds) | 13:30 | |
*** Joins: chris38` (~chris38@AGrenoble-751-1-11-236.w90-9.abo.wanadoo.fr) | 13:38 | |
*** Joins: daryn (~daryn@h158.249.190.173.static.ip.windstream.net) | 13:42 | |
*** lukosanthropos is now known as Lukosanthropos | 14:16 | |
*** Joins: tmckeown (~Adium@pool-108-56-179-231.washdc.fios.verizon.net) | 14:19 | |
*** Parts: tmckeown (~Adium@pool-108-56-179-231.washdc.fios.verizon.net) () | 14:20 | |
*** Joins: serge (~serge@pool-71-240-247-85.syr.east.verizon.net) | 15:43 | |
serge | hey | 15:43 |
serge | new to mantis, have a quick question | 15:43 |
*** Joins: jer_ (51396744@gateway/web/freenode/ip.81.57.103.68) | 15:52 | |
serge | wow thanks for the help guys | 16:01 |
*** Quits: serge (~serge@pool-71-240-247-85.syr.east.verizon.net) (Quit: serge) | 16:01 | |
* jreese points at /topic | 16:02 | |
*** Joins: soustruh (~Miranda@ip-86-49-121-75.net.upcbroadband.cz) | 16:04 | |
*** Joins: tmckeown (~Adium@pool-108-56-179-231.washdc.fios.verizon.net) | 16:44 | |
*** Parts: tmckeown (~Adium@pool-108-56-179-231.washdc.fios.verizon.net) () | 16:45 | |
*** Quits: Lukosanthropos (~Lukosanth@cpc23-seac20-2-0-cust78.7-2.cable.virginmedia.com) (Ping timeout: 240 seconds) | 17:51 | |
*** Quits: daryn (~daryn@h158.249.190.173.static.ip.windstream.net) (Quit: Ex-Chat) | 18:43 | |
Paul_ | jreese: be nice :P | 19:04 |
jreese | I wouldn't have minded if not for his comment right before he left | 19:05 |
Paul_ | :) | 19:06 |
*** Joins: Cesare (~Adium@creati59.lnk.telstra.net) | 19:06 | |
Paul_ | i seem to have broken my local trie ;/ | 19:07 |
Paul_ | tree | 19:07 |
Paul_ | it won't log in ;/ | 19:07 |
Paul_ | oh lol | 19:10 |
*** Quits: Paul_ (~IceChat09@2001:470:9310:aaaa:2dfd:753c:c6f9:2651) (Quit: Clap on! , Clap off! Clap@#&$NO CARRIER) | 19:24 | |
*** Quits: jer_ (51396744@gateway/web/freenode/ip.81.57.103.68) (Ping timeout: 252 seconds) | 19:45 | |
*** Quits: soustruh (~Miranda@ip-86-49-121-75.net.upcbroadband.cz) (Quit: visit http://wormscesky.cz) | 19:47 | |
*** Joins: scribe9343423 (~scribe934@static.96.23.63.178.clients.your-server.de) | 20:00 | |
*** Joins: tmckeown (~Adium@pool-108-56-179-231.washdc.fios.verizon.net) | 20:47 | |
*** Parts: tmckeown (~Adium@pool-108-56-179-231.washdc.fios.verizon.net) () | 20:48 | |
*** Quits: dhx1 (~anonymous@60-242-108-164.static.tpgi.com.au) (Read error: Connection timed out) | 21:48 | |
*** Joins: dhx1 (~anonymous@60-242-108-164.static.tpgi.com.au) | 21:48 | |
*** Joins: tmckeown (~Adium@pool-108-56-179-231.washdc.fios.verizon.net) | 22:06 | |
*** Parts: tmckeown (~Adium@pool-108-56-179-231.washdc.fios.verizon.net) () | 22:06 | |
*** Quits: scribe9343423 (~scribe934@static.96.23.63.178.clients.your-server.de) (Ping timeout: 240 seconds) | 23:27 |
Generated by irclog2html.py 2.9.2 by Marius Gedminas - find it at mg.pov.lt!