| *** Quits: JonMarkGo (~Jon@ool-18bfe16f.dyn.optonline.net) (Ping timeout: 264 seconds) | 01:18 | |
| *** Joins: [1]jer (~jer@bdv75-1-81-57-103-68.fbx.proxad.net) | 02:17 | |
| *** Joins: cerf (~quassel@mcl71-3-78-241-52-239.fbx.proxad.net) | 02:38 | |
| *** Quits: [1]jer (~jer@bdv75-1-81-57-103-68.fbx.proxad.net) (Ping timeout: 246 seconds) | 02:57 | |
| *** Quits: Cesare (~Adium@creati59.lnk.telstra.net) (Quit: Leaving.) | 03:14 | |
| *** Joins: soustruh (~Miranda@ip-86-49-121-75.net.upcbroadband.cz) | 03:17 | |
| *** Joins: kirillka (~Miranda@195.242.142.17) | 04:08 | |
| *** Joins: asm89 (~asm89@unaffiliated/asm89) | 04:15 | |
| dhx1 | paul paul paul paul paul..... paul paul paul... :) | 08:42 |
|---|---|---|
| *** Joins: JonMarkGo (~Jon@ool-18bfe16f.dyn.optonline.net) | 08:44 | |
| *** Quits: siebrand (~siebrand@5353A6DC.cm-6-4c.dynamic.ziggo.nl) (Quit: siebrand) | 09:26 | |
| *** Quits: JonMarkGo (~Jon@ool-18bfe16f.dyn.optonline.net) (Ping timeout: 252 seconds) | 09:26 | |
| *** Joins: siebrand (~siebrand@5353A6DC.cm-6-4c.dynamic.ziggo.nl) | 09:26 | |
| *** Joins: daryn (~daryn@h158.249.190.173.static.ip.windstream.net) | 09:31 | |
| dregad | dhx1: I have not seen him online today | 09:41 |
| dhx1 | dregad: thanks | 09:41 |
| dregad | I have a question for you if you got a few minutes | 09:42 |
| dregad | was looking at your patch for the last commit | 09:44 |
| dhx1 | sure | 09:46 |
| dregad | why do you use preg_match count, and not simply a lookup on $g_custom_group_actions for whatever word is after EXT_ | 09:47 |
| dhx1 | custom_group_actions = defined by a plugin or custom_functions_api function? | 09:49 |
| dhx1 | you're right - the system still sucks | 09:50 |
| dregad | I just thought that you're excluding "special" chars with the \w regex - which I'll agree should resolve the issue - but not strictly enforcing that only defined actions are accepted as parameter | 09:52 |
| dregad | moreover, if I'm not mistaken, count( $t_matches ) !== 2 will never be true | 09:54 |
| dhx1 | $matches[0] returns the full string | 09:54 |
| dhx1 | $matches[1] returns the first subgroup | 09:54 |
| dhx1 | == 2 :) | 09:54 |
| dregad | yes, so it's always == 2 | 09:55 |
| dregad | because you only have 1 subgroup in the regex | 09:55 |
| dhx1 | it could be 0 if the subgroup never matches | 09:55 |
| dhx1 | that is what it's checking | 09:55 |
| dregad | ah yes you're right | 09:55 |
| dregad | but then if you don't mind my picking nits, it would be cleaner to check the return value of preg_match | 09:57 |
| dregad | I guess it doesn't matter | 09:57 |
| *** Quits: kirillka (~Miranda@195.242.142.17) (Quit: kirillka) | 09:59 | |
| *** Quits: dhx1 (~anonymous@60-242-108-164.static.tpgi.com.au) (Read error: Connection reset by peer) | 10:00 | |
| *** Joins: dhx1 (~anonymous@60-242-108-164.static.tpgi.com.au) | 10:03 | |
| dhx1 | dregad: agreed, that would be a better approach | 10:03 |
| dhx1 | actually... maybe not | 10:03 |
| dhx1 | preg_match returns 0 or 1 | 10:04 |
| dhx1 | preg_match_all returns the number of matches made | 10:04 |
| dhx1 | even so... if preg_match returns 1 then we know the subgroup matched too... | 10:04 |
| dhx1 | same effect | 10:04 |
| dregad | you can do if( preg_match (...) ) | 10:04 |
| dregad | sorry, if( !preg_match | 10:05 |
| dhx1 | yep | 10:05 |
| dhx1 | ideally we'd do what you said... and check against a list of known 'good' actions | 10:05 |
| dregad | which we can get by config_get( 'custom_group_actions' ); | 10:06 |
| dregad | right? | 10:06 |
| dregad | (not sure if that includes plugin-specific ones) | 10:07 |
| dhx1 | but that doesn't include built in ones? | 10:07 |
| dhx1 | which we could hardcode somewhere.. | 10:07 |
| dregad | built-in ones don't come in as EXT_xxx | 10:07 |
| dhx1 | I think some do | 10:07 |
| dregad | seems odd | 10:07 |
| *** Quits: siebrand (~siebrand@5353A6DC.cm-6-4c.dynamic.ziggo.nl) (Quit: siebrand) | 10:10 | |
| dhx1 | EXT = show external page containing fields before performing the action (attach_tags, etc) | 10:10 |
| dregad | you're correct - print_all_bug_action_option_list has 4 of these | 10:11 |
| dregad | and they're hardcoded there | 10:12 |
| dregad | maybe the commands list should be built in another function | 10:15 |
| dregad | then that same function can be called from bug_actiongroup_ext_page.php | 10:17 |
| dregad | dhx1: did you get a chance to look at the 2 branches I put on github following our discussion couple days ago ? | 10:38 |
| dhx1 | dregad: not yet, will check tomorrow | 10:44 |
| dregad | cool, thanks | 10:44 |
| *** Quits: dhx1 (~anonymous@60-242-108-164.static.tpgi.com.au) (Remote host closed the connection) | 11:08 | |
| *** Joins: soc42 (~soc42@f051134239.adsl.alicedsl.de) | 11:21 | |
| *** Joins: siebrand (~siebrand@5353A6DC.cm-6-4c.dynamic.ziggo.nl) | 11:33 | |
| *** Quits: asm89 (~asm89@unaffiliated/asm89) (Quit: bye) | 12:17 | |
| *** Quits: cerf (~quassel@mcl71-3-78-241-52-239.fbx.proxad.net) (Remote host closed the connection) | 12:58 | |
| *** Joins: [1]jer (~jer@bdv75-1-81-57-103-68.fbx.proxad.net) | 14:49 | |
| *** Quits: chris38` (~chris38@AGrenoble-751-1-7-18.w90-9.abo.wanadoo.fr) (Read error: Operation timed out) | 15:17 | |
| *** Quits: daryn (~daryn@h158.249.190.173.static.ip.windstream.net) (Quit: Ex-Chat) | 16:39 | |
| *** Quits: soc42 (~soc42@f051134239.adsl.alicedsl.de) (Remote host closed the connection) | 16:41 | |
| *** Joins: Paul24 (~IceChat09@2001:470:9310:aaaa:c423:b707:1d3a:bceb) | 17:04 | |
| *** Quits: [1]jer (~jer@bdv75-1-81-57-103-68.fbx.proxad.net) (Ping timeout: 245 seconds) | 17:35 | |
| *** Quits: soustruh (~Miranda@ip-86-49-121-75.net.upcbroadband.cz) (Quit: visit http://wormscesky.cz) | 17:38 | |
| *** Quits: Paul24 (~IceChat09@2001:470:9310:aaaa:c423:b707:1d3a:bceb) (Quit: For Sale: Parachute. Only used once, never opened, small stain.) | 18:07 | |
| *** Joins: soc42 (~soc42@f051134239.adsl.alicedsl.de) | 18:23 | |
| *** Joins: soc42_ (~soc42@g226201254.adsl.alicedsl.de) | 18:37 | |
| *** Quits: soc42_ (~soc42@g226201254.adsl.alicedsl.de) (Remote host closed the connection) | 18:38 | |
| *** Quits: soc42 (~soc42@f051134239.adsl.alicedsl.de) (Ping timeout: 245 seconds) | 18:39 | |
| *** Quits: scribe9343423 (~scribe934@static.96.23.63.178.clients.your-server.de) (Remote host closed the connection) | 20:00 | |
| *** Joins: scribe9343423 (~scribe934@static.96.23.63.178.clients.your-server.de) | 20:00 | |
| *** Quits: micahg (~micahg@ubuntu/member/micahg) (Ping timeout: 276 seconds) | 20:05 | |
| *** Quits: sezuan (bouncer@irc.scheff32.de) (Ping timeout: 264 seconds) | 20:23 | |
| *** Joins: sezuan_ (bouncer@irc.scheff32.de) | 20:24 | |
| *** Joins: dhx_m (~david@60-242-108-164.static.tpgi.com.au) | 23:56 | |
Generated by irclog2html.py 2.9.2 by Marius Gedminas - find it at mg.pov.lt!