Saturday, 2010-09-18

CIA-100Mantisbt: hickseydr * re95999975e41 /core/utility_api.php: Fix #7328: ini_get_number uses wrong postfix multipliers00:18
CIA-100Mantisbt: hickseydr master-1.2.x * r3536e18ab07e /core/utility_api.php: Fix #7328: ini_get_number uses wrong postfix multipliers00:18
CIA-100Mantisbt: djuntgen master-1.2.x * rd1a79720ab83 /core/filter_api.php: Fix #12286: Sub projects not included in advanced filter ALL PROJECTS00:28
CIA-100Mantisbt: djuntgen * rc4d7ca494429 /core/filter_api.php: Fix #12286: Sub projects not included in advanced filter ALL PROJECTS00:28
CIA-100Mantisbt: sveyret * r0f120c9515dc /core/csv_api.php: Fix #9338: CSV export does not escape all characters00:43
CIA-100Mantisbt: sveyret master-1.2.x * r38c5a1c415ac /core/csv_api.php: Fix #9338: CSV export does not escape all characters00:43
*** Joins: daryn_ (~daryn@h246.147.16.98.dynamic.ip.windstream.net)01:05
*** Quits: daryn (~daryn@h151.158.16.98.dynamic.ip.windstream.net) (Ping timeout: 272 seconds)01:08
*** daryn_ is now known as daryn01:12
CIA-100Mantisbt: hickseydr * r01d2ffad2e3a / (6 files in 2 dirs): Issue #12368: Remove input side XSS validation of user real names01:22
CIA-100Mantisbt: olivier.mengue master-1.2.x * rd37df2578cab /core/html_api.php: Fix #11299: Custom menu links should be sanitised before output01:38
CIA-100Mantisbt: olivier.mengue * r544e76d9dd3f /core/html_api.php: Fix #11299: Custom menu links should be sanitised before output01:38
*** Quits: kirillka (~Miranda@241-81-52-95.baltnet.ru) (Quit: kirillka)01:56
*** Joins: daryn_ (~daryn@h89.147.16.98.dynamic.ip.windstream.net)02:07
*** Quits: daryn (~daryn@h246.147.16.98.dynamic.ip.windstream.net) (Read error: Operation timed out)02:10
*** Joins: daryn__ (~daryn@h127.211.31.71.dynamic.ip.windstream.net)02:25
*** Quits: daryn_ (~daryn@h89.147.16.98.dynamic.ip.windstream.net) (Ping timeout: 240 seconds)02:27
*** Joins: Github (~Github@sh1-ext.rs.github.com)02:30
Githubmantisbt: master Tamás Gulácsi * d8a4c2f (1 files in 1 dirs): Fix #12366: file_api uses old style calls to db_get_table ...02:30
Githubmantisbt: master Roland Becker * efb50eb (1 files in 1 dirs): Fix #12344: manage_user_page.php: changing page resets sort criteria ...02:30
Githubmantisbt: master David Hicks * 8ce72fe (1 files in 1 dirs): Fix #12362: Redirect users to tag management page after deleting a tag ...02:30
Githubmantisbt: master David Hicks * db2b007 (1 files in 1 dirs): Fix #12363: Billing report end date not included in range ...02:30
Githubmantisbt: master David Hicks * e959999 (1 files in 1 dirs): Fix #7328: ini_get_number uses wrong postfix multipliers ...02:30
Githubmantisbt: master David W. Juntgen * c4d7ca4 (1 files in 1 dirs): Fix #12286: Sub projects not included in advanced filter ALL PROJECTS ...02:30
Githubmantisbt: master Stéphane Veyret * 0f120c9 (1 files in 1 dirs): Fix #9338: CSV export does not escape all characters ...02:30
Githubmantisbt: master David Hicks * 01d2ffa (6 files in 2 dirs): Issue #12368: Remove input side XSS validation of user real names ...02:30
Githubmantisbt: master Olivier Mengué * 544e76d (1 files in 1 dirs): Fix #11299: Custom menu links should be sanitised before output ...02:30
Githubmantisbt: master commits 3e17066...544e76d - http://bit.ly/bpdIfF02:30
*** Parts: Github (~Github@sh1-ext.rs.github.com)02:30
*** Quits: daryn__ (~daryn@h127.211.31.71.dynamic.ip.windstream.net) (Ping timeout: 272 seconds)02:57
*** Joins: daryn (~daryn@h127.211.31.71.dynamic.ip.windstream.net)02:59
*** Joins: siebrand (~beis@145.20.145.137)03:10
*** Quits: 30BAAE2AV (~Ragnor@dslb-188-100-037-187.pools.arcor-ip.net) (Quit: leaving)03:29
*** Joins: Ragnor (~Ragnor@dslb-188-100-037-187.pools.arcor-ip.net)03:29
*** Joins: kirillka (~Miranda@241-81-52-95.baltnet.ru)03:46
*** Quits: kirillka (~Miranda@241-81-52-95.baltnet.ru) (Ping timeout: 240 seconds)03:52
*** Joins: moto-moi (~hylke@cara.xs4all.nl)04:34
*** Quits: daryn (~daryn@h127.211.31.71.dynamic.ip.windstream.net) (Ping timeout: 240 seconds)05:29
*** Joins: paulr (~IceChat09@2001:470:9310:aaaa:e924:7a29:4426:7e66)05:44
paulrmo05:44
*** Joins: daryn (~daryn@h127.211.31.71.dynamic.ip.windstream.net)05:50
paulrmo05:56
* paulr pokes dhx105:59
*** Quits: daryn (~daryn@h127.211.31.71.dynamic.ip.windstream.net) (Ping timeout: 240 seconds)08:03
*** Joins: daryn (~daryn@h132.111.88.75.dynamic.ip.windstream.net)08:18
*** Quits: daryn (~daryn@h132.111.88.75.dynamic.ip.windstream.net) (Ping timeout: 252 seconds)08:25
*** Joins: daryn (~daryn@h132.111.88.75.dynamic.ip.windstream.net)08:25
*** Joins: Rixie (~Rixie@0x4dd7390e.adsl.cybercity.dk)09:36
*** Quits: daryn (~daryn@h132.111.88.75.dynamic.ip.windstream.net) (Ping timeout: 245 seconds)09:49
dhx1paulr: hi09:49
*** Joins: daryn (~daryn@h132.111.88.75.dynamic.ip.windstream.net)09:58
paulrdhx1: lo10:03
paulrstill here?10:03
dhx1yep10:03
paulrI dont understand kirill's issue10:03
paulrpls explain :P10:03
dhx1hmm which one?10:04
paulrfonts10:05
dhx1ah :)10:05
paulrI dont really understand your patch either ;p10:05
dhx1well we were always setting $t_font = ''10:06
paulrisn't t_font set in config defaults?10:06
dhx1thus the array lookup is always false10:06
dhx1and thus arial.ttf is always used10:06
dhx1so there were a number of issues10:06
dhx1you can select the font to use in the plugin management interface for MantisGraph10:06
paulrright, ok10:07
paulrin which case, kirrill's patch makes more sense...10:08
paulrthe stuff to check fonts exist etc was added so that you dont get broken graphs if ez/jpgraph cant find font10:08
dhx1no point really10:08
paulrit seems a bit silly to remove it10:09
paulractually there is10:09
paulrIIRC, if font doesn't exist10:09
paulrezcomponents just errors10:09
paulrgenerating a broken image lin10:09
dhx1but it was for JpGraph I think10:09
paulrso the point of that code is to try to help the user10:09
paulrno10:09
paulrthe block you modified is ezc ;p10:09
paulror is it10:09
* paulr thinks10:09
dhx1bug #1099510:10
foobotBug 10995 - kabadi - open - confirmed10:10
foobotGraphs Plugin: Unable to read/find font - http://www.mantisbt.org/bugs/view.php?id=1099510:10
paulranyway, I added the file_Exists checking a while back to fix people complaining about  not getting images10:10
dhx1just confirming the error check only applied to JpGraph10:11
dhx1which already handles missing fonts gracefully with it's own error10:11
dhx1also... calling error_text?!10:11
dhx1is that an ezC function?10:12
dhx1we should just call trigger_error instead like we do elsewhere in Mantis10:12
paulrif ( plugin_config_get( 'eczlibrary' ) == ON ) {10:12
paulrthe error_text stuff is only for ecz10:13
paulrand no10:13
paulrerror_text is our own10:13
dhx1hmmm10:13
dhx1well I can fix that with trigger_error10:14
paulrer10:14
paulrnope10:14
paulras trigger error doesn't return an image...10:14
paulrthe point is:10:14
dhx1do we want to return an image?10:14
paulrwell, yes :P10:14
paulras otherwise, if user is viewing it in browser10:14
paulryou'll just get a broken link10:14
paulrI really hate having to right click on images, copy url, to get the error message text :P10:15
paulrthe only thing that's actually wrong10:15
paulris $t_font = '';10:15
paulrneeds to be removed10:15
paulrit doesn't help that it's not jpgrah, but ecz that's the actual issue10:16
paulrso just delete the one line kirrilla reported and done10:16
dhx1oh yeah I see your point10:16
dhx1as trigger_error() is no good when called from <img>10:17
*** Quits: daryn (~daryn@h132.111.88.75.dynamic.ip.windstream.net) (Ping timeout: 272 seconds)10:22
*** Joins: rolfkleef (~rolf@urtica.xs4all.nl)10:22
*** Joins: daryn (~daryn@h132.111.88.75.dynamic.ip.windstream.net)10:26
paulrdhx1: did you see my lang api stuff?10:28
dhx1the stuff that was committed?10:29
paulrno10:29
paulrstuff was linked in here 2 days ago10:29
dhx1probably not then10:29
paulr[03:28.52] <paulr> dhx1: did you see my lang api stuff?10:30
paulr[03:29.07]10:30
paulrhttp://mantis.pastebin.com/sLi1jSFn10:30
dhx1diff I or didn't see it :p10:31
paulrlang_get, lang_load, lang_get_Array10:32
paulrhave all changed10:32
paulra bit10:32
dhx1what happened to the error string array?10:33
dhx1IMO it should just be merged with the normal lang array10:33
dhx1why separate it?10:33
paulryes10:33
paulrthat's what i've done or well10:33
paulrit's a subarray10:34
paulri.e.:10:34
paulr'MANTIS_ERROR' => Array(10:34
dhx1hmmm just merge it into one? it'd be easier/faster that way?10:34
paulrand just use what? numbers as keys in s_messages?10:35
paulri.e.10:35
paulr'month_december' => 'December',10:35
paulrand10:35
paulrERROR_SQL => 'SQL error detected.',10:35
paulrworksforme10:35
dhx1hmm I see... we wanted to have error numbers10:38
paulrwell10:38
paulr1 array10:38
dhx1it makes sense10:38
paulrerror numbers for numbers10:38
paulrstrings for strings10:38
paulrI guess makes sense and simplifies code?10:38
dhx1so that when people report issues we don't have to "untranslate" error messages10:38
paulrso shall I stop messing around with seperate subarrays10:39
paulrand trying to merge them10:39
paulrand just have int's?10:39
paulroff for an hour10:41
paulrbut if that's the plan10:41
paulr1 array10:41
paulrstrings for messages10:41
paulrints for errors10:42
paulri'll fix that up when i get back10:42
dhx1probably just ints?10:43
dhx1or perhaps not ints... but string representations of ints10:43
dhx1ie. error code vs error number10:43
dhx1error codes could contain alphanumeric characters10:43
dhx1not too sure about all of this though10:44
*** Quits: daryn (~daryn@h132.111.88.75.dynamic.ip.windstream.net) (Ping timeout: 240 seconds)11:01
*** Joins: daryn (~daryn@h132.111.88.75.dynamic.ip.windstream.net)11:04
*** Quits: dhx1 (~anonymous@c122-107-170-247.eburwd5.vic.optusnet.com.au) (Remote host closed the connection)11:34
*** Joins: dhx1 (~anonymous@c122-107-170-247.eburwd5.vic.optusnet.com.au)11:37
*** Quits: siebrand (~beis@145.20.145.137) ()11:48
*** Quits: daryn (~daryn@h132.111.88.75.dynamic.ip.windstream.net) (Ping timeout: 240 seconds)11:53
*** Joins: daryn (~daryn@h132.111.88.75.dynamic.ip.windstream.net)11:54
*** Quits: daryn (~daryn@h132.111.88.75.dynamic.ip.windstream.net) (Ping timeout: 240 seconds)12:33
*** Joins: daryn (~daryn@h132.111.88.75.dynamic.ip.windstream.net)12:33
*** Quits: rolfkleef (~rolf@urtica.xs4all.nl) (Quit: Leaving.)13:30
paulrlo daryn13:51
darynhi13:52
LadySerenais there an option or plugin that can collapse the "Related Changesets" section of an issue page by default?13:55
LadySerena'cause seriously, this is getting ridiculously long: http://dev.vocasystem.net/mantis/view.php?id=113:55
paulrdaryn: did you see dhx/me?13:57
darynya13:57
paulr[03:41.48] <paulr> 1 array13:57
paulr[03:41.51] <paulr> strings for messages13:57
paulr[03:41.53] <paulr> ints for errors13:57
paulr[03:41.57] <paulr> i'll fix that up when i get back13:57
paulr[03:43.11] <dhx1> probably just ints?13:57
paulr[03:43.36] <dhx1> or perhaps not ints... but string representations of ints13:57
paulr[03:43.43] <dhx1> ie. error code vs error number13:57
paulr[03:43.53] <dhx1> error codes could contain alphanumeric characters13:57
paulr[03:44.31] <dhx1> not too sure about all of this though13:57
*** Joins: siebrand (~beis@sm.xs4all.nl)14:00
paulrprobably makes life easier for siebrand too if we do that14:00
siebrandprobably, indeed14:01
paulr:)14:01
darynyeah...i don't see a problem with it at first glance.  so you'd remove MANTIS_ERROR and use the ERROR_* constants as the key in the lang files?14:02
paulryes14:05
paulrsimplifies code14:05
paulrcan't see flaw atm14:05
paulr:P14:05
siebrandexcept that we have new style messages (also keys afaik) in master, and old style in our 1.2.x branch14:33
siebrandso there'll be awkward merging.14:33
siebrandSo I'd rather wait with that until our 'current release' branch has the new system, or the new system is backported to 1.2.x.14:33
paulrsiebrand: well, I guess the question is whether we still translate 1.2.x14:47
paulrpersonally14:49
paulrI'd like to see us delete all the _lang files from git14:49
paulrand kinda rebuild them from translate wiki14:49
siebrandpaulr: yeah, we talked about that, and that will work, but if the keys are changed, there's nothing to rebuild.15:25
siebrandpaulr: if we have a 'near future' (say 2-4 months) release goal for 1.3, I could work on it..15:26
*** Quits: daryn (~daryn@h132.111.88.75.dynamic.ip.windstream.net) (Ping timeout: 245 seconds)15:43
*** Joins: daryn (~daryn@h132.111.88.75.dynamic.ip.windstream.net)15:56
*** Quits: moto-moi (~hylke@cara.xs4all.nl) (Ping timeout: 272 seconds)17:39
*** Joins: rolfkleef (~rolf@urtica.xs4all.nl)17:51
*** Joins: rshaffaf (4a0dd982@gateway/web/freenode/ip.74.13.217.130)18:21
rshaffafhello - anyone out there?18:22
rshaffafI need some help with this Mantis SVN plugin18:23
rshaffafAlright - gotta roll.  Deftones and Alice in Chains tonight18:27
*** Quits: rshaffaf (4a0dd982@gateway/web/freenode/ip.74.13.217.130) (Quit: Page closed)18:28
giallunuclear_eclipse, around?18:50
*** Quits: rolfkleef (~rolf@urtica.xs4all.nl) (Ping timeout: 252 seconds)18:54
* paulr yawns19:29
CIA-100Mantisbt: giallu master-1.1.x * r3bc117fc8700 /print_all_bug_page_word.php: Fix #12371: XSS in print_all_bug_page_word.php project/category names19:42
CIA-100Mantisbt: giallu master-1.1.x * r51ee3d3fd47e /core/custom_field_api.php: Fix #12370: Multiple XSS issues with custom field enumeration values19:42
CIA-100Mantisbt: giallu master-1.1.x * r8f1ebac61d30 /manage_proj_cat_delete.php: Fix #12369: XSS vulnerability when deleting maliciously named categories19:42
*** Quits: giallu (~giallu@fedora/giallu) (Ping timeout: 252 seconds)19:53
*** Quits: scribe9343423 (~scribe934@static.96.23.63.178.clients.your-server.de) (Remote host closed the connection)20:00
*** Joins: scribe9343423 (~scribe934@static.96.23.63.178.clients.your-server.de)20:00
paulrdhx: up yet?20:54
*** Quits: paulr (~IceChat09@2001:470:9310:aaaa:e924:7a29:4426:7e66) (Ping timeout: 252 seconds)20:58
*** Joins: micahg (~micah@ubuntu/member/micahg)21:31
dhx1dhx1: hi23:03
dhx1oops... :)23:03
daryndhx1: that busy, huh?23:05
dhx1daryn: haha23:07
daryn:)23:07
*** Quits: daryn (~daryn@h132.111.88.75.dynamic.ip.windstream.net) (Ping timeout: 245 seconds)23:53
*** Joins: daryn (~daryn@h132.111.88.75.dynamic.ip.windstream.net)23:53

Generated by irclog2html.py 2.9.2 by Marius Gedminas - find it at mg.pov.lt!