CIA-100 | Mantisbt: hickseydr * re95999975e41 /core/utility_api.php: Fix #7328: ini_get_number uses wrong postfix multipliers | 00:18 |
---|---|---|
CIA-100 | Mantisbt: hickseydr master-1.2.x * r3536e18ab07e /core/utility_api.php: Fix #7328: ini_get_number uses wrong postfix multipliers | 00:18 |
CIA-100 | Mantisbt: djuntgen master-1.2.x * rd1a79720ab83 /core/filter_api.php: Fix #12286: Sub projects not included in advanced filter ALL PROJECTS | 00:28 |
CIA-100 | Mantisbt: djuntgen * rc4d7ca494429 /core/filter_api.php: Fix #12286: Sub projects not included in advanced filter ALL PROJECTS | 00:28 |
CIA-100 | Mantisbt: sveyret * r0f120c9515dc /core/csv_api.php: Fix #9338: CSV export does not escape all characters | 00:43 |
CIA-100 | Mantisbt: sveyret master-1.2.x * r38c5a1c415ac /core/csv_api.php: Fix #9338: CSV export does not escape all characters | 00:43 |
*** Joins: daryn_ (~daryn@h246.147.16.98.dynamic.ip.windstream.net) | 01:05 | |
*** Quits: daryn (~daryn@h151.158.16.98.dynamic.ip.windstream.net) (Ping timeout: 272 seconds) | 01:08 | |
*** daryn_ is now known as daryn | 01:12 | |
CIA-100 | Mantisbt: hickseydr * r01d2ffad2e3a / (6 files in 2 dirs): Issue #12368: Remove input side XSS validation of user real names | 01:22 |
CIA-100 | Mantisbt: olivier.mengue master-1.2.x * rd37df2578cab /core/html_api.php: Fix #11299: Custom menu links should be sanitised before output | 01:38 |
CIA-100 | Mantisbt: olivier.mengue * r544e76d9dd3f /core/html_api.php: Fix #11299: Custom menu links should be sanitised before output | 01:38 |
*** Quits: kirillka (~Miranda@241-81-52-95.baltnet.ru) (Quit: kirillka) | 01:56 | |
*** Joins: daryn_ (~daryn@h89.147.16.98.dynamic.ip.windstream.net) | 02:07 | |
*** Quits: daryn (~daryn@h246.147.16.98.dynamic.ip.windstream.net) (Read error: Operation timed out) | 02:10 | |
*** Joins: daryn__ (~daryn@h127.211.31.71.dynamic.ip.windstream.net) | 02:25 | |
*** Quits: daryn_ (~daryn@h89.147.16.98.dynamic.ip.windstream.net) (Ping timeout: 240 seconds) | 02:27 | |
*** Joins: Github (~Github@sh1-ext.rs.github.com) | 02:30 | |
Github | mantisbt: master Tamás Gulácsi * d8a4c2f (1 files in 1 dirs): Fix #12366: file_api uses old style calls to db_get_table ... | 02:30 |
Github | mantisbt: master Roland Becker * efb50eb (1 files in 1 dirs): Fix #12344: manage_user_page.php: changing page resets sort criteria ... | 02:30 |
Github | mantisbt: master David Hicks * 8ce72fe (1 files in 1 dirs): Fix #12362: Redirect users to tag management page after deleting a tag ... | 02:30 |
Github | mantisbt: master David Hicks * db2b007 (1 files in 1 dirs): Fix #12363: Billing report end date not included in range ... | 02:30 |
Github | mantisbt: master David Hicks * e959999 (1 files in 1 dirs): Fix #7328: ini_get_number uses wrong postfix multipliers ... | 02:30 |
Github | mantisbt: master David W. Juntgen * c4d7ca4 (1 files in 1 dirs): Fix #12286: Sub projects not included in advanced filter ALL PROJECTS ... | 02:30 |
Github | mantisbt: master Stéphane Veyret * 0f120c9 (1 files in 1 dirs): Fix #9338: CSV export does not escape all characters ... | 02:30 |
Github | mantisbt: master David Hicks * 01d2ffa (6 files in 2 dirs): Issue #12368: Remove input side XSS validation of user real names ... | 02:30 |
Github | mantisbt: master Olivier Mengué * 544e76d (1 files in 1 dirs): Fix #11299: Custom menu links should be sanitised before output ... | 02:30 |
Github | mantisbt: master commits 3e17066...544e76d - http://bit.ly/bpdIfF | 02:30 |
*** Parts: Github (~Github@sh1-ext.rs.github.com) | 02:30 | |
*** Quits: daryn__ (~daryn@h127.211.31.71.dynamic.ip.windstream.net) (Ping timeout: 272 seconds) | 02:57 | |
*** Joins: daryn (~daryn@h127.211.31.71.dynamic.ip.windstream.net) | 02:59 | |
*** Joins: siebrand (~beis@145.20.145.137) | 03:10 | |
*** Quits: 30BAAE2AV (~Ragnor@dslb-188-100-037-187.pools.arcor-ip.net) (Quit: leaving) | 03:29 | |
*** Joins: Ragnor (~Ragnor@dslb-188-100-037-187.pools.arcor-ip.net) | 03:29 | |
*** Joins: kirillka (~Miranda@241-81-52-95.baltnet.ru) | 03:46 | |
*** Quits: kirillka (~Miranda@241-81-52-95.baltnet.ru) (Ping timeout: 240 seconds) | 03:52 | |
*** Joins: moto-moi (~hylke@cara.xs4all.nl) | 04:34 | |
*** Quits: daryn (~daryn@h127.211.31.71.dynamic.ip.windstream.net) (Ping timeout: 240 seconds) | 05:29 | |
*** Joins: paulr (~IceChat09@2001:470:9310:aaaa:e924:7a29:4426:7e66) | 05:44 | |
paulr | mo | 05:44 |
*** Joins: daryn (~daryn@h127.211.31.71.dynamic.ip.windstream.net) | 05:50 | |
paulr | mo | 05:56 |
* paulr pokes dhx1 | 05:59 | |
*** Quits: daryn (~daryn@h127.211.31.71.dynamic.ip.windstream.net) (Ping timeout: 240 seconds) | 08:03 | |
*** Joins: daryn (~daryn@h132.111.88.75.dynamic.ip.windstream.net) | 08:18 | |
*** Quits: daryn (~daryn@h132.111.88.75.dynamic.ip.windstream.net) (Ping timeout: 252 seconds) | 08:25 | |
*** Joins: daryn (~daryn@h132.111.88.75.dynamic.ip.windstream.net) | 08:25 | |
*** Joins: Rixie (~Rixie@0x4dd7390e.adsl.cybercity.dk) | 09:36 | |
*** Quits: daryn (~daryn@h132.111.88.75.dynamic.ip.windstream.net) (Ping timeout: 245 seconds) | 09:49 | |
dhx1 | paulr: hi | 09:49 |
*** Joins: daryn (~daryn@h132.111.88.75.dynamic.ip.windstream.net) | 09:58 | |
paulr | dhx1: lo | 10:03 |
paulr | still here? | 10:03 |
dhx1 | yep | 10:03 |
paulr | I dont understand kirill's issue | 10:03 |
paulr | pls explain :P | 10:03 |
dhx1 | hmm which one? | 10:04 |
paulr | fonts | 10:05 |
dhx1 | ah :) | 10:05 |
paulr | I dont really understand your patch either ;p | 10:05 |
dhx1 | well we were always setting $t_font = '' | 10:06 |
paulr | isn't t_font set in config defaults? | 10:06 |
dhx1 | thus the array lookup is always false | 10:06 |
dhx1 | and thus arial.ttf is always used | 10:06 |
dhx1 | so there were a number of issues | 10:06 |
dhx1 | you can select the font to use in the plugin management interface for MantisGraph | 10:06 |
paulr | right, ok | 10:07 |
paulr | in which case, kirrill's patch makes more sense... | 10:08 |
paulr | the stuff to check fonts exist etc was added so that you dont get broken graphs if ez/jpgraph cant find font | 10:08 |
dhx1 | no point really | 10:08 |
paulr | it seems a bit silly to remove it | 10:09 |
paulr | actually there is | 10:09 |
paulr | IIRC, if font doesn't exist | 10:09 |
paulr | ezcomponents just errors | 10:09 |
paulr | generating a broken image lin | 10:09 |
dhx1 | but it was for JpGraph I think | 10:09 |
paulr | so the point of that code is to try to help the user | 10:09 |
paulr | no | 10:09 |
paulr | the block you modified is ezc ;p | 10:09 |
paulr | or is it | 10:09 |
* paulr thinks | 10:09 | |
dhx1 | bug #10995 | 10:10 |
foobot | Bug 10995 - kabadi - open - confirmed | 10:10 |
foobot | Graphs Plugin: Unable to read/find font - http://www.mantisbt.org/bugs/view.php?id=10995 | 10:10 |
paulr | anyway, I added the file_Exists checking a while back to fix people complaining about not getting images | 10:10 |
dhx1 | just confirming the error check only applied to JpGraph | 10:11 |
dhx1 | which already handles missing fonts gracefully with it's own error | 10:11 |
dhx1 | also... calling error_text?! | 10:11 |
dhx1 | is that an ezC function? | 10:12 |
dhx1 | we should just call trigger_error instead like we do elsewhere in Mantis | 10:12 |
paulr | if ( plugin_config_get( 'eczlibrary' ) == ON ) { | 10:12 |
paulr | the error_text stuff is only for ecz | 10:13 |
paulr | and no | 10:13 |
paulr | error_text is our own | 10:13 |
dhx1 | hmmm | 10:13 |
dhx1 | well I can fix that with trigger_error | 10:14 |
paulr | er | 10:14 |
paulr | nope | 10:14 |
paulr | as trigger error doesn't return an image... | 10:14 |
paulr | the point is: | 10:14 |
dhx1 | do we want to return an image? | 10:14 |
paulr | well, yes :P | 10:14 |
paulr | as otherwise, if user is viewing it in browser | 10:14 |
paulr | you'll just get a broken link | 10:14 |
paulr | I really hate having to right click on images, copy url, to get the error message text :P | 10:15 |
paulr | the only thing that's actually wrong | 10:15 |
paulr | is $t_font = ''; | 10:15 |
paulr | needs to be removed | 10:15 |
paulr | it doesn't help that it's not jpgrah, but ecz that's the actual issue | 10:16 |
paulr | so just delete the one line kirrilla reported and done | 10:16 |
dhx1 | oh yeah I see your point | 10:16 |
dhx1 | as trigger_error() is no good when called from <img> | 10:17 |
*** Quits: daryn (~daryn@h132.111.88.75.dynamic.ip.windstream.net) (Ping timeout: 272 seconds) | 10:22 | |
*** Joins: rolfkleef (~rolf@urtica.xs4all.nl) | 10:22 | |
*** Joins: daryn (~daryn@h132.111.88.75.dynamic.ip.windstream.net) | 10:26 | |
paulr | dhx1: did you see my lang api stuff? | 10:28 |
dhx1 | the stuff that was committed? | 10:29 |
paulr | no | 10:29 |
paulr | stuff was linked in here 2 days ago | 10:29 |
dhx1 | probably not then | 10:29 |
paulr | [03:28.52] <paulr> dhx1: did you see my lang api stuff? | 10:30 |
paulr | [03:29.07] | 10:30 |
paulr | http://mantis.pastebin.com/sLi1jSFn | 10:30 |
dhx1 | diff I or didn't see it :p | 10:31 |
paulr | lang_get, lang_load, lang_get_Array | 10:32 |
paulr | have all changed | 10:32 |
paulr | a bit | 10:32 |
dhx1 | what happened to the error string array? | 10:33 |
dhx1 | IMO it should just be merged with the normal lang array | 10:33 |
dhx1 | why separate it? | 10:33 |
paulr | yes | 10:33 |
paulr | that's what i've done or well | 10:33 |
paulr | it's a subarray | 10:34 |
paulr | i.e.: | 10:34 |
paulr | 'MANTIS_ERROR' => Array( | 10:34 |
dhx1 | hmmm just merge it into one? it'd be easier/faster that way? | 10:34 |
paulr | and just use what? numbers as keys in s_messages? | 10:35 |
paulr | i.e. | 10:35 |
paulr | 'month_december' => 'December', | 10:35 |
paulr | and | 10:35 |
paulr | ERROR_SQL => 'SQL error detected.', | 10:35 |
paulr | worksforme | 10:35 |
dhx1 | hmm I see... we wanted to have error numbers | 10:38 |
paulr | well | 10:38 |
paulr | 1 array | 10:38 |
dhx1 | it makes sense | 10:38 |
paulr | error numbers for numbers | 10:38 |
paulr | strings for strings | 10:38 |
paulr | I guess makes sense and simplifies code? | 10:38 |
dhx1 | so that when people report issues we don't have to "untranslate" error messages | 10:38 |
paulr | so shall I stop messing around with seperate subarrays | 10:39 |
paulr | and trying to merge them | 10:39 |
paulr | and just have int's? | 10:39 |
paulr | off for an hour | 10:41 |
paulr | but if that's the plan | 10:41 |
paulr | 1 array | 10:41 |
paulr | strings for messages | 10:41 |
paulr | ints for errors | 10:42 |
paulr | i'll fix that up when i get back | 10:42 |
dhx1 | probably just ints? | 10:43 |
dhx1 | or perhaps not ints... but string representations of ints | 10:43 |
dhx1 | ie. error code vs error number | 10:43 |
dhx1 | error codes could contain alphanumeric characters | 10:43 |
dhx1 | not too sure about all of this though | 10:44 |
*** Quits: daryn (~daryn@h132.111.88.75.dynamic.ip.windstream.net) (Ping timeout: 240 seconds) | 11:01 | |
*** Joins: daryn (~daryn@h132.111.88.75.dynamic.ip.windstream.net) | 11:04 | |
*** Quits: dhx1 (~anonymous@c122-107-170-247.eburwd5.vic.optusnet.com.au) (Remote host closed the connection) | 11:34 | |
*** Joins: dhx1 (~anonymous@c122-107-170-247.eburwd5.vic.optusnet.com.au) | 11:37 | |
*** Quits: siebrand (~beis@145.20.145.137) () | 11:48 | |
*** Quits: daryn (~daryn@h132.111.88.75.dynamic.ip.windstream.net) (Ping timeout: 240 seconds) | 11:53 | |
*** Joins: daryn (~daryn@h132.111.88.75.dynamic.ip.windstream.net) | 11:54 | |
*** Quits: daryn (~daryn@h132.111.88.75.dynamic.ip.windstream.net) (Ping timeout: 240 seconds) | 12:33 | |
*** Joins: daryn (~daryn@h132.111.88.75.dynamic.ip.windstream.net) | 12:33 | |
*** Quits: rolfkleef (~rolf@urtica.xs4all.nl) (Quit: Leaving.) | 13:30 | |
paulr | lo daryn | 13:51 |
daryn | hi | 13:52 |
LadySerena | is there an option or plugin that can collapse the "Related Changesets" section of an issue page by default? | 13:55 |
LadySerena | 'cause seriously, this is getting ridiculously long: http://dev.vocasystem.net/mantis/view.php?id=1 | 13:55 |
paulr | daryn: did you see dhx/me? | 13:57 |
daryn | ya | 13:57 |
paulr | [03:41.48] <paulr> 1 array | 13:57 |
paulr | [03:41.51] <paulr> strings for messages | 13:57 |
paulr | [03:41.53] <paulr> ints for errors | 13:57 |
paulr | [03:41.57] <paulr> i'll fix that up when i get back | 13:57 |
paulr | [03:43.11] <dhx1> probably just ints? | 13:57 |
paulr | [03:43.36] <dhx1> or perhaps not ints... but string representations of ints | 13:57 |
paulr | [03:43.43] <dhx1> ie. error code vs error number | 13:57 |
paulr | [03:43.53] <dhx1> error codes could contain alphanumeric characters | 13:57 |
paulr | [03:44.31] <dhx1> not too sure about all of this though | 13:57 |
*** Joins: siebrand (~beis@sm.xs4all.nl) | 14:00 | |
paulr | probably makes life easier for siebrand too if we do that | 14:00 |
siebrand | probably, indeed | 14:01 |
paulr | :) | 14:01 |
daryn | yeah...i don't see a problem with it at first glance. so you'd remove MANTIS_ERROR and use the ERROR_* constants as the key in the lang files? | 14:02 |
paulr | yes | 14:05 |
paulr | simplifies code | 14:05 |
paulr | can't see flaw atm | 14:05 |
paulr | :P | 14:05 |
siebrand | except that we have new style messages (also keys afaik) in master, and old style in our 1.2.x branch | 14:33 |
siebrand | so there'll be awkward merging. | 14:33 |
siebrand | So I'd rather wait with that until our 'current release' branch has the new system, or the new system is backported to 1.2.x. | 14:33 |
paulr | siebrand: well, I guess the question is whether we still translate 1.2.x | 14:47 |
paulr | personally | 14:49 |
paulr | I'd like to see us delete all the _lang files from git | 14:49 |
paulr | and kinda rebuild them from translate wiki | 14:49 |
siebrand | paulr: yeah, we talked about that, and that will work, but if the keys are changed, there's nothing to rebuild. | 15:25 |
siebrand | paulr: if we have a 'near future' (say 2-4 months) release goal for 1.3, I could work on it.. | 15:26 |
*** Quits: daryn (~daryn@h132.111.88.75.dynamic.ip.windstream.net) (Ping timeout: 245 seconds) | 15:43 | |
*** Joins: daryn (~daryn@h132.111.88.75.dynamic.ip.windstream.net) | 15:56 | |
*** Quits: moto-moi (~hylke@cara.xs4all.nl) (Ping timeout: 272 seconds) | 17:39 | |
*** Joins: rolfkleef (~rolf@urtica.xs4all.nl) | 17:51 | |
*** Joins: rshaffaf (4a0dd982@gateway/web/freenode/ip.74.13.217.130) | 18:21 | |
rshaffaf | hello - anyone out there? | 18:22 |
rshaffaf | I need some help with this Mantis SVN plugin | 18:23 |
rshaffaf | Alright - gotta roll. Deftones and Alice in Chains tonight | 18:27 |
*** Quits: rshaffaf (4a0dd982@gateway/web/freenode/ip.74.13.217.130) (Quit: Page closed) | 18:28 | |
giallu | nuclear_eclipse, around? | 18:50 |
*** Quits: rolfkleef (~rolf@urtica.xs4all.nl) (Ping timeout: 252 seconds) | 18:54 | |
* paulr yawns | 19:29 | |
CIA-100 | Mantisbt: giallu master-1.1.x * r3bc117fc8700 /print_all_bug_page_word.php: Fix #12371: XSS in print_all_bug_page_word.php project/category names | 19:42 |
CIA-100 | Mantisbt: giallu master-1.1.x * r51ee3d3fd47e /core/custom_field_api.php: Fix #12370: Multiple XSS issues with custom field enumeration values | 19:42 |
CIA-100 | Mantisbt: giallu master-1.1.x * r8f1ebac61d30 /manage_proj_cat_delete.php: Fix #12369: XSS vulnerability when deleting maliciously named categories | 19:42 |
*** Quits: giallu (~giallu@fedora/giallu) (Ping timeout: 252 seconds) | 19:53 | |
*** Quits: scribe9343423 (~scribe934@static.96.23.63.178.clients.your-server.de) (Remote host closed the connection) | 20:00 | |
*** Joins: scribe9343423 (~scribe934@static.96.23.63.178.clients.your-server.de) | 20:00 | |
paulr | dhx: up yet? | 20:54 |
*** Quits: paulr (~IceChat09@2001:470:9310:aaaa:e924:7a29:4426:7e66) (Ping timeout: 252 seconds) | 20:58 | |
*** Joins: micahg (~micah@ubuntu/member/micahg) | 21:31 | |
dhx1 | dhx1: hi | 23:03 |
dhx1 | oops... :) | 23:03 |
daryn | dhx1: that busy, huh? | 23:05 |
dhx1 | daryn: haha | 23:07 |
daryn | :) | 23:07 |
*** Quits: daryn (~daryn@h132.111.88.75.dynamic.ip.windstream.net) (Ping timeout: 245 seconds) | 23:53 | |
*** Joins: daryn (~daryn@h132.111.88.75.dynamic.ip.windstream.net) | 23:53 |
Generated by irclog2html.py 2.9.2 by Marius Gedminas - find it at mg.pov.lt!