*** Joins: Dreksypoo (~Jon@ool-18bfe16f.dyn.optonline.net) | 00:59 | |
*** Quits: wolog (~wolog@wolog.info) (Ping timeout: 260 seconds) | 00:59 | |
*** Quits: JonMarkGo (~Jon@ool-18bfe16f.dyn.optonline.net) (*.net *.split) | 01:04 | |
*** Quits: chris38 (~chris38@AGrenoble-751-1-19-124.w86-206.abo.wanadoo.fr) (*.net *.split) | 01:04 | |
*** Quits: CIA-135 (~CIA@cia.atheme.org) (*.net *.split) | 01:04 | |
*** Quits: sgimeno (~sgimeno@163.117.206.10) (*.net *.split) | 01:04 | |
*** Quits: scribe9343423 (~scribe934@static.96.23.63.178.clients.your-server.de) (*.net *.split) | 01:05 | |
*** Quits: foobot (~foobot@leetcode.net) (*.net *.split) | 01:05 | |
*** Quits: tsnfoo (~fulekia@ws-imac27.test.denison.edu) (*.net *.split) | 01:05 | |
*** Quits: Dreksypoo (~Jon@ool-18bfe16f.dyn.optonline.net) (Ping timeout: 277 seconds) | 01:05 | |
*** Joins: wolog_ (~wolog@wolog.info) | 01:05 | |
*** Joins: scribe9343423 (~scribe934@static.96.23.63.178.clients.your-server.de) | 01:05 | |
*** Joins: foobot (~foobot@leetcode.net) | 01:05 | |
*** Joins: sgimeno (~sgimeno@163.117.206.10) | 01:05 | |
*** Joins: CIA-135 (~CIA@cia.atheme.org) | 01:05 | |
*** Joins: tsnfoo (~fulekia@ws-imac27.test.denison.edu) | 01:05 | |
*** Joins: chris38 (~chris38@AGrenoble-751-1-19-124.w86-206.abo.wanadoo.fr) | 01:05 | |
*** Quits: siebrand (~siebrand@5353A6DC.cm-6-4c.dynamic.ziggo.nl) (Read error: Connection reset by peer) | 01:59 | |
*** Joins: siebrand (~siebrand@5353A6DC.cm-6-4c.dynamic.ziggo.nl) | 01:59 | |
*** Joins: giallu (~giallu@fedora/giallu) | 02:31 | |
*** Joins: T-One (~T-One@213.33.91.2) | 03:07 | |
*** Joins: asm89 (~asm89@unaffiliated/asm89) | 03:13 | |
*** Joins: soustruh (~Miranda@ip-86-49-121-75.net.upcbroadband.cz) | 03:51 | |
*** Joins: cerf (~quassel@mcl71-3-78-241-52-239.fbx.proxad.net) | 04:07 | |
*** Quits: Ragnor (~Ragnor@dslb-178-009-171-202.pools.arcor-ip.net) (Ping timeout: 258 seconds) | 04:53 | |
*** Joins: dhx1 (~anonymous@60-242-108-164.static.tpgi.com.au) | 05:09 | |
dregad | dhx1: hi | 05:55 |
---|---|---|
dhx1 | dregad: hey | 05:56 |
dregad | quick question | 05:56 |
dregad | I was looking at http://www.mantisbt.org/bugs/view.php?id=13303 | 05:56 |
dregad | The guy has issue with ini_get_bool() not returning right value when entry with wrong case in php.ini | 05:56 |
dregad | I think he's got a point | 05:57 |
dregad | The fix is easy enough ==> use strtolower() | 05:57 |
dregad | but then I thought - what happens if someone enters an uncovered value in php.ini, e.g. config = XXX | 05:57 |
dregad | since the switch has no default, we have undefined behavior | 05:58 |
dregad | so I believe we should introduce a default case - do you agree ? | 05:59 |
dregad | and set the default to false | 06:00 |
* dregad is done typing ;) | 06:00 | |
*** Joins: Ragnor (~Ragnor@dslb-178-009-172-017.pools.arcor-ip.net) | 06:00 | |
* dregad pings dhx1 | 06:06 | |
dhx1 | dregad: ack, 1sec | 06:12 |
dhx1 | dregad: you're right.. perhaps the default case should throw a generic error | 06:19 |
dhx1 | dregad: your patch looks good | 06:20 |
dregad | dhx1, thanks for feedback. ERROR_CONFIG_OPT_INVALID seems appropriate, if I prefix the config name with [php.ini] | 06:27 |
dregad | what do you think | 06:27 |
dhx1 | hmm I'd rather avoid that because in 'next' I'm trying to ensure that each error is used for a single purpose | 06:28 |
dhx1 | ERROR_CONFIG_OPT_INVALID refers to MantisBT configuration | 06:28 |
dhx1 | which would be confusing if someone was receiving the error (thinking that it was for MantisBT configuration) when they should be looking at php.ini instead | 06:28 |
dregad | hence prefixing with php.ini | 06:33 |
dregad | but maybe it's overkill to throw an error anyway | 06:35 |
dregad | how would php itself react, if it was given an invalid boolean value in the ini file ? | 06:36 |
dhx1 | not sure... | 06:36 |
dhx1 | IMO don't bother with the default case for now | 06:36 |
dhx1 | I think returning null would be equivalent to 'false' in many parts of the code anyway | 06:37 |
dhx1 | and generally 'false' is better than 'true' for checks | 06:37 |
dhx1 | (as a default state) | 06:37 |
dhx1 | maybe the other way around... ;) | 06:37 |
dhx1 | anyway, the user has bigger problems if their php.ini is completely wrong | 06:37 |
dregad | dhx1: just tested php behavior - I set file_upload = XXX in php.ini, bounced apache ==> file_upload == false | 06:42 |
dregad | so you're right, no need to bother with default case | 06:42 |
dhx1 | :) | 06:42 |
dregad | PHP does it for us | 06:42 |
dregad | dhx1: thanks for your feedback as usual - it's always nice to be able to bounce one's thoughts off someone with experience | 06:44 |
dhx1 | dregad: thanks for looking into the issue :) | 06:44 |
GitHub198 | [mantisbt] dregad pushed 1 new commit to master-1.2.x: http://git.io/eNkG2g | 07:55 |
GitHub198 | [mantisbt/master-1.2.x] Fix #13303: use strtolower in ini_get_bool() - Damien Regad | 07:55 |
GitHub63 | [mantisbt] dregad pushed 1 new commit to master: http://git.io/xESulA | 07:56 |
GitHub63 | [mantisbt/master] Fix #13303: use strtolower in ini_get_bool() - Damien Regad | 07:56 |
*** Joins: soc42 (~soc42@f051137252.adsl.alicedsl.de) | 08:28 | |
*** Joins: JonMarkGo (~Jon@ool-18bfe16f.dyn.optonline.net) | 09:32 | |
*** Quits: JonMarkGo (~Jon@ool-18bfe16f.dyn.optonline.net) (Ping timeout: 258 seconds) | 10:27 | |
*** Quits: dhx1 (~anonymous@60-242-108-164.static.tpgi.com.au) (Remote host closed the connection) | 10:33 | |
*** Quits: cerf (~quassel@mcl71-3-78-241-52-239.fbx.proxad.net) (Remote host closed the connection) | 10:53 | |
*** Quits: asm89 (~asm89@unaffiliated/asm89) (Quit: bye!) | 11:32 | |
*** Quits: soustruh (~Miranda@ip-86-49-121-75.net.upcbroadband.cz) (Quit: visit http://wormscesky.cz) | 11:50 | |
*** Quits: Ragnor (~Ragnor@dslb-178-009-172-017.pools.arcor-ip.net) (Ping timeout: 276 seconds) | 11:57 | |
*** Quits: giallu (~giallu@fedora/giallu) (Ping timeout: 260 seconds) | 12:00 | |
*** Joins: Ragnor (~Ragnor@dslb-188-100-038-173.pools.arcor-ip.net) | 12:23 | |
*** Joins: soustruh (~Miranda@ip-86-49-121-75.net.upcbroadband.cz) | 12:52 | |
*** Quits: T-One (~T-One@213.33.91.2) (Ping timeout: 258 seconds) | 12:53 | |
*** Joins: Paul24 (~IceChat09@2001:470:9310:aaaa:114e:8fed:bf43:b67e) | 13:44 | |
*** Joins: heverl (~hever@85-222-28-130.home.aster.pl) | 15:25 | |
heverl | Hello, what must I do to get mantis working over https ? | 15:25 |
heverl | Ok found it in the docs sry | 15:28 |
*** Quits: wolog_ (~wolog@wolog.info) (Quit: leaving) | 15:41 | |
*** Joins: wolog (~wolog@wolog.info) | 15:43 | |
*** Quits: PennStater (~Aaron@unaffiliated/pennstater) (*.net *.split) | 16:02 | |
*** Quits: heverl (~hever@85-222-28-130.home.aster.pl) (*.net *.split) | 16:02 | |
*** Quits: soustruh (~Miranda@ip-86-49-121-75.net.upcbroadband.cz) (*.net *.split) | 16:02 | |
*** Quits: siebrand (~siebrand@5353A6DC.cm-6-4c.dynamic.ziggo.nl) (*.net *.split) | 16:02 | |
*** Quits: dregad (~dregad@wwwgate1.merck.de) (*.net *.split) | 16:02 | |
*** Quits: ComputerNewbie (~adsfasdf@c-67-160-201-8.hsd1.ca.comcast.net) (*.net *.split) | 16:02 | |
*** Quits: DarkStar851 (~DarkStar8@142.163.169.117) (*.net *.split) | 16:02 | |
*** Quits: Gisterogue (~Gisterogu@150.237.48.99) (*.net *.split) | 16:03 | |
*** Quits: killefiz (~sven@fedora/pdpc.base.killefiz) (*.net *.split) | 16:03 | |
*** Joins: heverl (~hever@85-222-28-130.home.aster.pl) | 16:03 | |
*** Joins: soustruh (~Miranda@ip-86-49-121-75.net.upcbroadband.cz) | 16:03 | |
*** Joins: siebrand (~siebrand@5353A6DC.cm-6-4c.dynamic.ziggo.nl) | 16:03 | |
*** Joins: dregad (~dregad@wwwgate1.merck.de) | 16:03 | |
*** Joins: ComputerNewbie (~adsfasdf@c-67-160-201-8.hsd1.ca.comcast.net) | 16:03 | |
*** Joins: PennStater (~Aaron@unaffiliated/pennstater) | 16:03 | |
*** Joins: DarkStar851 (~DarkStar8@142.163.169.117) | 16:03 | |
*** Joins: Gisterogue (~Gisterogu@150.237.48.99) | 16:03 | |
*** Joins: killefiz (~sven@fedora/pdpc.base.killefiz) | 16:03 | |
*** Quits: Lukosanthropos (~Lukosanth@cpc23-seac20-2-0-cust78.7-2.cable.virginmedia.com) (Read error: Connection reset by peer) | 16:13 | |
*** Joins: Lukosanthropos (~Lukosanth@cpc23-seac20-2-0-cust78.7-2.cable.virginmedia.com) | 16:13 | |
*** Joins: jreese (~jreese@noswap.com) | 16:15 | |
*** Joins: Paul24 (~IceChat09@2001:470:9310:aaaa:114e:8fed:bf43:b67e) | 16:16 | |
*** Joins: sezuan (bouncer@irc.scheff32.de) | 16:16 | |
*** heverl is now known as hever | 16:16 | |
*** Quits: Lukosanthropos (~Lukosanth@cpc23-seac20-2-0-cust78.7-2.cable.virginmedia.com) (*.net *.split) | 16:18 | |
*** Quits: Deepy_ (freenode@109-124-157-251.customer.t3.se) (*.net *.split) | 16:18 | |
*** Joins: Lukosanthropos (~Lukosanth@cpc23-seac20-2-0-cust78.7-2.cable.virginmedia.com) | 16:19 | |
*** Joins: Deepy_ (freenode@109.124.157.251) | 16:21 | |
*** Joins: d-man97 (~d-man97@c-68-43-167-253.hsd1.mi.comcast.net) | 16:24 | |
d-man97 | With respect to enum strings, when do I use underscore and when can I use a space? And how do they interact? The manuals say nothing about the naming scheme. | 16:25 |
*** Quits: soc42 (~soc42@f051137252.adsl.alicedsl.de) (Remote host closed the connection) | 16:25 | |
d-man97 | $g_status_enum_string in config_inc.php - seems to not affect anything if I swap _ and spaces. $s_status_enum_string in custom_strings_inc.php - seems to allow spaces, as it is used to display the text in the "Change Status To:" drop-down. How do both interact with the defined constants? Everything seems to work no matter how I modify them. Additionally, I have a constant: define('TESTING', 70) - however, everywhere else it is "to | 16:32 |
d-man97 | Also, I changed some default constants (30:acknowledged,40:confirmed,50:assigned to 30:assigned,40:acknowledged,50:confirmed) and no matter if i used the old or new numbering in the enum strings...nothing changed. it all still worked, all bugs still had the correct status. If I change 30 from meaning ack to meaning assigned...shouldn't all the bugs change too? Very confusing. | 16:34 |
d-man97 | For `$s_email_notification_title_for_status_bug_to_be_tested` would that relate to the TO_BE_TESTED constant, or would it relate to the "70:to be tested" in my `$s_status_enum_string`/`$g_status_enum_string`? What's the difference, if any, in the construction of the string between the g and the s version? What about in use? 's' seems to be used in the "Change Status To:" drop-down... | 16:42 |
d-man97 | Condensed it: http://pastebin.com/NgdaxuZs | 16:59 |
d-man97 | If anyone could help clarify, that would be great! d-man97 [at] yahoo [dot] com | 16:59 |
hever | How can I replace the field "Platform" in Report Issue? | 17:00 |
hever | How can I enable public bug reporting? | 18:08 |
*** Quits: hever (~hever@85-222-28-130.home.aster.pl) (Remote host closed the connection) | 18:19 | |
*** Quits: d-man97 (~d-man97@c-68-43-167-253.hsd1.mi.comcast.net) (Quit: Leaving.) | 18:25 | |
*** Quits: Paul24 (~IceChat09@2001:470:9310:aaaa:114e:8fed:bf43:b67e) (Ping timeout: 240 seconds) | 18:35 | |
*** Joins: Paul24 (~IceChat09@cpc2-enfi9-0-0-cust94.hari.cable.virginmedia.com) | 18:36 | |
*** Quits: soustruh (~Miranda@ip-86-49-121-75.net.upcbroadband.cz) (Quit: visit http://wormscesky.cz) | 18:59 | |
*** Quits: Paul24 (~IceChat09@cpc2-enfi9-0-0-cust94.hari.cable.virginmedia.com) (Quit: Given the choice between you, I'll take the sea-sick crocodile.) | 19:43 | |
*** Quits: scribe9343423 (~scribe934@static.96.23.63.178.clients.your-server.de) (Remote host closed the connection) | 20:00 | |
*** Joins: scribe9343423 (~scribe934@static.96.23.63.178.clients.your-server.de) | 20:00 | |
*** Joins: d-man97 (~d-man97@c-68-43-167-253.hsd1.mi.comcast.net) | 20:11 | |
*** Quits: d-man97 (~d-man97@c-68-43-167-253.hsd1.mi.comcast.net) (Quit: Leaving.) | 20:19 | |
*** Joins: T-One (~T-One@213.33.91.2) | 21:00 | |
*** Joins: JonMarkGo (~Jon@ool-18bfe16f.dyn.optonline.net) | 21:15 | |
*** Quits: T-One (~T-One@213.33.91.2) (Read error: Connection reset by peer) | 21:22 | |
*** Joins: Cesare (~Adium@creati59.lnk.telstra.net) | 21:23 | |
*** Parts: Cesare (~Adium@creati59.lnk.telstra.net) () | 21:25 | |
*** Quits: tsnfoo (~fulekia@ws-imac27.test.denison.edu) (Quit: tsnfoo) | 22:09 | |
*** Joins: tsnfoo (~fulekia@ws-imac27.test.denison.edu) | 22:10 | |
*** Quits: siebrand (~siebrand@5353A6DC.cm-6-4c.dynamic.ziggo.nl) (Read error: Connection reset by peer) | 23:34 | |
*** Joins: siebrand_ (~siebrand@5353A6DC.cm-6-4c.dynamic.ziggo.nl) | 23:34 |
Generated by irclog2html.py 2.9.2 by Marius Gedminas - find it at mg.pov.lt!